IAMMETER integration missing frequency and pfc from WEM3080 single phase monitor (Issue #143740)

nsaspook · April 27, 2025, 2:13pm

This is not a feature request in my universe of embedded SW but I was asked to make a feature request after my bug report was closed.

The integration IAMMETER already has the capability/feature, it just does it incorrectly (too few input processed in code already capable of doing all it needed) for the specified device and does it correctly for others. It is a one constant variable fix, change a 5 to a 7.

github.com/home-assistant/core

homeassistant/components/iammeter/sensor.py

7a0580eff

"""Support for iammeter via local API."""

from __future__ import annotations

from asyncio import timeout
from collections.abc import Callable
from dataclasses import dataclass
from datetime import datetime, timedelta
import logging

from iammeter.client import IamMeter
import voluptuous as vol

from homeassistant.components.sensor import (
    PLATFORM_SCHEMA as SENSOR_PLATFORM_SCHEMA,
    SensorDeviceClass,
    SensorEntity,
    SensorEntityDescription,
    SensorStateClass,
)

This file has been truncated. show original

id_phase_range = 1 if model == DEVICE_3080 else 4
id_name_range = 5 if model == DEVICE_3080 else 7

mib1185 · April 27, 2025, 8:55pm

Hi @nsaspook
If you know what to change, then please feel free to open a PR. Contributions are always highly appreciated

nsaspook · April 30, 2025, 8:23pm

How do you open a PR?

I filed a BUG report, but it was closed.

Tamsy · May 1, 2025, 3:15am

On how to create a Pull Request on GitHub please look HERE and HERE.

nsaspook · May 1, 2025, 3:31am

Thanks. PR to me means a Purchase Request or Public Relations.

mib1185 · May 1, 2025, 7:40am

I would also recommend to read the contribution guide of the HA core project.

nsaspook · May 2, 2025, 11:57pm

I tried the PR but screw that up as I couldn’t figure out exactly where the patches go in the HA core source. So what I posted was incomplete. The device communications and variable parsing part if the is not located with the sensor code that formats the data into the HA API.
core/homeassistant/components/iammeter

I have no idea where the client.py and power_meter.py parts of the updated code go in the HA tree.

My set of working codes for the IAMMETER update for the WEM3080 devices running is here.

{“method”:“1-529”,“mac”:“849DC2D20710”,“version”:“i.76.058.8”,“server”:“em”,“SN”:“91442335”,“Data”:[121.34,0.38,-38.0,0.00,30.73,60.01,0.83]}