fredrike
(Fredrik Erlandsson)
June 28, 2023, 7:32am
183
localhost
should be your home-assistant address.
fredrike
(Fredrik Erlandsson)
June 28, 2023, 7:34am
184
Could you send some screenshots whatās going on?
This is the error message I get after I click the authentication link from the integration setup.
{"message":"Unable to issue redirect for OAuth 2.0 transaction","code":"server_error","status":500,"name":"AuthorizationError","error_key":"internal_server_error"}
Hereās a screenshot of the redirect url on the Minut api page.
Iām out of my depth here, but this page describes a change to how OAuth 2.0 handles redirects. Perhaps helpful? Unable to issue redirect for OAuth 2.0 transaction - login - Auth0 Community
fredrike
(Fredrik Erlandsson)
June 30, 2023, 8:56am
187
It could be that you need a https connectionā¦
Do you access your homeassistant instance via http://homeassistant.local:8123 ?
Yes, I can access it without a secure connection. The error message is different if thereās a mismatch between (1) the allowed redirect uri as set on the minut web app and (2) the url Iām using to access home assistant. It gives a redirect_uri_mismatch error. The error message in my previous post is the error message it shows when everything appears to be properly configured.
Is it possible this has to do with failing to pass a redirect_uri parameter? OAuth 2.0 now appears to require it per my post above?
If I copy the link in the image below and manually add the proper redirect_uri, a web page opens saying āOK!ā with a token code in the URL.
1 Like
fredrike
(Fredrik Erlandsson)
July 11, 2023, 9:17am
190
Iāll try to update the integration with this!
Thanks for finding it!
menaibluey
(Markus Marbach)
February 23, 2024, 2:19am
191
Hi, has this been resolved? Iām still not seeing the redirect_uri parameter added which is mandatory as per the Minut API doco.at Minut API documentation .
Adding it manually does return to the HA home page but entities are not being generated.
AlohaFlyer
(Ryan Pettit)
March 9, 2024, 3:53am
192
I would also like to get this working. Still having authentication issues.
fredrike
(Fredrik Erlandsson)
May 21, 2024, 8:00am
193
There are a discussion on whatās going on here: Unable to setup authentication with Minut Point Ā· Issue #91583 Ā· home-assistant/core (github.com)
TLDR;
Iāve fixed the missing redirect_uri
in the configuration flow, the problem is that the whole configuration flow needs to be re-written to support oauth2 flow and Iāve not had time to do this.
1 Like
Is there anything I/we can help out with to get this working properly?
fredrike
(Fredrik Erlandsson)
May 22, 2024, 12:11pm
195
Not really. I just need a few hours without the family asking for my attention (perhaps send them bowling or on a movie could give me the necessary time).
1 Like
fredrike
(Fredrik Erlandsson)
May 24, 2024, 2:18pm
196
Just a teaser, this is how far I am.
Had to contact Minut to set another redirect_uri
(the new one should be: Link to OAuth2 Authorize Callback ā My Home Assistant ) as Iām an old Kickstarter backer. If someone have a pro-account send me a PM with CLIENT_ID/CLIENT_SECRET and Iāll continue the work.
fredrike
(Fredrik Erlandsson)
May 27, 2024, 1:03pm
197
So, I have a draft on how to fix the oauth2 issues now.
Still plenty to fix to get it up to standards.
home-assistant:dev
ā fredrike:point-oauth
opened 12:23PM - 27 May 24 UTC
## Proposed change
<!--
Describe the big picture of your changes here to comā¦ municate to the
maintainers why we should accept this pull request. If it fixes a bug
or resolves a feature request, be sure to link to that issue in the
additional information section.
-->
Add support for native oauth2 in Point integration.
## Type of change
<!--
What type of change does your PR introduce to Home Assistant?
NOTE: Please, check only 1! box!
If your PR requires multiple boxes to be checked, you'll most likely need to
split it into multiple PRs. This makes things easier and faster to code review.
-->
- [x] Dependency upgrade
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [ ] New feature (which adds functionality to an existing integration)
- [ ] Deprecation (breaking change to happen in the future)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [x] Code quality improvements to existing code or addition of tests
## Additional information
<!--
Details are important, and help maintainers processing your PR.
Please be sure to fill out additional details, if applicable.
-->
- This PR fixes or closes issue: fixes #91583
- This PR is related to issue: https://github.com/home-assistant/core/pull/100843, https://github.com/home-assistant/core/pull/101967
- Link to documentation pull request:
## Checklist
<!--
Put an `x` in the boxes that apply. You can also fill these out after
creating the PR. If you're unsure about any of them, don't hesitate to ask.
We're here to help! This is simply a reminder of what we are going to look
for before merging your code.
-->
- [x] The code change is tested and works locally.
- [ ] Local tests pass. **Your PR cannot be merged unless tests pass**
- [ ] There is no commented out code in this PR.
- [ ] I have followed the [development checklist][dev-checklist]
- [ ] I have followed the [perfect PR recommendations][perfect-pr]
- [ ] The code has been formatted using Ruff (`ruff format homeassistant tests`)
- [ ] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated for [www.home-assistant.io][docs-repository]
If the code communicates with devices, web services, or third-party tools:
- [ ] The [manifest file][manifest-docs] has all fields filled out correctly.
Updated and included derived files by running: `python3 -m script.hassfest`.
- [ ] New or updated dependencies have been added to `requirements_all.txt`.
Updated by running `python3 -m script.gen_requirements_all`.
- [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
- [ ] Untested files have been added to `.coveragerc`.
<!--
This project is very active and we have a high turnover of pull requests.
Unfortunately, the number of incoming pull requests is higher than what our
reviewers can review and merge so there is a long backlog of pull requests
waiting for review. You can help here!
By reviewing another pull request, you will help raise the code quality of
that pull request and the final review will be faster. This way the general
pace of pull request reviews will go up and your wait time will go down.
When picking a pull request to review, try to choose one that hasn't yet
been reviewed.
Thanks for helping out!
-->
To help with the load of incoming pull requests:
- [ ] I have reviewed two other [open pull requests][prs] in this repository.
[prs]: https://github.com/home-assistant/core/pulls?q=is%3Aopen+is%3Apr+-author%3A%40me+-draft%3Atrue+-label%3Awaiting-for-upstream+sort%3Acreated-desc+review%3Anone+-status%3Afailure
<!--
Thank you for contributing <3
Below, some useful links you could explore:
-->
[dev-checklist]: https://developers.home-assistant.io/docs/development_checklist/
[manifest-docs]: https://developers.home-assistant.io/docs/creating_integration_manifest/
[quality-scale]: https://developers.home-assistant.io/docs/integration_quality_scale_index/
[docs-repository]: https://github.com/home-assistant/home-assistant.io
[perfect-pr]: https://developers.home-assistant.io/docs/review-process/#creating-the-perfect-pr
@Ferretmonger et.al.:
Please have a look at the updated documentation, Minut Point - Home Assistant . Does it make sense?
Edit, updated link to documentation.
1 Like
Did someone send you the CLIENT_ID/CLIENT_SECRET for you to test?
fredrike
(Fredrik Erlandsson)
May 28, 2024, 7:35am
199
I got in contact with Minut so they have updated my Client-credentials.
The code in #118243 works fine on my computer. I just need to fix tests and migration from the old config to new.
2 Likes
fredrike
(Fredrik Erlandsson)
June 13, 2024, 8:06am
200
Iām still waiting for a review of the PR so we could get the fixes for Point merged. I do not know whatās taking so longā¦
home-assistant:dev
ā fredrike:point-oauth
opened 12:23PM - 27 May 24 UTC
## Proposed change
<!--
Describe the big picture of your changes here to comā¦ municate to the
maintainers why we should accept this pull request. If it fixes a bug
or resolves a feature request, be sure to link to that issue in the
additional information section.
-->
Add support for native oauth2 in Point integration.
## Type of change
<!--
What type of change does your PR introduce to Home Assistant?
NOTE: Please, check only 1! box!
If your PR requires multiple boxes to be checked, you'll most likely need to
split it into multiple PRs. This makes things easier and faster to code review.
-->
- [x] Dependency upgrade
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [x] New feature (which adds functionality to an existing integration)
- [x] Deprecation (breaking change to happen in the future)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [x] Code quality improvements to existing code or addition of tests
## Additional information
<!--
Details are important, and help maintainers processing your PR.
Please be sure to fill out additional details, if applicable.
-->
- This PR fixes or closes issue: fixes #91583
- This PR is related to issue: https://github.com/home-assistant/core/pull/100843, https://github.com/home-assistant/core/pull/101967
- Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/32971
## Checklist
<!--
Put an `x` in the boxes that apply. You can also fill these out after
creating the PR. If you're unsure about any of them, don't hesitate to ask.
We're here to help! This is simply a reminder of what we are going to look
for before merging your code.
-->
- [x] The code change is tested and works locally.
- [x] Local tests pass. **Your PR cannot be merged unless tests pass**
- [x] There is no commented out code in this PR.
- [x] I have followed the [development checklist][dev-checklist]
- [x] I have followed the [perfect PR recommendations][perfect-pr]
- [x] The code has been formatted using Ruff (`ruff format homeassistant tests`)
- [x] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [x] Documentation added/updated for [www.home-assistant.io][docs-repository]
If the code communicates with devices, web services, or third-party tools:
- [x] The [manifest file][manifest-docs] has all fields filled out correctly.
Updated and included derived files by running: `python3 -m script.hassfest`.
- [x] New or updated dependencies have been added to `requirements_all.txt`.
Updated by running `python3 -m script.gen_requirements_all`.
- [x] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
- [x] Untested files have been added to `.coveragerc`.
<!--
This project is very active and we have a high turnover of pull requests.
Unfortunately, the number of incoming pull requests is higher than what our
reviewers can review and merge so there is a long backlog of pull requests
waiting for review. You can help here!
By reviewing another pull request, you will help raise the code quality of
that pull request and the final review will be faster. This way the general
pace of pull request reviews will go up and your wait time will go down.
When picking a pull request to review, try to choose one that hasn't yet
been reviewed.
Thanks for helping out!
-->
To help with the load of incoming pull requests:
- [x] I have reviewed two other [open pull requests][prs] in this repository.
[prs]: https://github.com/home-assistant/core/pulls?q=is%3Aopen+is%3Apr+-author%3A%40me+-draft%3Atrue+-label%3Awaiting-for-upstream+sort%3Acreated-desc+review%3Anone+-status%3Afailure
<!--
Thank you for contributing <3
Below, some useful links you could explore:
-->
[dev-checklist]: https://developers.home-assistant.io/docs/development_checklist/
[manifest-docs]: https://developers.home-assistant.io/docs/creating_integration_manifest/
[quality-scale]: https://developers.home-assistant.io/docs/integration_quality_scale_index/
[docs-repository]: https://github.com/home-assistant/home-assistant.io
[perfect-pr]: https://developers.home-assistant.io/docs/review-process/#creating-the-perfect-pr
1 Like
robbobkirk
(Rob Kirkbride)
June 13, 2024, 6:24pm
201
Thanks for the update, Iām glad the team I run donāt take this long to do a code review. i guess I need to remember that this is volunteers.
2 Likes
fredrike
(Fredrik Erlandsson)
October 14, 2024, 8:02pm
202
Is it working for everyone now?
1 Like