Why are purpose specific triggers not using 'source'

[Mariusthvdb (Marius)]

ever since the introduction of the purpose specific triggers, I had some sense of incompatibility with the used terminology and my way of looking at representation of the actual triggers.
they are supposed to be more ‘human’ and yet it didnt click

reading Petro’s post elsewhere now just made me realize what that is

its the use of target

this is how I see that, visually:
-----> target
source ------>

none of these triggers are ‘targeted’ at any entity. they are caused by these entities, or sourced from, whatever. its the complete opposite direction of how my mind sees these… could be me, obviously. please dont go there…

but seriously, isnt this naming a bit odd (of course I understand where it comes from, and being legacy always is tricky. breaking etc etc,
it would be a very simple fix though…)

just see how this works much better:

trigger: occupancy.detected
source:
  entity_id: binary_sensor.deck_motion_sensor_occupancy

could even be shorter

trigger: occupancy.detected
trigger_entity_id: binary_sensor.deck_motion_sensor_occupancy

but that might be too technical for the matter we’re dealing with here…

purpose specific triggers are a new concept, so it would fit a new key name. no reason to cling to the old

instead of:

@petro

This is what a purpose specific trigger would look like for an occupied binary sensor trigger.

trigger: occupancy.detected
target:
  entity_id: binary_sensor.deck_motion_sensor_occupancy

or if you targeted a device

trigger: occupancy.detected
target:
  device_id: b6ddde81f42651e5646e7368b6e3a2f1

or if you target an area

trigger: occupancy.detected
target:
  area: Kitchen

or a floor

trigger: occupancy.detected
target:
  floor: Upstairs

[petro]

Consistency. Target has been used for actions for a long time, it’s now available for conditions and triggers.

Its not a root key because it’s easier to validate data that’s a dictionary without string concatenation or explicit made keys. Also, you may not realize it but it’s better for users as a dictionary too.

[Mariusthvdb (Marius)]

@petro

Consistency. Target has been used for actions for a long time, it’s now available for conditions and triggers.

Its not a root key because it’s easier to validate data that’s a dictionary without string concatenation or explicit made keys

yeah but that is all backend stuff.
Purpose specific triggers are hailed as the new user oriented way of looking at things, so user should not be bothered with that legacy.

@petro

Also, you may not realize it but it’s better for users as a dictionary too.

this I dont follow. how would a key name make a difference there?

[Mariusthvdb (Marius)]

guess a way to translate those new triggers then is by thinking of it as

check the Kitchen area occupancy

in which the area would actually be a ‘target’ of sorts, but still feels weird to me

[petro]

Because there’s nothing to remember. It’s the same key used everywhere. You don’t need to run to the docs to remeber the yaml

It also makes yaml anchors more consistent

[Mariusthvdb (Marius)]

@petro

You don’t need to run to the docs to remeber the yaml

well, if that is going to be reason the world is lost…

btw, Arent we supposed to not even look at yaml… and those that do will read the docs. or at least are supposed to.

no that cant be a reason to not make things better
I hope

[petro]

@Mariusthvdb

Arent we supposed to not even look at yaml

And by that logic, this conversation is a moot point