3_14
(Piotr Machowski)
July 29, 2020, 5:13pm
1
I think it would be useful to add foreach
as a new type of loop to repeat
, as it is not always easy/possible/nice to do it using repeat.index
.
Additional related ideas:
Saving current value in repeat.value
Iterating over arrays created using jinja template
(e.g. {{ state_attr('group.all_devices', 'entity_id') }}
)
3_14
(Piotr Machowski)
July 29, 2020, 5:14pm
2
Calling @pnbruckner (creator of repeat action)
1 Like
maxym
July 29, 2020, 7:07pm
3
why not make life easier? Use Node Red. You can write functions in JavaScript.
3_14
(Piotr Machowski)
July 29, 2020, 7:21pm
4
I don’t need NR, I can do everything in HA. If I want to write code I use built-in python script .
2 Likes
finity
July 30, 2020, 3:37pm
5
Could you give an example of how it could be used? Maybe provide some pseudo-code.
Another example use case:
Hi,
I’m sure I’m using search in a bad way - can’t find a sample that matches my desire to clean up the following:
- alias: sunProtectService
##########################################
trigger:
- platform: state
entity_id: 'input_boolean.sunprotect'
action:
- service: cover.set_cover_position
data:
entity_id: cover.fenster_bad
position: 30
- delay: 0:00:01
- service: cover.set_cover_position
data:
…
3_14
(Piotr Machowski)
August 17, 2020, 8:21pm
7
My idea was to use it to call the same service with increasing delays between calls. There are a lot of potential uses
A draft PR has been created. Still need to create tests and update docs.
1 Like
Incredibly annoying that this was rejected. It’s exactly what I need for a few tasks. To work around this I end up having to generate lots of ugly code using ansible’s jinja2 templating to write homeassistant jinja2 templating code.
frenck
(Franck Nijhof)
April 15, 2022, 2:20pm
10
I’ve opened up a PR to add it here:
home-assistant:dev
← home-assistant:frenck-2022-0875
opened 11:30AM - 15 Apr 22 UTC
<!--
You are amazing! Thanks for contributing to our project!
Please, DO N… OT DELETE ANY TEXT from this template! (unless instructed).
-->
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
or resolves a feature request, be sure to link to that issue in the
additional information section.
-->
Add support for iterating over a list of items in automations and scripts using the repeat action.
```yaml
repeat:
for_each:
- hello
- world
sequence:
- service: system_log.write
data:
message: "{{ repeat.item }}"
level: warning
```
`for_each` can be a list of items (including templates), or a (complex) template resulting in a list of items. Lists of mappings/dicts is supported too.
```yaml
repeat:
for_each:
- language: English
hello: Hello
world: World
- language: Dutch
hello: Hallo
world: Wereld
sequence:
- service: system_log.write
data:
message: >-
{{ repeat.item.language }}: {{ repeat.item.hello }} {{ repeat.item.world }}
level: warning
```
## Type of change
<!--
What type of change does your PR introduce to Home Assistant?
NOTE: Please, check only 1! box!
If your PR requires multiple boxes to be checked, you'll most likely need to
split it into multiple PRs. This makes things easier and faster to code review.
-->
- [ ] Dependency upgrade
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [ ] New feature (which adds functionality to an existing integration)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
## Additional information
<!--
Details are important, and help maintainers processing your PR.
Please be sure to fill out additional details, if applicable.
-->
- This PR fixes or closes issue: fixes #
- This PR is related to issue:
- Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/22400
## Checklist
<!--
Put an `x` in the boxes that apply. You can also fill these out after
creating the PR. If you're unsure about any of them, don't hesitate to ask.
We're here to help! This is simply a reminder of what we are going to look
for before merging your code.
-->
- [ ] The code change is tested and works locally.
- [ ] Local tests pass. **Your PR cannot be merged unless tests pass**
- [ ] There is no commented out code in this PR.
- [ ] I have followed the [development checklist][dev-checklist]
- [ ] The code has been formatted using Black (`black --fast homeassistant tests`)
- [ ] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated for [www.home-assistant.io][docs-repository]
If the code communicates with devices, web services, or third-party tools:
- [ ] The [manifest file][manifest-docs] has all fields filled out correctly.
Updated and included derived files by running: `python3 -m script.hassfest`.
- [ ] New or updated dependencies have been added to `requirements_all.txt`.
Updated by running `python3 -m script.gen_requirements_all`.
- [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
- [ ] Untested files have been added to `.coveragerc`.
The integration reached or maintains the following [Integration Quality Scale][quality-scale]:
<!--
The Integration Quality Scale scores an integration on the code quality
and user experience. Each level of the quality scale consists of a list
of requirements. We highly recommend getting your integration scored!
-->
- [ ] No score or internal
- [ ] 🥈 Silver
- [ ] 🥇 Gold
- [ ] 🏆 Platinum
<!--
This project is very active and we have a high turnover of pull requests.
Unfortunately, the number of incoming pull requests is higher than what our
reviewers can review and merge so there is a long backlog of pull requests
waiting for review. You can help here!
By reviewing another pull request, you will help raise the code quality of
that pull request and the final review will be faster. This way the general
pace of pull request reviews will go up and your wait time will go down.
When picking a pull request to review, try to choose one that hasn't yet
been reviewed.
Thanks for helping out!
-->
To help with the load of incoming pull requests:
- [ ] I have reviewed two other [open pull requests][prs] in this repository.
[prs]: https://github.com/home-assistant/core/pulls?q=is%3Aopen+is%3Apr+-author%3A%40me+-draft%3Atrue+-label%3Awaiting-for-upstream+sort%3Acreated-desc+review%3Anone+-status%3Afailure
<!--
Thank you for contributing <3
Below, some useful links you could explore:
-->
[dev-checklist]: https://developers.home-assistant.io/docs/en/development_checklist.html
[manifest-docs]: https://developers.home-assistant.io/docs/en/creating_integration_manifest.html
[quality-scale]: https://developers.home-assistant.io/docs/en/next/integration_quality_scale_index.html
[docs-repository]: https://github.com/home-assistant/home-assistant.io
5 Likes
frenck
(Franck Nijhof)
April 15, 2022, 5:59pm
12
Marked it as the solution, as it has been merged. Will be part of the 2022.5 release.
2 Likes