Continuous Updates from Roomba, should be periodic

joejoethedogfaceboy · November 16, 2018, 9:00pm

ok, I figured it out. The roomba.py library is hardcoded with an interval of 1 second for connect/disconnect when set to PERIODIC (continuous: False)

github.com

pschmitt/roombapy/blob/master/roomba/roomba.py#L139


    client = RoombaMQTTClient(
        address=address,
        blid=blid,
        password=password)
    client.set_on_message(self.on_message)
    client.set_on_connect(self.on_connect)
    client.set_on_disconnect(self.on_disconnect)
    return client

def connect(self):
    if self.roomba_connected or self.periodic_connection_running:
        return

    if self.continuous:
        if not self._connect():
            raise Exception("failed to connect!")
    else:
        self._thread.daemon = True
        self._thread.start()

    self.time = time.time()  # save connection time

I changed the hard-coded value to 120 here:

github.com

pschmitt/roombapy/blob/master/roomba/roomba.py#L173


    self.log.error("Unable to connect to %s", self.address)
    raise RoombaConnectionError("Unable to connect to Roomba at {}".format(self.address))

def disconnect(self):
    if self.continuous:
        self.client.disconnect()
    else:
        self.stop_connection = True

def periodic_connection(self):
    # only one connection thread at a time!
    if self.periodic_connection_running:
        return
    self.periodic_connection_running = True
    while not self.stop_connection:
        if self._connect():
            time.sleep(self.periodic_connection_duration)
            self.client.disconnect()
        time.sleep(self.delay)

    self.client.disconnect()

The roomba.py is located at ~/homeassistant/lib/python3.6/site-packages/roomba/roomba.py for a standard HA install.