It’s all personal preference, the only bullet that has a drawback is device triggers. If you replace the device, your automation will be disabled and non-functional until you fix it. Secondly the functionality of the new device may not match the old device, so you’ll likely have to replace the entire trigger instead of making a small update. Thirdly, if the device is not discovered for some reason, your automation will fail and be disabled.
HA entity or MQTT Topic are hands down better than a device trigger. However they are both harder to add to an automation because they do not “guide you” along the way like a device trigger does.