Nardol
(Patrick ZAJDA)
February 10, 2022, 3:30pm
146
Nabucasa would be better if we could have some answers to our questions.
I cannot say it does not work, but it is half-working on my side.
I say half but maybe it works but as I cannot check it, I cannot know if it really works or not.
Nardol
(Patrick ZAJDA)
February 10, 2022, 3:32pm
147
I have nothing in logbook when asking if a light is on.
Looks like nabu casa makes some thing unclear.
calisro
(Rob)
February 10, 2022, 3:38pm
148
You can still use the local debugging to see if it is local.
chrome://inspect/#devices
You also see in HA itself, in the logbook, if commands are local
calisro
(Rob)
February 10, 2022, 3:45pm
151
@pergola.fabio yes but not for queries. I think that’s what he was asking about. btw, that image isn’t a local command. It should say local.
Ahh ok, indeed not for queries
calisro
(Rob)
February 10, 2022, 3:53pm
153
Has anyone confirmed this is working with a Google Nest Hub? I’m having issues with that device doing anything local.
EDIT: It needed a restart. I don’t think I ever restarted it. Works okay.
Could someone link me to the official google docs that say we need to use HTTP and not HTTPS for local fullfillment? Having a tough time finding that requirement being listed.
When I look at this code lab it says HTTPS is fine
The app can use TCP/UDP sockets or HTTP(S) requests to communicate with local devices.
It’s not there yet @dshokouhi
There is a PR for it to update the docs
calisro
(Rob)
February 10, 2022, 3:54pm
156
There is a PR for that. IT isn’t listed but i’ll link to the chat I had in one of the issues as well. One minute.
I am referring to docs by Google, not updated HA docs guys I wanna see it from the horses mouth lol
1 Like
calisro
(Rob)
February 10, 2022, 3:57pm
159
The issue isn’t the capability on the Google Side. It is about the certificates being used for hte mDNs. When the device comunicates with HA on HTTPS, the certificates would not match the domain name and it would terminate its response. I’ll find the PR related to that.
1 Like
Nardol
(Patrick ZAJDA)
February 10, 2022, 3:58pm
160
Unfortunately this is not doable with Nabucasa.
To be able to use it we have to be connected using the google account which is the developer for the Google Assistant actions, if Using with Nabu Casa only Nabu Casa developers can use the inspect button for each device and debug.
ok this makes some sense, I assume NAT loopback on a router doesn’t make a difference here?
calisro
(Rob)
February 10, 2022, 4:14pm
162
No Unfortunately. Personally I want local HTTPS and wasn’t happy having to expose a non-HTTPS port internally and move to a proxy. The way it is written, it grabs the MDNS name and attempts connections from the home device to the MDNS name. In theory, you could have proper certs tied to the MDNS entries and then it would connect fine but the code would need to be rewritten to 1) allow it again (its specifically disabled now) and 2) to use a specific url as a config entry rather than use the baseUrl/external/internal to connect to and I’m sure other things.
1 Like
calisro
(Rob)
February 10, 2022, 4:24pm
163
This is more in line with what you were looking for.
home-assistant:dev
← Zarklord:google-assistant-ignore-ssl
opened 01:52AM - 22 Jan 22 UTC
<!--
You are amazing! Thanks for contributing to our project!
Please, DO N… OT DELETE ANY TEXT from this template! (unless instructed).
-->
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
or resolves a feature request, be sure to link to that issue in the
additional information section.
-->
SSL is only used for the external host address, local fulfillment should always use `http`, since `mDNS` is going to return `http://homeassistant.local:port`, and if you had external ssl this would cause google home to try (and fail) to use `https://homeassistant.local:port`, this removes the `httpSSL` property from `customData` passed in the SYNC intent, which will properly result in `http` always being used.
## Type of change
<!--
What type of change does your PR introduce to Home Assistant?
NOTE: Please, check only 1! box!
If your PR requires multiple boxes to be checked, you'll most likely need to
split it into multiple PRs. This makes things easier and faster to code review.
-->
- [ ] Dependency upgrade
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [ ] New feature (which adds functionality to an existing integration)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
## Additional information
<!--
Details are important, and help maintainers processing your PR.
Please be sure to fill out additional details, if applicable.
-->
- This PR fixes or closes issue: fixes #
- This PR is related to issue:
- Link to documentation pull request:
## Checklist
<!--
Put an `x` in the boxes that apply. You can also fill these out after
creating the PR. If you're unsure about any of them, don't hesitate to ask.
We're here to help! This is simply a reminder of what we are going to look
for before merging your code.
-->
- [x] The code change is tested and works locally.
- [x] Local tests pass. **Your PR cannot be merged unless tests pass**
- [x] There is no commented out code in this PR.
- [x] I have followed the [development checklist][dev-checklist]
- [x] The code has been formatted using Black (`black --fast homeassistant tests`)
- [ ] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated for [www.home-assistant.io][docs-repository]
If the code communicates with devices, web services, or third-party tools:
- [ ] The [manifest file][manifest-docs] has all fields filled out correctly.
Updated and included derived files by running: `python3 -m script.hassfest`.
- [ ] New or updated dependencies have been added to `requirements_all.txt`.
Updated by running `python3 -m script.gen_requirements_all`.
- [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
- [ ] Untested files have been added to `.coveragerc`.
The integration reached or maintains the following [Integration Quality Scale][quality-scale]:
<!--
The Integration Quality Scale scores an integration on the code quality
and user experience. Each level of the quality scale consists of a list
of requirements. We highly recommend getting your integration scored!
-->
- [ ] No score or internal
- [ ] 🥈 Silver
- [ ] 🥇 Gold
- [ ] 🏆 Platinum
<!--
This project is very active and we have a high turnover of pull requests.
Unfortunately, the number of incoming pull requests is higher than what our
reviewers can review and merge so there is a long backlog of pull requests
waiting for review. You can help here!
By reviewing another pull request, you will help raise the code quality of
that pull request and the final review will be faster. This way the general
pace of pull request reviews will go up and your wait time will go down.
When picking a pull request to review, try to choose one that hasn't yet
been reviewed.
Thanks for helping out!
-->
To help with the load of incoming pull requests:
- [ ] I have reviewed two other [open pull requests][prs] in this repository.
[prs]: https://github.com/home-assistant/core/pulls?q=is%3Aopen+is%3Apr+-author%3A%40me+-draft%3Atrue+-label%3Awaiting-for-upstream+sort%3Acreated-desc+review%3Anone+-status%3Afailure
<!--
Thank you for contributing <3
Below, some useful links you could explore:
-->
[dev-checklist]: https://developers.home-assistant.io/docs/en/development_checklist.html
[manifest-docs]: https://developers.home-assistant.io/docs/en/creating_integration_manifest.html
[quality-scale]: https://developers.home-assistant.io/docs/en/next/integration_quality_scale_index.html
[docs-repository]: https://github.com/home-assistant/home-assistant.io
1 Like
That was indeed a heavy discussion
1 Like
calisro
(Rob)
February 10, 2022, 4:32pm
165
Yes and he’s not incorrect (both aren’t incorrect). In the current code and the way mDNS is derived, it can’t function. I really hope at some point enhancements are made to this to allow it to function securely. There should never be a reason to disable security. But its a pretty complicated fix.
3 Likes