pcmihnea
October 24, 2022, 10:09am
42
Water measurement would be a nice addition.
Hedda
October 24, 2022, 5:28pm
43
FYI, looks like emontnemery and epenet are working on some underlying implementations needed for adding “water” as a new device class which will be needed for water consumption measurements under the existing energy integration in a unified way:
home-assistant:dev ← home-assistant:energy_water_usage
opened 01:18PM - 24 Oct 22 UTC
<!--
You are amazing! Thanks for contributing to our project!
Please, DO N… OT DELETE ANY TEXT from this template! (unless instructed).
-->
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
or resolves a feature request, be sure to link to that issue in the
additional information section.
-->
Add support to the energy integration for tracking water usage:
- Cost sensors support tracking costs incurred from using water
- Validate the water settings
This is in preparation for frontend support for tracking water usage
If <https://github.com/home-assistant/core/pull/80886> is accepted, this PR should be updated accordingly
WTH: https://community.home-assistant.io/t/wth-do-we-have-energy-dashboard-and-no-water-dashboard/467168
TODO:
- Frontend support
- Tests
## Type of change
<!--
What type of change does your PR introduce to Home Assistant?
NOTE: Please, check only 1! box!
If your PR requires multiple boxes to be checked, you'll most likely need to
split it into multiple PRs. This makes things easier and faster to code review.
-->
- [ ] Dependency upgrade
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [ ] New feature (which adds functionality to an existing integration)
- [ ] Deprecation (breaking change to happen in the future)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
## Additional information
<!--
Details are important, and help maintainers processing your PR.
Please be sure to fill out additional details, if applicable.
-->
- This PR fixes or closes issue: fixes #
- This PR is related to issue:
- Link to documentation pull request:
## Checklist
<!--
Put an `x` in the boxes that apply. You can also fill these out after
creating the PR. If you're unsure about any of them, don't hesitate to ask.
We're here to help! This is simply a reminder of what we are going to look
for before merging your code.
-->
- [ ] The code change is tested and works locally.
- [ ] Local tests pass. **Your PR cannot be merged unless tests pass**
- [ ] There is no commented out code in this PR.
- [ ] I have followed the [development checklist][dev-checklist]
- [ ] The code has been formatted using Black (`black --fast homeassistant tests`)
- [ ] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated for [www.home-assistant.io][docs-repository]
If the code communicates with devices, web services, or third-party tools:
- [ ] The [manifest file][manifest-docs] has all fields filled out correctly.
Updated and included derived files by running: `python3 -m script.hassfest`.
- [ ] New or updated dependencies have been added to `requirements_all.txt`.
Updated by running `python3 -m script.gen_requirements_all`.
- [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
- [ ] Untested files have been added to `.coveragerc`.
<!--
This project is very active and we have a high turnover of pull requests.
Unfortunately, the number of incoming pull requests is higher than what our
reviewers can review and merge so there is a long backlog of pull requests
waiting for review. You can help here!
By reviewing another pull request, you will help raise the code quality of
that pull request and the final review will be faster. This way the general
pace of pull request reviews will go up and your wait time will go down.
When picking a pull request to review, try to choose one that hasn't yet
been reviewed.
Thanks for helping out!
-->
To help with the load of incoming pull requests:
- [ ] I have reviewed two other [open pull requests][prs] in this repository.
[prs]: https://github.com/home-assistant/core/pulls?q=is%3Aopen+is%3Apr+-author%3A%40me+-draft%3Atrue+-label%3Awaiting-for-upstream+sort%3Acreated-desc+review%3Anone+-status%3Afailure
<!--
Thank you for contributing <3
Below, some useful links you could explore:
-->
[dev-checklist]: https://developers.home-assistant.io/docs/en/development_checklist.html
[manifest-docs]: https://developers.home-assistant.io/docs/en/creating_integration_manifest.html
[quality-scale]: https://developers.home-assistant.io/docs/en/next/integration_quality_scale_index.html
[docs-repository]: https://github.com/home-assistant/home-assistant.io
home-assistant:dev ← epenet:water-device-class
opened 01:13PM - 24 Oct 22 UTC
## Proposed change
<!--
Describe the big picture of your changes here to com… municate to the
maintainers why we should accept this pull request. If it fixes a bug
or resolves a feature request, be sure to link to that issue in the
additional information section.
-->
Add new WATER device class:
- [x] Frontend: https://github.com/home-assistant/frontend/pull/14174
- [x] Dev docs: https://github.com/home-assistant/developers.home-assistant/pull/1509
- [x] Docs: https://github.com/home-assistant/home-assistant.io/pull/24678
## Type of change
<!--
What type of change does your PR introduce to Home Assistant?
NOTE: Please, check only 1! box!
If your PR requires multiple boxes to be checked, you'll most likely need to
split it into multiple PRs. This makes things easier and faster to code review.
-->
- [ ] Dependency upgrade
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [x] New feature (which adds functionality to an existing integration)
- [ ] Deprecation (breaking change to happen in the future)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
## Additional information
<!--
Details are important, and help maintainers processing your PR.
Please be sure to fill out additional details, if applicable.
-->
- This PR fixes or closes issue: fixes #
- This PR is related to issue:
- Link to documentation pull request:
## Checklist
<!--
Put an `x` in the boxes that apply. You can also fill these out after
creating the PR. If you're unsure about any of them, don't hesitate to ask.
We're here to help! This is simply a reminder of what we are going to look
for before merging your code.
-->
- [ ] The code change is tested and works locally.
- [ ] Local tests pass. **Your PR cannot be merged unless tests pass**
- [ ] There is no commented out code in this PR.
- [ ] I have followed the [development checklist][dev-checklist]
- [ ] The code has been formatted using Black (`black --fast homeassistant tests`)
- [ ] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated for [www.home-assistant.io][docs-repository]
If the code communicates with devices, web services, or third-party tools:
- [ ] The [manifest file][manifest-docs] has all fields filled out correctly.
Updated and included derived files by running: `python3 -m script.hassfest`.
- [ ] New or updated dependencies have been added to `requirements_all.txt`.
Updated by running `python3 -m script.gen_requirements_all`.
- [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
- [ ] Untested files have been added to `.coveragerc`.
<!--
This project is very active and we have a high turnover of pull requests.
Unfortunately, the number of incoming pull requests is higher than what our
reviewers can review and merge so there is a long backlog of pull requests
waiting for review. You can help here!
By reviewing another pull request, you will help raise the code quality of
that pull request and the final review will be faster. This way the general
pace of pull request reviews will go up and your wait time will go down.
When picking a pull request to review, try to choose one that hasn't yet
been reviewed.
Thanks for helping out!
-->
To help with the load of incoming pull requests:
- [ ] I have reviewed two other [open pull requests][prs] in this repository.
[prs]: https://github.com/home-assistant/core/pulls?q=is%3Aopen+is%3Apr+-author%3A%40me+-draft%3Atrue+-label%3Awaiting-for-upstream+sort%3Acreated-desc+review%3Anone+-status%3Afailure
<!--
Thank you for contributing <3
Below, some useful links you could explore:
-->
[dev-checklist]: https://developers.home-assistant.io/docs/en/development_checklist.html
[manifest-docs]: https://developers.home-assistant.io/docs/en/creating_integration_manifest.html
[quality-scale]: https://developers.home-assistant.io/docs/en/next/integration_quality_scale_index.html
[docs-repository]: https://github.com/home-assistant/home-assistant.io
opened 01:08PM - 30 Dec 21 UTC
## Context
With [Energy](https://www.home-assistant.io/docs/energy) managemen… t being a huge success and [gas](https://www.home-assistant.io/docs/energy/gas/) consumption already available a missing puzzle piece is water.
## Proposal
Make water available as [device class](https://developers.home-assistant.io/docs/core/entity/sensor/) and therefore usable within sensors.
Maybe instead of implementing _water_ it is an option to implement _fluid_ as this would cover others like _oil_ as well. Interestingly, with multiple sorts of carbon_ / nitrogen_ available maybe it should be rather fluid_water and fluid_oil.
Water or fluids should be supported similarly as Gas in regard to Energy Management, e.g. on Frontend (Water consumptuon graph) see [Lovelace Energy](https://www.home-assistant.io/lovelace/energy/).
## Consequences
Water or fluids are most likely very similar to gas, as they are measured in m³/ ft³. It needs a decision if every fluid should be implemented individually or similar like gas in a more generic way covering all gas types.
As one m³ reflects 1,000 liters there could be use-cases where people would rather user liters instead of m³. One could argue having liters is another way of implementing fluids. Obviously this might cause complexity about m³ vs. ft³. I'm actually not sure if ft³ are stored in m³ or ft³ (... _Volume of gas, statistics will be stored in m³._ ..., see [sensor](https://developers.home-assistant.io/docs/core/entity/sensor/)).
## The alternative
Using device class gas is an alternative as it is also measured in m³. While it works, it is technically not correct.
## Additional note
* [Existing Feature Request](https://community.home-assistant.io/t/energy-water-usage/335483/21 )
* [Example for water metering](https://community.home-assistant.io/t/water-metering-using-sensus-hri-libmbus-mqtt-and-utility-meter-integration/373010)
* [Sensor Entity reference](https://developers.home-assistant.io/docs/core/entity/sensor/)
1 Like
CChris
October 29, 2022, 7:05am
44
water will be integrated into the next release
1 Like
a seperate section for individual devices incl costs would be nice. Misusing “GAS” section for individual power and costs…
Thanks for adding water in 2022.11, works as expected.
HerrieMan
November 4, 2022, 6:51am
47
Yes, totally agree, addition of water-meter to the energy tab really looks good and a big thanks for making this update!
typxxi
May 22, 2023, 10:28am
48
BUT: still the additional energy dashboards are missing that are needed for homes with multiple solar power installations for example
The feature request for that is from January 2022 and still missing even though it also has 130 votes and is obviously a missing feature.
1 Like
+1 for the initial request to consider renaming the energy dashboard to ‘utilities’. Really love seeing this evolve.
Another suggestion would be to consider renaming ‘gas consumption’ to ‘heat consumption’ and allow for other usage like city heating (GJ)
2 Likes
