Wink PubNub v4 seems to have broken something

Development
1

When I push a button on my Lutron Switch (called “Bedroom Remote”), I see the following appear in the log, and from there on Wink integration is broken.

I haven’t seen this with earlier HA installations – it must have regressed somehow.

Any ideas what a fix can be?

Jan 03 22:11:06 DietPi hass.sh[3294]: ERROR:homeassistant.components.wink:Error in pubnub JSON for Bedroom Remote hub polling API for current state
Jan 03 22:11:07 DietPi hass.sh[3294]: ERROR:pubnub:take message interrupted: 'NoneType' object has no attribute 'loop'
Jan 03 22:22:54 DietPi hass.sh[3294]: Exception in thread SubscribeMessageWorker:
Jan 03 22:22:54 DietPi hass.sh[3294]: Traceback (most recent call last):
Jan 03 22:22:54 DietPi hass.sh[3294]: File "/srv/hass/lib/python3.4/site-packages/homeassistant/components/wink.py", line 128, in _pubnub_update
Jan 03 22:22:54 DietPi hass.sh[3294]: self.update_ha_state()
Jan 03 22:22:54 DietPi hass.sh[3294]: File "/srv/hass/lib/python3.4/site-packages/homeassistant/helpers/entity.py", line 192, in update_ha_state
Jan 03 22:22:54 DietPi hass.sh[3294]: ).result()
Jan 03 22:22:54 DietPi hass.sh[3294]: AttributeError: 'NoneType' object has no attribute 'loop'
Jan 03 22:22:54 DietPi hass.sh[3294]: During handling of the above exception, another exception occurred:
Jan 03 22:22:54 DietPi hass.sh[3294]: Traceback (most recent call last):
Jan 03 22:22:54 DietPi hass.sh[3294]: File "/usr/lib/python3.4/threading.py", line 920, in _bootstrap_inner
Jan 03 22:22:54 DietPi hass.sh[3294]: self.run()
Jan 03 22:22:54 DietPi hass.sh[3294]: File "/usr/lib/python3.4/threading.py", line 868, in run
Jan 03 22:22:54 DietPi hass.sh[3294]: self._target(*self._args, **self._kwargs)
Jan 03 22:22:54 DietPi hass.sh[3294]: File "/home/hass/.homeassistant/deps/pubnub/workers.py", line 25, in run
Jan 03 22:22:54 DietPi hass.sh[3294]: self._take_message()
Jan 03 22:22:54 DietPi hass.sh[3294]: File "/home/hass/.homeassistant/deps/pubnub/pubnub.py", line 259, in _take_message
Jan 03 22:22:54 DietPi hass.sh[3294]: self._process_incoming_payload(msg)
Jan 03 22:22:54 DietPi hass.sh[3294]: File "/home/hass/.homeassistant/deps/pubnub/workers.py", line 85, in _process_incoming_payload
Jan 03 22:22:54 DietPi hass.sh[3294]: self._listener_manager.announce_message(pn_message_result)
Jan 03 22:22:54 DietPi hass.sh[3294]: File "/home/hass/.homeassistant/deps/pubnub/managers.py", line 157, in announce_message
Jan 03 22:22:54 DietPi hass.sh[3294]: callback.message(self._pubnub, message)
Jan 03 22:22:54 DietPi hass.sh[3294]: File "/home/hass/.homeassistant/deps/pubnubsubhandler.py", line 182, in message
Jan 03 22:22:54 DietPi hass.sh[3294]: func(json.loads(json_data))
Jan 03 22:22:54 DietPi hass.sh[3294]: File "/srv/hass/lib/python3.4/site-packages/homeassistant/components/wink.py", line 132, in _pubnub_update
Jan 03 22:22:54 DietPi hass.sh[3294]: self.update_ha_state(True)
Jan 03 22:22:54 DietPi hass.sh[3294]: File "/srv/hass/lib/python3.4/site-packages/homeassistant/helpers/entity.py", line 192, in update_ha_state
Jan 03 22:22:54 DietPi hass.sh[3294]: ).result()
Jan 03 22:22:54 DietPi hass.sh[3294]: AttributeError: 'NoneType' object has no attribute 'loop'
Jan 03 22:22:54 DietPi hass.sh[3294]: ERROR:homeassistant.components.updater:Got unexpected response: None
2

Starting to suspect this commit. It started to happen since I updated HA recently. This is a pretty major update.

3

Worked around it for now with an ugly hack, however I do not understand why “None” is being passed into pubnub_update. That’s the actual bug. Placed a catch-all around self.update_ha_state(True).

def _pubnub_update(self, message):
    try:
        if message is None:
            _LOGGER.error("Error on pubnub update for %s "
                          "polling API for current state", self.name)
            self.update_ha_state(True)
        else:
            self.wink.pubnub_update(message)
            self.update_ha_state()
    except (ValueError, KeyError, AttributeError):
        _LOGGER.error("Error in pubnub JSON for %s "
                      "polling API for current state", self.name)
        try:
           self.update_ha_state(True)
        except:
           _LOGGER.error("self.update_ha_state(True) failed")