2021.6: A little bit of everything

Skye · June 6, 2022, 7:19am

I digress.

koying · June 6, 2022, 8:34am

You know what it is with the US and international standards, right?
It’s only been 35 years that ISO decided that Monday is the first day of week, and it’s only been 6 months that I opened an issue for this

github.com/home-assistant/frontend

DateTime picker first day of week should follow locale

opened 09:29AM - 19 Dec 21 UTC

koying

Bug

### Checklist - [X] I have updated to the latest available Home Assistant versi…on. - [X] I have cleared the cache of my browser. - [X] I have tried a different browser to see if it is related to my browser. ### Describe the issue you are experiencing The datetime picker has Sunday as the first day of week ### Describe the behavior you expected The datetime picker should follow my locale or, if not possible, fallback to ISO 8601 value of Monday ### Steps to reproduce the issue 1. Set my language to French 2. Go to logbook and open datetime picker 3. See that first day of week is Sunday ... ### What version of Home Assistant Core has the issue? 2021.12.3 ### What was the last working version of Home Assistant Core? _No response_ ### In which browser are you experiencing the issue with? _No response_ ### Which operating system are you using to run this browser? _No response_ ### State of relevant entities _No response_ ### Problem-relevant frontend configuration _No response_ ### Javascript errors shown in your browser console/inspector _No response_ ### Additional information _No response_

nickrout · June 6, 2022, 10:41am

Calendars traditionally show Sunday as the first day of the week. As far as I am concerned that is correct.

BebeMischa · June 6, 2022, 10:44am

Not in the most of Europe

petro · June 6, 2022, 10:53am

Well, it’s not an issue it’s a #feature-requests.

vue2-daterange-picker built into ha is not using locale-data.

github.com

home-assistant/frontend/blob/91cd584b4b5dd57392f42aac7ee2fe9b5b7255c7/src/components/date-range-picker.ts#L40

    
      
            endDate: {
              type: [String, Date],
              default() {
                return new Date();
              },
            },
          },
          render(createElement) {
            // @ts-ignore
            return createElement(DateRangePicker, {
              props: {
                "time-picker": true,
                "auto-apply": false,
                opens: "right",
                "show-dropdowns": false,
                // @ts-ignore
                "time-picker24-hour": this.twentyfourHours,
                // @ts-ignore
                disabled: this.disabled,
                // @ts-ignore
                ranges: this.ranges ? {} : false,

https://innologica.github.io/vue2-daterange-picker/#props

A system would need to be put in place for it to be used.

Skye · June 6, 2022, 11:12am

In the US maybe, but for all of Europe, not so much

koying · June 6, 2022, 11:23am

Maybe in the Anglo-saxon world at large, then but ISO 8601 univocally set the first day of week to Monday.

koying · June 6, 2022, 11:29am

OK.

Now, whether asking for this datetime picker to follow the locale like everywhere else is a bug report of a feature request…

And, once again, the fallback if locale is not implemented should be ISO rather than the anglo-saxon way

petro · June 6, 2022, 11:30am

Then you should take taht up with the creators of vue2-daterange-picker as they set the default for that resource

Just so we are clear here: We don’t use locale at all in that element. It’s using the defaults for that package, which is not managed by HA. Everything about this is a Feature Requests, even changing the default because it would require HA to use locale-data. You know enough about this to know this without being a sarcastic.

koying · June 6, 2022, 11:40am

Not quite fair point. The 24h is overridden.

It’s a one-liner in HA to follow the international convention:

    props: {
      "time-picker": true,
      "locale-data": "{ firstDay: 1}",

or similar…

petro · June 6, 2022, 11:42am

That’s still not a bug. It’s a #feature-requests. And I can guarantee you they wouldn’t change the defaults without implementing a whole locale based system because we’d just be in the same situation but in reverse.

tom_l · June 6, 2022, 11:48am

Not on this side of the pond.

koying · June 6, 2022, 11:48am

No. I’ll stop trolling, but standard in Monday, not Sunday. Punt.
Is it a coincidence that the 24h setting is locale-based while it’s default is 24H, not AM/PM? Allow me to wonder

petro · June 6, 2022, 11:55am

What does that have to do with anything? I thought you weren’t trolling anymore?

koying · June 6, 2022, 11:58am

It’s a reference to your “feature request” vs. “bug” argument

petro · June 6, 2022, 12:09pm

There is no argument here. I’m simply telling you why action hasn’t been taken. A system would need to be built to handle locale. It would need a UI override option and a property to hold the data based on the default, locale, or user override. It falls into #feature-requests.

tom_l · June 6, 2022, 12:13pm

Don’t we have that already for units?

petro · June 6, 2022, 12:17pm

Yes, but it’s specific to Time Format. It could be tied to that, but again… it’s a #feature-requests. The Time Format has never been intended to change the first day of the week.

petro · June 6, 2022, 12:20pm

I’d expect a separate profile item Date Format that would change the date & the number of the week. However I’m not 100% sure if there are locales that use sunday as the first, iso date, and 12 hr time format. If that’s a possibility, you’d need another user profile item for first day of the week.

tom_l · June 6, 2022, 12:29pm

Personal preference probably comes into it too. I just had a look at Google Calendar, it offers Saturday, Sunday and Monday as options to start the week. A select with those options (so not tied to locale) would probably suit everyone.