About PR and resolving conversation

Development
1

Hello !

I would like to confirm one thing. In a pull request, who is in charge of clicking on “Resolve conversation”, I believe that the reviewer should but I just want to confirm ?

Thanks

2

Either the creator of the PullRequest or anyone with write access to the specific repository can resolve the conversation. As I know it, if you can push that button, you’re allowed to. :laughing:

Normally the “resolve conversation” is the last step in approving the suggested change, so whoever pushes that button, he/she should be sure, that it’s ok! :slight_smile:

If you post a link to the PR you’re reffering to, we can take a look at it. :slight_smile:

1 Like
3

@paddy0174
Thanks for answer, sorry I missed it yesterday.:sweat_smile:

As it is my first pull request on this project, I am not sure about anything.:grinning_face_with_smiling_eyes:

Sure, here is the pull request: Add switchbot cloud integration by SeraphicRav · Pull Request #99607 · home-assistant/core · GitHub

1 Like
4

You’re doing great! :slight_smile: For what I can see, your PR is getting close to be accepted and merged! :+1:

:+1: Thanks for your contribution! :slight_smile:

1 Like
5

Thanks! It is a pleasure!

1 Like