Hey guys. Im not a dev but I actively read PR’s and Issues relating to things I use within my brewery and HA
Currently I use the modbus integration to control VFD’s and PLC’s that run pumps around the brewery.
Under the modbus integration there is a option for scan_interval: however it flags a warning in the logs:
scan_interval(1) is lower than 5 seconds, which may cause Home Assistant stability issues
I understand that this is JUST A WARNING
home-assistant:dev
← janiversen:Xmerge_issue_51404
opened 10:12AM - 04 Jun 21 UTC
<!--
You are amazing! Thanks for contributing to our project!
Please, DO N… OT DELETE ANY TEXT from this template! (unless instructed).
-->
## Breaking change
Allow user defined scan_interval without limit.
<!--
If your PR contains a breaking change for existing users, it is important
to tell them what breaks, how to make it work again and why we did this.
This piece of text is published with the release notes, so it helps if you
write it towards our users, not us.
Note: Remove this section if this PR is NOT a breaking change.
-->
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
or resolves a feature request, be sure to link to that issue in the
additional information section.
-->
Before 2021.6 scan_interval was freely defined. With 2021.6 the HA standard was enforced, for different reasons. This PR brings the flexibility back.
Having an unlimited scan_interval in versions before 2021.6 have never been recorded as a problem (at least in issues), so there are no reason to assume it would be a bigger problem now.
Earlier the integration (especially update()) was sync. Meaning the switch to async was done inside CORE. This changed in 2021.6 where the integration became fully async, but for a while the API calls remain sync (we wait for an upcoming pymodbus release), this means that the switch between sync and async are now in the integrations, and thus was pointed out in an earlier review.
I have a test/production setup on a raspberry pi 3b, with around 2.000 datapoints (from 3 integrations). The datapoints in modbus are
- not polled (switches)
- Polled with 10 seconds (around 100, all general datapoint)
- Polled with 1 seconds (around 50, used for graph)
- Polled with 100ms (exactly 4, Kw for import/export and solar production), these go into an automation (calculation).
The system is very responsive on the UI. I believe this to be a (limited) proof, than scan_interval < 5 seconds is not a problem per se.
## Type of change
<!--
What type of change does your PR introduce to Home Assistant?
NOTE: Please, check only 1! box!
If your PR requires multiple boxes to be checked, you'll most likely need to
split it into multiple PRs. This makes things easier and faster to code review.
-->
- [ ] Dependency upgrade
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [ ] New feature (which adds functionality to an existing integration)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
## Additional information
<!--
Details are important, and help maintainers processing your PR.
Please be sure to fill out additional details, if applicable.
-->
Please add this to the first posible point release. I suggest that #51121 is also added.
- This PR fixes or closes issue: fixes #
Fixes #51404
- This PR is related to issue:
- Link to documentation pull request:
## Checklist
<!--
Put an `x` in the boxes that apply. You can also fill these out after
creating the PR. If you're unsure about any of them, don't hesitate to ask.
We're here to help! This is simply a reminder of what we are going to look
for before merging your code.
-->
- [x] The code change is tested and works locally.
- [x] Local tests pass. **Your PR cannot be merged unless tests pass**
- [x] There is no commented out code in this PR.
- [x] I have followed the [development checklist][dev-checklist]
- [x] The code has been formatted using Black (`black --fast homeassistant tests`)
- [ ] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated for [www.home-assistant.io][docs-repository]
If the code communicates with devices, web services, or third-party tools:
- [ ] The [manifest file][manifest-docs] has all fields filled out correctly.
Updated and included derived files by running: `python3 -m script.hassfest`.
- [ ] New or updated dependencies have been added to `requirements_all.txt`.
Updated by running `python3 -m script.gen_requirements_all`.
- [ ] Untested files have been added to `.coveragerc`.
The integration reached or maintains the following [Integration Quality Scale][quality-scale]:
<!--
The Integration Quality Scale scores an integration on the code quality
and user experience. Each level of the quality scale consists of a list
of requirements. We highly recommend getting your integration scored!
-->
- [x] No score or internal
- [ ] 🥈 Silver
- [ ] 🥇 Gold
- [ ] 🏆 Platinum
<!--
This project is very active and we have a high turnover of pull requests.
Unfortunately, the number of incoming pull requests is higher than what our
reviewers can review and merge so there is a long backlog of pull requests
waiting for review. You can help here!
By reviewing another pull request, you will help raise the code quality of
that pull request and the final review will be faster. This way the general
pace of pull request reviews will go up and your wait time will go down.
When picking a pull request to review, try to choose one that hasn't yet
been reviewed.
Thanks for helping out!
-->
To help with the load of incoming pull requests:
- [ ] I have reviewed two other [open pull requests][prs] in this repository.
[prs]: https://github.com/home-assistant/core/pulls?q=is%3Aopen+is%3Apr+-author%3A%40me+-draft%3Atrue+-label%3Awaiting-for-upstream+sort%3Acreated-desc+review%3Anone
<!--
Thank you for contributing <3
Below, some useful links you could explore:
-->
[dev-checklist]: https://developers.home-assistant.io/docs/en/development_checklist.html
[manifest-docs]: https://developers.home-assistant.io/docs/en/creating_integration_manifest.html
[quality-scale]: https://developers.home-assistant.io/docs/en/next/integration_quality_scale_index.html
[docs-repository]: https://github.com/home-assistant/home-assistant.io
home-assistant:master
← home-assistant:rc
opened 05:07PM - 04 Jun 21 UTC
- Hot fix version of Apply modbus interval patch ([@balloob] - [#51487]) ([modbu… s docs])
- Update to iaqualink 0.3.90 ([@flz] - [#51452]) ([iaqualink docs])
- Retry isy994 setup later if isy.initialize times out ([@bdraco] - [#51453]) ([isy994 docs])
- xknx 0.18.3 ([@farmio] - [#51277]) ([knx docs])
- Update xknx to version 0.18.4 ([@farmio] - [#51459]) ([knx docs])
- Bump aiolyric to 1.0.7 ([@timmo001] - [#51473]) ([lyric docs])
- Improve logging for SamsungTV ([@chemelli74] - [#51477]) ([samsungtv docs])
- Upgrade elgato to 2.1.1 ([@frenck] - [#51483]) ([elgato docs])
- Protect our user agent ([@balloob] - [#51486])
[#51277]: https://github.com/home-assistant/core/pull/51277
[#51452]: https://github.com/home-assistant/core/pull/51452
[#51453]: https://github.com/home-assistant/core/pull/51453
[#51459]: https://github.com/home-assistant/core/pull/51459
[#51473]: https://github.com/home-assistant/core/pull/51473
[#51477]: https://github.com/home-assistant/core/pull/51477
[#51483]: https://github.com/home-assistant/core/pull/51483
[#51486]: https://github.com/home-assistant/core/pull/51486
[#51487]: https://github.com/home-assistant/core/pull/51487
[@balloob]: https://github.com/balloob
[@bdraco]: https://github.com/bdraco
[@chemelli74]: https://github.com/chemelli74
[@farmio]: https://github.com/farmio
[@flz]: https://github.com/flz
[@frenck]: https://github.com/frenck
[@timmo001]: https://github.com/timmo001
[elgato docs]: https://www.home-assistant.io/integrations/elgato/
[iaqualink docs]: https://www.home-assistant.io/integrations/iaqualink/
[isy994 docs]: https://www.home-assistant.io/integrations/isy994/
[knx docs]: https://www.home-assistant.io/integrations/knx/
[lyric docs]: https://www.home-assistant.io/integrations/lyric/
[modbus docs]: https://www.home-assistant.io/integrations/modbus/
[samsungtv docs]: https://www.home-assistant.io/integrations/samsungtv/
What is the ACTUAL limitation that makes the devs set a limit on that 5 seconds??? Is it set because of the broad spectrum of hardware limitations that HA runs on e.g:CPU horsepower/USB/Network hardware or is HA throttling on purpose???
I run HaOS on a Dell Optiplex 7000 (12 core 4.7ghz) so I have no shortage of horsepower so I want to know if Id be better off moving all my ModBus VFD’s from the native integration to MQTT (which Id rather not as its not so easy on the VFD side) as MQTT has no such limitations.
Thanks for any commentary