Adding attribute to nadtcp - not getting it to work

phithor · April 9, 2018, 3:09pm

Hi,

I have a NAD Amplifier and it works pretty good with Home Assistant. One issue I have is that I have is that it is not intuitive which volume level it is set at. It currently displays it volume(in dev-state in the gui from 0…1 in the HA format. I would like to see the same dB level i see at the display.

I have only used python for small personal projects before, almost no classes, but I tried to copy how other attributes where defined in the code. Could any of you help me with why it’s not working?

current ha code here:
https://github.com/home-assistant/home-assistant/blob/master/homeassistant/components/media_player/nadtcp.py

My modified code here:

github.com

phithor/home-assistant/blob/dev/homeassistant/components/media_player/nadtcp.py

"""
Support for NAD digital amplifiers which can be remote controlled via tcp/ip.

For more details about this platform, please refer to the documentation at
https://home-assistant.io/components/media_player.nadtcp/
"""
import logging

import voluptuous as vol

from homeassistant.components.media_player import (
    PLATFORM_SCHEMA, SUPPORT_SELECT_SOURCE, SUPPORT_TURN_OFF, SUPPORT_TURN_ON,
    SUPPORT_VOLUME_MUTE, SUPPORT_VOLUME_SET, SUPPORT_VOLUME_STEP,
    MediaPlayerDevice)
from homeassistant.const import CONF_HOST, CONF_NAME, STATE_OFF, STATE_ON
import homeassistant.helpers.config_validation as cv

REQUIREMENTS = ['nad_receiver==0.0.9']

_LOGGER = logging.getLogger(__name__)

This file has been truncated. show original

I added a new class variable, new function to calculate the value and added the attribute with the @property tag in the bottom but it does not sho up in dev-state attribute. Is there something else I should do?

fabaff · April 12, 2018, 8:22pm

The current solution would require that you update the frontend to expose the value.

Use device_state_attributes to show details about a device in the frontend.