(Bug?) Missing notifications with same ID in Active Notification Count sensor

auto4food · April 28, 2024, 2:50am

Usually Uber Eats Android app has 3 notifications in order: Preparing → Ready → Rate.

It looks like Uber Eats app tries to reuse the same notification ID but the previous notifications are still there.
As the result, the attribute list in sensor.my_phone_active_notification_count can only see the oldest notification.

For the Uber Eats case, only Preparing order notification can be found in HA.
When I dismiss Preparing order notification, I can see Order is ready notification.
When I dismiss Order is ready notification, I can see Rate the experience notification.

Is it a known issue for HA Companion app in Android?
In my opinion, HA should add all 3 notifications to Active Notification Count sensor or at least select the latest notifications with the same ID.
Thanks!

ShadowFist · April 28, 2024, 8:56am

Can’t help, but this thread seems to be related Last Notification sensor w/ consecutive notifications on Android

Maybe have a read through that and see if it solves, or at least explains, your issue?

auto4food · April 28, 2024, 12:19pm

Thanks for the reply.
Looks like that thread is about Last Notification sensor but I have been using Active Notification Count sensor.

dshokouhi · April 28, 2024, 6:21pm

The app is not reusing the same notification ID. It is using whatever notification ID was given to the app in the list of notifications.

github.com

home-assistant/android/blob/d733b405cc00bdec5e0e092d1f3badb6f409f0c3/app/src/main/java/io/homeassistant/companion/android/sensors/NotificationSensorManager.kt#L240


      
          }
          
          private fun updateActiveNotificationCount() {
              if (!isEnabled(applicationContext, activeNotificationCount) || !listenerConnected) {
                  return
              }
          
              try {
                  val attr: MutableMap<String, Any?> = mutableMapOf()
                  for (item in activeNotifications) {
                      attr += mappedBundle(item.notification.extras, "_${item.packageName}_${item.id}").orEmpty()
                          .plus("${item.packageName}_${item.id}_post_time" to item.postTime)
                          .plus("${item.packageName}_${item.id}_is_ongoing" to item.isOngoing)
                          .plus("${item.packageName}_${item.id}_is_clearable" to item.isClearable)
                          .plus("${item.packageName}_${item.id}_group_id" to item.notification.group)
                          .plus("${item.packageName}_${item.id}_category" to item.notification.category)
          
                      if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
                          attr["${item.packageName}_${item.id}_channel_id"] = item.notification.channelId
                      }
                  }

auto4food · April 28, 2024, 11:53pm

“The app” means the “Uber Eats” app.
Sorry for the confusion and edited the original post.

I don’t understand Kotlin much.
I feel like post_time should be included to the key or check whether greater than existing post_time before inserting.

If multiple pairs have the same key, the resulting map will contain the value from the last of those pairs.

dshokouhi · April 29, 2024, 12:06am

if the notification has the same ID then you will only see 1 notification as it will be replaced. Active notifications are not considered canceled.

Post a notification to be shown in the status bar. If a notification with the same id has already been posted by your application and has not yet been canceled, it will be replaced by the updated information.

https://developer.android.com/reference/android/app/NotificationManager#notify(int,%20android.app.Notification)

https://developer.android.com/reference/android/service/notification/StatusBarNotification#getId()