IgorZg
(Igor Simić)
June 14, 2023, 2:46pm
1
Hi all,
something is wrong about command line sensors.
Short story:
Service homeassistant.update_entity don’t work on command line sensors
Reload command line entities in YAML panel don’t work,
Long story:
I have bunch of command line sensors.
They are defined as follows:
in configuration.yaml I have line:
command_line: !include_dir_merge_list command_line
in directory command_line I have bunch of yaml files like this one, random.yaml:
$ cat random.yaml
- sensor:
name: random_value
unique_id: cmd_random_value
command: "random.sh"
scan_interval: 10800
command_timeout: 5
Sensors works ok, but service homeassistant.update_entity
service: homeassistant.update_entity
data: {}
target:
entity_id: sensor.os_updates_nr
does nothing.
Also if I change something in yaml, ie. change scan_interval, reload by clicking COMMAND LINE ENTITIES in YAML panel does nothing, no value changed.
Just to be clear here is content of random.sh, which change value when scan_interval elapse, but never when I try refresh it calling homeassistant.update_entity service:
homeassistant@hass:~$ cat $(which random.sh)
#!/bin/bash
echo $RANDOM
IgorZg:
update_entity
This?
opened 03:38PM - 08 Jun 23 UTC
closed 07:50PM - 12 Jun 23 UTC
integration: command_line
### The problem
Consider this sensor:
```
command_line:
- sensor:
… name: "test command line10"
command: "echo 123"
value_template: >-
{{ value }} - {{now()}}
scan_interval: 99999
```
It is not updated by calling the service.
Right after HA restart:
![image](https://github.com/home-assistant/core/assets/71872483/12230167-6f24-44ed-8887-1180b63baaa9)
After calling a service:
```
service: homeassistant.update_entity
data: {}
target:
entity_id: sensor.test_command_line10
```
![image](https://github.com/home-assistant/core/assets/71872483/02165568-755b-498e-bc34-cce9c3aa87ff)
i.e. a value is not changed.
### What version of Home Assistant Core has the issue?
2023.6.0
### What was the last working version of Home Assistant Core?
2023.5.x
### What type of installation are you running?
Home Assistant Container
### Integration causing the issue
command_line
### Link to integration documentation on our website
https://www.home-assistant.io/integrations/command_line/
### Diagnostics information
_No response_
### Example YAML snippet
_No response_
### Anything in the logs that might be useful for us?
_No response_
### Additional information
_No response_
Should be fixed via
home-assistant:dev
← home-assistant:cmd_line-manual-updating
opened 04:22PM - 11 Jun 23 UTC
<!--
You are amazing! Thanks for contributing to our project!
Please, DO N… OT DELETE ANY TEXT from this template! (unless instructed).
-->
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
or resolves a feature request, be sure to link to that issue in the
additional information section.
-->
Adds `async_update` so it's possible to update data from `homeassistant.update_entity` service call.
## Type of change
<!--
What type of change does your PR introduce to Home Assistant?
NOTE: Please, check only 1! box!
If your PR requires multiple boxes to be checked, you'll most likely need to
split it into multiple PRs. This makes things easier and faster to code review.
-->
- [ ] Dependency upgrade
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [ ] New feature (which adds functionality to an existing integration)
- [ ] Deprecation (breaking change to happen in the future)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
## Additional information
<!--
Details are important, and help maintainers processing your PR.
Please be sure to fill out additional details, if applicable.
-->
- This PR fixes or closes issue: fixes #94270
- This PR is related to issue:
- Link to documentation pull request:
## Checklist
<!--
Put an `x` in the boxes that apply. You can also fill these out after
creating the PR. If you're unsure about any of them, don't hesitate to ask.
We're here to help! This is simply a reminder of what we are going to look
for before merging your code.
-->
- [x] The code change is tested and works locally.
- [x] Local tests pass. **Your PR cannot be merged unless tests pass**
- [x] There is no commented out code in this PR.
- [x] I have followed the [development checklist][dev-checklist]
- [x] I have followed the [perfect PR recommendations][perfect-pr]
- [x] The code has been formatted using Black (`black --fast homeassistant tests`)
- [x] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated for [www.home-assistant.io][docs-repository]
If the code communicates with devices, web services, or third-party tools:
- [ ] The [manifest file][manifest-docs] has all fields filled out correctly.
Updated and included derived files by running: `python3 -m script.hassfest`.
- [ ] New or updated dependencies have been added to `requirements_all.txt`.
Updated by running `python3 -m script.gen_requirements_all`.
- [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
- [ ] Untested files have been added to `.coveragerc`.
<!--
This project is very active and we have a high turnover of pull requests.
Unfortunately, the number of incoming pull requests is higher than what our
reviewers can review and merge so there is a long backlog of pull requests
waiting for review. You can help here!
By reviewing another pull request, you will help raise the code quality of
that pull request and the final review will be faster. This way the general
pace of pull request reviews will go up and your wait time will go down.
When picking a pull request to review, try to choose one that hasn't yet
been reviewed.
Thanks for helping out!
-->
To help with the load of incoming pull requests:
- [x] I have reviewed two other [open pull requests][prs] in this repository.
[prs]: https://github.com/home-assistant/core/pulls?q=is%3Aopen+is%3Apr+-author%3A%40me+-draft%3Atrue+-label%3Awaiting-for-upstream+sort%3Acreated-desc+review%3Anone+-status%3Afailure
<!--
Thank you for contributing <3
Below, some useful links you could explore:
-->
[dev-checklist]: https://developers.home-assistant.io/docs/development_checklist/
[manifest-docs]: https://developers.home-assistant.io/docs/creating_integration_manifest/
[quality-scale]: https://developers.home-assistant.io/docs/integration_quality_scale_index/
[docs-repository]: https://github.com/home-assistant/home-assistant.io
[perfect-pr]: https://developers.home-assistant.io/docs/review-process/#creating-the-perfect-pr
So will come in one of the next updates. Milestone 2023.6.2 assigned.
IgorZg
(Igor Simić)
June 14, 2023, 3:06pm
3
So, update_entity should be fixed in next release.
What about reloading command line entities?