iskiselev
(Igor Kiselev)
January 3, 2022, 11:18pm
1
I have Addressable v3 controller (at least I think so, it shows firmware version A3.v1.27.7809-A
). I’ve connected to it RGBW strip (SK6812RGBW)
.
Looks like flux_led detects it as rgb strip - and do not allow me to manage w channel. I still can turn LED strip on/off and change RGB color/brightness, but W will be in the state that I last configured in Magic Home application.
Per forum posts I see, that previously it was possible to set color mode rgbw though config, but looks like now with configuration though UI it dose not allow me to change color mode.
When I check attributes of entity, I see:
effect_list:
- RBM 1
- RBM 2
...
supported_color_modes:
- rgb
color_mode: rgb
brightness: 255
hs_color:
- 0
- 100
rgb_color:
- 255
- 0
- 0
xy_color:
- 0.701
- 0.299
effect: music
ip_address: 192.168.1.139
friendly_name: cabinet_led_test
supported_features: 36
I tried to override mode though config:
light:
- platform: flux_led
devices:
192.168.1.139:
name: cabinet_led_test
mode: "rgbw"
But it have not helped.
bdraco
(J. Nick Koston)
January 4, 2022, 7:49am
2
Fixed here Bump flux_led to 0.27.28 to fix missing white channel on SK6812RGBW strips by bdraco · Pull Request #63154 · home-assistant/core · GitHub
If you want to try the new change before its released
mkdir /config/custom_components
cd /config/custom_components
git clone https://github.com/bdraco/flux_led_custom flux_led
Restart
If its using the custom one you’ll see something like this in the log 2022-01-01 22:33:00 WARNING (SyncWorker_6) [homeassistant.loader] We found a custom integration flux_led which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you experience issues with Home Assistant
bdraco
(J. Nick Koston)
January 4, 2022, 7:53am
3
That repo also has these changes in it which are not yet merged into dev
home-assistant:dev
← bdraco:flux_led_device_config
opened 02:17AM - 26 Dec 21 UTC
## Proposed change
<!--
Describe the big picture of your changes here to com… municate to the
maintainers why we should accept this pull request. If it fixes a bug
or resolves a feature request, be sure to link to that issue in the
additional information section.
-->
The following configuration options for controllers are now available
IC Type (WS2812B, UCS6218, etc)
Wiring (RGB, GRB, BGR, etc)
Operating Mode (ie RGB&W or RGB/W)
Num pixels
Num segments
Num pixels music
Num segments music
## Type of change
<!--
What type of change does your PR introduce to Home Assistant?
NOTE: Please, check only 1! box!
If your PR requires multiple boxes to be checked, you'll most likely need to
split it into multiple PRs. This makes things easier and faster to code review.
-->
- [ ] Dependency upgrade
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [x] New feature (which adds functionality to an existing integration)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
## Additional information
<!--
Details are important, and help maintainers processing your PR.
Please be sure to fill out additional details, if applicable.
-->
- This PR fixes or closes issue: fixes #
- This PR is related to issue:
- Link to documentation pull request:
## Checklist
<!--
Put an `x` in the boxes that apply. You can also fill these out after
creating the PR. If you're unsure about any of them, don't hesitate to ask.
We're here to help! This is simply a reminder of what we are going to look
for before merging your code.
-->
- [x] The code change is tested and works locally.
- [ ] Local tests pass. **Your PR cannot be merged unless tests pass**
- [ ] There is no commented out code in this PR.
- [ ] I have followed the [development checklist][dev-checklist]
- [ ] The code has been formatted using Black (`black --fast homeassistant tests`)
- [x] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated for [www.home-assistant.io][docs-repository]
If the code communicates with devices, web services, or third-party tools:
- [ ] The [manifest file][manifest-docs] has all fields filled out correctly.
Updated and included derived files by running: `python3 -m script.hassfest`.
- [ ] New or updated dependencies have been added to `requirements_all.txt`.
Updated by running `python3 -m script.gen_requirements_all`.
- [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
- [ ] Untested files have been added to `.coveragerc`.
The integration reached or maintains the following [Integration Quality Scale][quality-scale]:
<!--
The Integration Quality Scale scores an integration on the code quality
and user experience. Each level of the quality scale consists of a list
of requirements. We highly recommend getting your integration scored!
-->
- [ ] No score or internal
- [ ] 🥈 Silver
- [ ] 🥇 Gold
- [ ] 🏆 Platinum
<!--
This project is very active and we have a high turnover of pull requests.
Unfortunately, the number of incoming pull requests is higher than what our
reviewers can review and merge so there is a long backlog of pull requests
waiting for review. You can help here!
By reviewing another pull request, you will help raise the code quality of
that pull request and the final review will be faster. This way the general
pace of pull request reviews will go up and your wait time will go down.
When picking a pull request to review, try to choose one that hasn't yet
been reviewed.
Thanks for helping out!
-->
To help with the load of incoming pull requests:
- [ ] I have reviewed two other [open pull requests][prs] in this repository.
[prs]: https://github.com/home-assistant/core/pulls?q=is%3Aopen+is%3Apr+-author%3A%40me+-draft%3Atrue+-label%3Awaiting-for-upstream+sort%3Acreated-desc+review%3Anone
<!--
Thank you for contributing <3
Below, some useful links you could explore:
-->
[dev-checklist]: https://developers.home-assistant.io/docs/en/development_checklist.html
[manifest-docs]: https://developers.home-assistant.io/docs/en/creating_integration_manifest.html
[quality-scale]: https://developers.home-assistant.io/docs/en/next/integration_quality_scale_index.html
[docs-repository]: https://github.com/home-assistant/home-assistant.io
home-assistant:dev
← bdraco:flux_led_legacy_discovery
opened 02:02AM - 26 Dec 21 UTC
## Proposed change
<!--
Describe the big picture of your changes here to com… municate to the
maintainers why we should accept this pull request. If it fixes a bug
or resolves a feature request, be sure to link to that issue in the
additional information section.
-->
Fix missing device name with legacy flux_led discovery
The partial discovery would not be completed for legacy devices 0x1,0x2,0x3
Some of these older devices would take a while to connect if we don't provide discovery data lib since it has to try the newer protocols first.
The device would still work but be named as the mac address which made it a bit confusing
## Type of change
<!--
What type of change does your PR introduce to Home Assistant?
NOTE: Please, check only 1! box!
If your PR requires multiple boxes to be checked, you'll most likely need to
split it into multiple PRs. This makes things easier and faster to code review.
-->
- [ ] Dependency upgrade
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [ ] New feature (which adds functionality to an existing integration)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
## Additional information
<!--
Details are important, and help maintainers processing your PR.
Please be sure to fill out additional details, if applicable.
-->
- This PR fixes or closes issue: fixes #
- This PR is related to issue:
- Link to documentation pull request:
## Checklist
<!--
Put an `x` in the boxes that apply. You can also fill these out after
creating the PR. If you're unsure about any of them, don't hesitate to ask.
We're here to help! This is simply a reminder of what we are going to look
for before merging your code.
-->
- [x] The code change is tested and works locally.
- [ ] Local tests pass. **Your PR cannot be merged unless tests pass**
- [ ] There is no commented out code in this PR.
- [ ] I have followed the [development checklist][dev-checklist]
- [ ] The code has been formatted using Black (`black --fast homeassistant tests`)
- [x] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated for [www.home-assistant.io][docs-repository]
If the code communicates with devices, web services, or third-party tools:
- [ ] The [manifest file][manifest-docs] has all fields filled out correctly.
Updated and included derived files by running: `python3 -m script.hassfest`.
- [ ] New or updated dependencies have been added to `requirements_all.txt`.
Updated by running `python3 -m script.gen_requirements_all`.
- [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
- [ ] Untested files have been added to `.coveragerc`.
The integration reached or maintains the following [Integration Quality Scale][quality-scale]:
<!--
The Integration Quality Scale scores an integration on the code quality
and user experience. Each level of the quality scale consists of a list
of requirements. We highly recommend getting your integration scored!
-->
- [ ] No score or internal
- [ ] 🥈 Silver
- [ ] 🥇 Gold
- [ ] 🏆 Platinum
<!--
This project is very active and we have a high turnover of pull requests.
Unfortunately, the number of incoming pull requests is higher than what our
reviewers can review and merge so there is a long backlog of pull requests
waiting for review. You can help here!
By reviewing another pull request, you will help raise the code quality of
that pull request and the final review will be faster. This way the general
pace of pull request reviews will go up and your wait time will go down.
When picking a pull request to review, try to choose one that hasn't yet
been reviewed.
Thanks for helping out!
-->
To help with the load of incoming pull requests:
- [ ] I have reviewed two other [open pull requests][prs] in this repository.
[prs]: https://github.com/home-assistant/core/pulls?q=is%3Aopen+is%3Apr+-author%3A%40me+-draft%3Atrue+-label%3Awaiting-for-upstream+sort%3Acreated-desc+review%3Anone
<!--
Thank you for contributing <3
Below, some useful links you could explore:
-->
[dev-checklist]: https://developers.home-assistant.io/docs/en/development_checklist.html
[manifest-docs]: https://developers.home-assistant.io/docs/en/creating_integration_manifest.html
[quality-scale]: https://developers.home-assistant.io/docs/en/next/integration_quality_scale_index.html
[docs-repository]: https://github.com/home-assistant/home-assistant.io
iskiselev
(Igor Kiselev)
January 5, 2022, 4:15am
4
Thank you a lot, @bdraco - it works correct now! You’ve fixed it so fast!
I’m not sure if it is connected to the original question, or if it should be separate topic. With that fixed version, if I change color/brightness/white, each time when I turn it off and on it switch to some unexpected color - is there a way to make it preserve last color after turning on and off? Example:
Original:
color_mode: rgbw
brightness: 32
hs_color:
- 0
- 0
rgb_color:
- 64
- 64
- 64
rgbw_color:
- 0
- 0
- 0
- 64
xy_color:
- 0.323
- 0.329
After turn off/on:
color_mode: rgbw
brightness: 204
hs_color:
- 253.585
- 62.353
rgb_color:
- 132
- 96
- 255
rgbw_color:
- 59
- 0
- 255
- 153
xy_color:
- 0.219
- 0.126
Another example, original:
brightness: 128
hs_color:
- 0.235
- 100
rgb_color:
- 255
- 1
- 0
rgbw_color:
- 255
- 1
- 0
- 0
xy_color:
- 0.7
- 0.299
After turn off/on:
color_mode: rgbw
brightness: 192
hs_color:
- 254.118
- 66.667
rgb_color:
- 125
- 85
- 255
rgbw_color:
- 59
- 0
- 255
- 128
xy_color:
- 0.212
- 0.113
bdraco
(J. Nick Koston)
January 5, 2022, 4:29am
5
That’s unexpected. It looks like a bug. Would you please open a GitHub issue?
iskiselev
(Igor Kiselev)
January 5, 2022, 4:48am
6
bdraco
(J. Nick Koston)
January 7, 2022, 9:39pm
7
To close the loop on this, the issue was resolved by rebooting the device.
There is a patch coming in 2021.12.9 to avoid setting the white level too quickly after setting the RGB level to try to avoid hitting the bug in the device firmware that triggers the condition.