Enhance available mqtt_vacuum states

hillbicks · June 2, 2020, 7:39pm

Hey guys,

I already opened up this feature request on github, so hopefully now I’m in the right place.

The problem

the mqtt-vacuum integration currently only lists a limited amount of different states

cleaning,
docked,
paused,
idle,
returning,
error.

When using the integration from the vacuum itself there are more states available which are then mapped to one of the available ones, for example one of the states the xiaomi roborck has is going_to_target, if, well, you guessed it, the robot drives to the target destination. Right now it maps to cleaning state though.

Here is the current mapping for the xiaomi roborock from the valetudo addon.

// Codes as per Status.js
const HA_STATE_MAPPINGS = {
"CHARGER_DISCONNECTED": HA_STATES.IDLE,
"IDLE": HA_STATES.IDLE,
"CLEANING": HA_STATES.CLEANING,
"MANUAL_MODE": HA_STATES.CLEANING,
"SPOT_CLEANING": HA_STATES.CLEANING,
"GOING_TO_TARGET": HA_STATES.CLEANING,
"ZONED_CLEANING": HA_STATES.ZONE_CLEANUP,
"RETURNING_HOME": HA_STATES.RETURNING,
"DOCKING": HA_STATES.RETURNING,
"CHARGING": HA_STATES.DOCKED,
"CHARGING_PROBLEM": HA_STATES.ERROR,
"ERROR": HA_STATES.ERROR,
"PAUSED": HA_STATES.PAUSED,

github.com

Hypfer/Valetudo/blob/3b8172ddd9bca19644bfef6156538335ec3b8a69/lib/MqttClient.js

const fs = require("fs");
const mqtt = require("mqtt");
const Logger = require("./Logger");
const url = require("url");

const MQTT_COMMANDS = {
    START: "start",
    RETURN_TO_BASE: "return_to_base",
    STOP: "stop",
    CLEAN_SPOT: "clean_spot",
    LOCATE: "locate",
    PAUSE: "pause"
};

const CUSTOM_COMMANDS = {
    GO_TO: "go_to",
    ZONED_CLEANUP: "zoned_cleanup"
};

/**

This file has been truncated. show original

Environment

Home Assistant Core release with the issue: 0.110.4
Last working Home Assistant Core release (if known): N/A
Operating environment (Home Assistant/Supervised/Docker/venv): Home Assistant
Integration causing this issue: vacuum.mqtt
Link to integration documentation on our website: https://www.home-assistant.io/integrations/vacuum.mqtt/#state-mqtt-protocol

Additional information

It would be great if the missing states the robot provides could be made available in the mqtt.vacuum integration. Here is my proposal for the new states (marked the new states as bold)

CHARGER_DISCONNECTED,
IDLE,
CLEANING,
MANUAL_MODE,
SPOT_CLEANING,
GOING_TO_TARGET,
ZONED_CLEANING,
RETURNING,
DOCKING,
CHARGING
CHARGING_PROBLEM
ERROR,
PAUSED

thisIO · December 1, 2020, 5:51pm

Subscribed. Interesting

Stooovie · July 11, 2022, 2:56pm

Also for whatever reason, trigger “returning” (from: returning to: docked) stopped working in some of the last releases (now on 2022.7.x). The Automation just stopped triggering. Worked for more than a year. I use it to only trigger automatic cleanup once a day (it triggers a “vacuuming done for today” binary switch helper.