Getting PR 71899 merged ( Add HTTP(s) protocol support to Asuswrt )

shmick · September 6, 2022, 6:04pm

Would anyone be able to have a look at this PR that’s been open for almost 4 months to determine why it can’t be merged?

github.com/home-assistant/core

Add HTTP(s) protocol support to Asuswrt

home-assistant:dev ← ollo69:asuswrt-http-protocol

opened 02:54PM - 15 May 22 UTC

ollo69

+1158 -431

## Proposed change  This PR add the support to `HTTP` and `HTTPS` protocols to AsusWRT integration using [this library](https://github.com/ollo69/pyasuswrt). HTTP protocol is the same used by the `ASUS Router` phone app provided by Asus, so potentially all devices that work with the application should be supported. This protocol in my tests is more reliable in device presence detection, and it also have the advantage to require less information for configuration, and therefore simplifies the initial and option config flows. Sensors for the moment are limited to `Download`, `Upload` and related speeds, more sensors are available but I will leave this for future PR. Support to existing `SSH` and `TELNET `protocol is maintained for compatibility, and config flow requests additional parameter in a second step only when one of this protocols are selected. ## Type of change  - [ ] Dependency upgrade - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New integration (thank you!) - [x] New feature (which adds functionality to an existing integration) - [ ] Breaking change (fix/feature causing existing functionality to break) - [ ] Code quality improvements to existing code or addition of tests ## Additional information  - This PR fixes or closes issue: fixes - This PR is related to issue: #73978 - Link to documentation pull request: ## Checklist  - [x] The code change is tested and works locally. - [x] Local tests pass. **Your PR cannot be merged unless tests pass** - [x] There is no commented out code in this PR. - [x] I have followed the [development checklist][dev-checklist] - [x] The code has been formatted using Black (`black --fast homeassistant tests`) - [x] Tests have been added to verify that the new code works. If user exposed functionality or configuration variables are added/changed: - [ ] Documentation added/updated for [www.home-assistant.io][docs-repository] If the code communicates with devices, web services, or third-party tools: - [x] The [manifest file][manifest-docs] has all fields filled out correctly. Updated and included derived files by running: `python3 -m script.hassfest`. - [x] New or updated dependencies have been added to `requirements_all.txt`. Updated by running `python3 -m script.gen_requirements_all`. - [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description. - [ ] Untested files have been added to `.coveragerc`. The integration reached or maintains the following [Integration Quality Scale][quality-scale]:  - [ ] No score or internal - [ ] 🥈 Silver - [ ] 🥇 Gold - [ ] 🏆 Platinum  To help with the load of incoming pull requests: - [ ] I have reviewed two other [open pull requests][prs] in this repository. [prs]: https://github.com/home-assistant/core/pulls?q=is%3Aopen+is%3Apr+-author%3A%40me+-draft%3Atrue+-label%3Awaiting-for-upstream+sort%3Acreated-desc+review%3Anone+-status%3Afailure  [dev-checklist]: https://developers.home-assistant.io/docs/en/development_checklist.html [manifest-docs]: https://developers.home-assistant.io/docs/en/creating_integration_manifest.html [quality-scale]: https://developers.home-assistant.io/docs/en/next/integration_quality_scale_index.html [docs-repository]: https://github.com/home-assistant/home-assistant.io

Thanks.