Hassfest github action complains about requirements taken from github

Development
1

Hi,
basically, everything is already described here:

hassfest does not like things like this in manifest.json of a custom component, even though they work:

  "requirements": [
    "goecharger @ git+https://github.com/mpw96/[email protected]"
  ],

You start to ignore hassfest findings, which is not good for the quality. Is hassfest still maintained?

T&R
MP

2

Meantime, I’ve opened a pull-request on hassfest: Allow all requirements specs in hassfest by mpw96 · Pull Request #124925 · home-assistant/core · GitHub

3

We only accept requirements that are published on pypi so that PR isn’t going to fly

4

Hi, as suggested by some reviewers this is true for core components. So I’ve changed the PR to accept github requirements only for custom components.