Help with Repeat Until Script

Wes93 · July 28, 2020, 8:50am

Hello to everyone, i need some help with this Script:

01notifiche_alexa_allarme_test_novr:
  sequence:
    - delay:
        milliseconds: 1
    - service: media_player.volume_set
      data:
        entity_id: media_player.ovunque
        volume_level: 1
    - delay: 00:00:02
    - repeat:
        sequence:
          - data_template:
              data:
                method: all
                type: announce
              title: 'Prova'
              message: 'Prova'
            service: notify.alexa_media_ovunque
            # Give it time to complete
          - delay: 00:00:05
        until:
          # Did it work?
          - condition: state
            entity_id: alarm_control_panel.allarme
            state: 'armed_away'
    - delay:
        milliseconds: 1
    - service: media_player.volume_set
      data:
        entity_id: media_player.ovunque
        volume_level: 0.5

If the alarm is in armed_away state the code run only one time… what is wrong?
Thanks a lot
Stefano

fedot · July 28, 2020, 9:43am

Well that’s the point of an until loop.
For/counted loop: Repeat X times
While loop: Repeat while X is true
Until loop: Repeat until X is true

Or am I missing something?

Wes93 · July 28, 2020, 10:08am

Damn… sorry for my stupid question
Regards
Stefano

fedot · July 28, 2020, 10:09am

No worries, report back if it works

Wes93 · July 28, 2020, 10:22am

Perfect works very well now
I have confused until with do…while
the code that work is this:

01notifiche_alexa_allarme_test_novr:
  sequence:
    - delay:
        milliseconds: 1
    - service: media_player.volume_set
      data:
        entity_id: media_player.ovunque
        volume_level: 1
    - delay: 00:00:02
    - repeat:
        sequence:
          - data_template:
              data:
                method: all
                type: announce
              title: 'Prova'
              message: 'Prova'
            service: notify.alexa_media_ovunque
            # Give it time to complete
          - delay: 00:00:05
        while:
          # Did it work?
          - condition: state
            entity_id: alarm_control_panel.allarme
            state: 'triggered'
    - delay:
        milliseconds: 1
    - service: media_player.volume_set
      data:
        entity_id: media_player.ovunque
        volume_level: 0.5

Again thanks a lot
Stefano

pnbruckner · July 28, 2020, 2:40pm

A couple things…

First, I’m wondering, why the 1 ms delays?

Second, you do know that with a while loop it’s possible the actions will never run, right? I.e., if the state of the alarm is not triggered when the script is called then it will not run the sequence in the loop.

If you always want it to run the sequence at least once, then use until:

- repeat:
    sequence:
      - ...
  until:
    - condition: not
      conditions:
        - condition: state
          entity_id: alarm_control_panel.allarme
          state: 'triggered'

Wes93 · July 28, 2020, 3:44pm

Thanks a lot for your reply @pnbruckner, 1st for the beautiful implementation and news about scripting and automations
I have the 1 Ms second because I have a series of script and the delay permit at the automation to call other script asynchronous.
I also will wait a patch for the variables, now I receive an error if I use the variables.

Thanks a lot
Stefano

pnbruckner · July 28, 2020, 4:01pm

Not anymore. That was a workaround that relied on the buggy behavior of scripts/automations.

Please read Waiting for Script to Complete for the proper way to do that.

Wes93 · July 28, 2020, 5:40pm

Tanks a lot Again
But can i use this also in automation?
I have an automation that call a list of script so if i use script.turn_on in the automation action works like the wiki?
An works also if part of the script fail? for example service: media_player.volume_set
The new script

01notifiche_alexa_allarme_test_novr:
  sequence:
    - service: media_player.volume_set
      data:
        entity_id: media_player.ovunque
        volume_level: 1
    - delay: 00:00:02
    - repeat:
        sequence:
          - data_template:
              data:
                method: all
                type: announce
              title: 'Prova'
              message: 'Prova'
            service: notify.alexa_media_ovunque
            # Give it time to complete
          - delay: 00:00:05
        until:
          - condition: not
            conditions:
              - condition: state
                entity_id: alarm_control_panel.allarme
                state: 'triggered'
    - delay:
        milliseconds: 1
    - service: media_player.volume_set
      data:
        entity_id: media_player.ovunque
        volume_level: 0.5

pnbruckner · July 28, 2020, 6:20pm

I’m not sure I understand what you mean by that.

What do you mean by “works like the wiki”?

That is not a script, that is a service.

I’m sorry, I’m really not following what you’re asking.

You still have one 1ms delay in your script that you probably don’t need.

Wes93 · July 29, 2020, 9:37am

Thanks again for your patience @pnbruckner really appreciate
Sorry if I’m not so clear
This is my automation:

- id: '1564681991925'
  alias: 0.2Allarme Triggered
  trigger:
  - entity_id: alarm_control_panel.allarme
    platform: state
    to: triggered
  condition: []
  action:
  - data:
      entity_id: script.03notifica_telegram_cameracucina_immagine
    service: script.turn_on
  **- data:**
**      entity_id:**
**      - switch.0x000d6ffffedd6f8e_switch**
**      - switch.0x000d6ffffee3a23f_switch**
**    service: switch.turn_on**
  - data:
      entity_id: script.03notifica_telegram_cameracucina_video
    service: script.turn_on
  - data:
      entity_id: script.04cameracucina_immagine
    service: script.turn_on
  - data:
      entity_id: script.04cameracucina_video
    service: script.turn_on
  - data_template:
      entity_id: script.02notifica_telefonata
      variables:
        message: 'Attenzione!!! ALLARME ATTIVATO!! Sensori Attivi: {% for state in
          states.binary_sensor -%} {% if state.state == ''on'' and state.entity_id
          not in states.group.noalarm.attributes.entity_id %}  {{ state.name }} {%-
          endif -%} {%- endfor -%}'
    service: script.turn_on

If for example the bold part of the action fail the automation call also this?

  - data:
      entity_id: script.03notifica_telegram_cameracucina_video
    service: script.turn_on

There is also some fix for variables in the repeat script?

Thanks a lot
stefano

pnbruckner · July 29, 2020, 1:52pm

First, I’m not sure how turning on a switch can fail or cause an error. But if it did, that would cause the automation to stop running its actions so the following steps that call other scripts would not be executed. Also, since script.03notifica_telegram_cameracucina_immagine was called via script.turn_on, it would not be affected by the error and would continue to run independent of the automation.

Next, this:

  - data:
      entity_id: script.03notifica_telegram_cameracucina_video
    service: script.turn_on
  - data:
      entity_id: script.04cameracucina_immagine
    service: script.turn_on
  - data:
      entity_id: script.04cameracucina_video
    service: script.turn_on

can be reduced to this:

  - data:
      entity_id:
      - script.03notifica_telegram_cameracucina_video
      - script.04cameracucina_immagine
      - script.04cameracucina_video
    service: script.turn_on

Wes93 · July 29, 2020, 3:49pm

@pnbruckner
Thanks again a lot for your reply and for suggestion to use only one script.turn_on more clear
Thanks for all your help
Stefano

Wes93 · September 1, 2020, 2:35pm

pnbruckner:

  - data:
      entity_id:
      - script.03notifica_telegram_cameracucina_video
      - script.04cameracucina_immagine
      - script.04cameracucina_video
    service: script.turn_on

@pnbruckner another question:
Based on what you have written here i can also do this?
From:

  - data:
      entity_id: script.00notifiche_app_stefano
      variables:
        critical: 1
        messages: "Attenzione!!! ALLARME SCATTATO!! Sensori: {% for state in states.binary_sensor\
          \ -%}\n{% if state.state == 'on' and state.entity_id not in states.group.noalarm.attributes.entity_id\
          \ %}\n {{ state.name }}\n {%- endif -%}\n {%- endfor -%}\n"
        names: Alarm Alert Effect.wav
        volume: 1
    service: script.turn_on
  - data:
      entity_id: script.00notifiche_app_micol
      variables:
        critical: 1
        messagem: "Attenzione!!! ALLARME SCATTATO!! Sensori: {% for state in states.binary_sensor\
          \ -%}\n{% if state.state == 'on' and state.entity_id not in states.group.noalarm.attributes.entity_id\
          \ %}\n {{ state.name }}\n {%- endif -%}\n {%- endfor -%}\n"
        namem: Alarm Alert Effect.wav
        volume: 1
    service: script.turn_on

to:

  - data:
      entity_id: 
        - script.00notifiche_app_stefano
        - script.00notifiche_app_micol
      variables:
        critical: 1
        messages: "Attenzione!!! ALLARME SCATTATO!! Sensori: {% for state in states.binary_sensor\
          \ -%}\n{% if state.state == 'on' and state.entity_id not in states.group.noalarm.attributes.entity_id\
          \ %}\n {{ state.name }}\n {%- endif -%}\n {%- endfor -%}\n"
        names: Alarm Alert Effect.wav
        volume: 1
    service: script.turn_on

Is this correct?
Thansk
Stefano

pnbruckner · September 1, 2020, 3:44pm

Unless messagem & namem aren’t typos, yes that should work.

Wes93 · September 2, 2020, 8:32am

Thanks a Lot

cfgroenewald · November 15, 2020, 4:46pm

I cant seem to get my repeat script to work. Any advice please?

123 · November 15, 2020, 4:57pm

For future reference, please post your question in a separate topic and not part of a thread that has been inactive for 2 months.
Please post your code and not a screenshot of your code.
Does the script pass Configuration > Server Controls > Check Configuration?
Are you certain the condition is correct?
What do you mean exactly when you say it doesn’t work? Does it produce an error message in the log or does it not behave the way you expected?

cfgroenewald · November 23, 2020, 8:51pm

Hi. Apologies NB here. Really struggeling. Please see answers to your questions:

For future reference, please post your question in a separate topic and not part of a thread that has been inactive for 2 months. - Will Do.
Please post your code and not a screenshot of your code. - Really struggling to get the indentation correct when I dot hat.
Does the script pass Configuration > Server Controls > Check Configuration? Cant seem to find this in that directory
Are you certain the condition is correct? I think so yes.
What do you mean exactly when you say it doesn’t work? Does it produce an error message in the log or does it not behave the way you expected?Let me try again:

besproeing_repeat:
  mode: single
  sequence:
  - repeat:
      until:
      - condition: state
        state: 'on'
        entity_id: '{{besp}}'
      sequence:
      - service: switch.turn_on
        data:
          entity_id: '{{besp}}'

Error I get:
Invalid config for [script]: Entity ID {{besp}} is an invalid entity id for dictionary value @ data[‘script’][‘besproeing_repeat’][‘sequence’][0][‘repeat’][‘until’][0][‘entity_id’]. Got ‘{{besp}}’. (See /config/configuration.yaml, line 12).

Home Assistant has started!

123 · November 23, 2020, 9:17pm

The error message indicates {{besp}} is an invalid entity_id. That’s because a State Condition does not permit the use of a template for entity_id.

Change the State Condition to a Template Condition.

besproeing_repeat:
  mode: single
  sequence:
  - repeat:
      until:
      - condition: template
        value_template: "{{ is_state(besp, 'on') }}"
      sequence:
      - service: switch.turn_on
        data:
          entity_id: '{{besp}}'

That should eliminate the error message.

You should know that this automation is not likely to ever perform the repeat for more than one iteration. The moment it turns on the switch, the condition is satisfied and there are no additional repetions.