Hi,
I’ve just added the KNX Heating Controllers to my house and my HA setup. Everything is working beautifully but there’s one piece missing. The history graph does not have the green fill when the heating was actually running?
What is the fill based on? What addresses should be supplied to the configuration?
This is what my configs look like now. I don’t need mode changes - they are always on heat and turn to Idle when there isn’t a heating requirement.
- name: "Kitchen"
temperature_address: "1/6/1"
setpoint_shift_address: "1/5/5"
setpoint_shift_state_address: "1/5/6"
setpoint_shift_mode: "DPT9002"
target_temperature_state_address: "1/5/7"
active_state_address: "1/5/25"
farmio
(Matthias Alphart)
November 10, 2021, 11:42am
2
Can you please post a screenshot of the green thing you are missing?
Where do you see it, and do you know the entities state when it’s added vs when it’s not?
Sure thing. This is the first time I’m using the KNX thermostats. In the past I used the Generic Thermostat integration (one temp sensor and one switch) which worked in this way. I assumed it’s supposed to work in a similar fashion with the KNX climate entries.
This is the KNX one
farmio
(Matthias Alphart)
November 10, 2021, 3:03pm
4
Aha. At my installation these are orange
Seems they don’t show when no change has happened in the shown timeframe - at least I can see it on some rooms, but not all. Not entirely sure what the difference is there, but at least I can confirm it works with knx in general.
I’ll have another look later.
farmio
(Matthias Alphart)
November 10, 2021, 10:51pm
5
Thanks for pointing this out!
home-assistant:dev
← farmio:knx-fix-hvac-action
opened 10:46PM - 10 Nov 21 UTC
## Proposed change
<!--
Describe the big picture of your changes here to com… municate to the
maintainers why we should accept this pull request. If it fixes a bug
or resolves a feature request, be sure to link to that issue in the
additional information section.
-->
KNX climate entities without configured controller_mode (heat/cool etc.) but with `active_state_address` or `command_value_state_address` now show their default hvac_mode as hvac_action when they are active.
## Type of change
<!--
What type of change does your PR introduce to Home Assistant?
NOTE: Please, check only 1! box!
If your PR requires multiple boxes to be checked, you'll most likely need to
split it into multiple PRs. This makes things easier and faster to code review.
-->
- [ ] Dependency upgrade
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [ ] New feature (which adds functionality to an existing integration)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
## Additional information
<!--
Details are important, and help maintainers processing your PR.
Please be sure to fill out additional details, if applicable.
-->
- This PR fixes or closes issue: fixes #
- This PR is related to issue: https://community.home-assistant.io/t/history-graph-on-knx-climate/355169
- Link to documentation pull request:
## Checklist
<!--
Put an `x` in the boxes that apply. You can also fill these out after
creating the PR. If you're unsure about any of them, don't hesitate to ask.
We're here to help! This is simply a reminder of what we are going to look
for before merging your code.
-->
- [x] The code change is tested and works locally.
- [x] Local tests pass. **Your PR cannot be merged unless tests pass**
- [x] There is no commented out code in this PR.
- [x] I have followed the [development checklist][dev-checklist]
- [x] The code has been formatted using Black (`black --fast homeassistant tests`)
- [ ] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated for [www.home-assistant.io][docs-repository]
If the code communicates with devices, web services, or third-party tools:
- [ ] The [manifest file][manifest-docs] has all fields filled out correctly.
Updated and included derived files by running: `python3 -m script.hassfest`.
- [ ] New or updated dependencies have been added to `requirements_all.txt`.
Updated by running `python3 -m script.gen_requirements_all`.
- [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
- [ ] Untested files have been added to `.coveragerc`.
The integration reached or maintains the following [Integration Quality Scale][quality-scale]:
<!--
The Integration Quality Scale scores an integration on the code quality
and user experience. Each level of the quality scale consists of a list
of requirements. We highly recommend getting your integration scored!
-->
- [ ] No score or internal
- [x] 🥈 Silver
- [ ] 🥇 Gold
- [ ] 🏆 Platinum
<!--
This project is very active and we have a high turnover of pull requests.
Unfortunately, the number of incoming pull requests is higher than what our
reviewers can review and merge so there is a long backlog of pull requests
waiting for review. You can help here!
By reviewing another pull request, you will help raise the code quality of
that pull request and the final review will be faster. This way the general
pace of pull request reviews will go up and your wait time will go down.
When picking a pull request to review, try to choose one that hasn't yet
been reviewed.
Thanks for helping out!
-->
To help with the load of incoming pull requests:
- [ ] I have reviewed two other [open pull requests][prs] in this repository.
[prs]: https://github.com/home-assistant/core/pulls?q=is%3Aopen+is%3Apr+-author%3A%40me+-draft%3Atrue+-label%3Awaiting-for-upstream+sort%3Acreated-desc+review%3Anone
<!--
Thank you for contributing <3
Below, some useful links you could explore:
-->
[dev-checklist]: https://developers.home-assistant.io/docs/en/development_checklist.html
[manifest-docs]: https://developers.home-assistant.io/docs/en/creating_integration_manifest.html
[quality-scale]: https://developers.home-assistant.io/docs/en/next/integration_quality_scale_index.html
[docs-repository]: https://github.com/home-assistant/home-assistant.io
1 Like
Is this going to get merged and released in a future version of HA? What is the fix for this now? Do I need to specify the **controller_status_address **?
farmio
(Matthias Alphart)
November 23, 2021, 3:08pm
7
It’s already merged. Will be included in next release 2021.12
If you don’t have one it’s not needed.
Thank you very much! Really appreciate the help