How do I run make xmltest and make dist-update before issuing a PR for device .xml file

I am running RPi 3B image and OpenZWave (Beta). I found my way into the docker container to edit some device .xml files successfully. They work.

Now I want to “give back” and issue a PR to openzwave. They say to run make xmltest and make dist-update (I added a file) “from the top level directory” before issuing the PR. The only place I see that is in Makefile in the root of the repo. What setup do I need to run that given that I will probably use Git Desktop.

Also, I see in someone else’s PR that there is a hash of each file in the repo at cpp/build/testconfigversions.cfg. Am I supposed to edit that or do the makefiles do it?

Just want to do this right.

You just clone the open-zwave repo and run the make commands from the top level directory. You need to have at least make, xmllint and perl installed (maybe more). Since you say “Git Desktop” that sounds like Windows? I’m not sure how well it works there, but if you have the required tools installed, it might work.

make xmltest will update the hashes. make dist-update is nice to do, but most people don’t do it so you might pick up files from others’ mistakes (which you could include, up to you). The maintainer eventually ends up doing it manually anyways.

Maybe I should make a linux vm to do it in. What linux distro would be the best choice?

I use Debian 10 (in Virtualbox). I’m sure anything is fine for validating the XML files.