Hello everyone,
I use the google_assistant integration to control my gate from Google Home.
My problem is simply that my gate is displayed in Google Home “as Garage” while it is displayed “as Gate” in HA.
While looking through the code for the google_assistant integration on github, I discovered this part of the code that seems to be partly responsible for the wrong device type being reported in Google Home regarding my Gate.
I think another upstream declaration is missing before calling TYPE_GATE.
Would it be possible for a developer to take a look to improve the integration and allow the correct type of device (Gate) to be reported in GooGle Home?
Thanks in advance.
BeGood
I checked the google home developer documentation and the Gate type is well supported on their side.
tom_l
May 19, 2024, 11:41pm
2
Please open a new issue here:
So that the issue does not get immediately closed as a “feature request” frame your issue description around the fact that the entity’s device class is incorrectly assigned rather than requesting support for the correct device class.
1 Like
Ok thank you.
I have never opened any issues until now. I will try to do it.
Hello everyone,
I opened an issue and even updated it since I found the solution by completing the const.py file in the google_assistant component.
(via copy into custom_component)
opened 02:06AM - 20 May 24 UTC
integration: google_assistant
### The problem
**Description of the issue**:
In the Google Assistant integrat… ion, the device class of the entity "Gate" is incorrectly assigned as "Garage". This results in improper handling of the device by Google Assistant.
**Technical details**:
I believe I have identified a part of the code that might be responsible for this issue:
- **File**: `core/homeassistant/components/google_assistant/const.py`
- **Lines**: 173 and 174
![image (4)](https://github.com/home-assistant/core/assets/6303352/d0dc4fda-14c8-4a5d-932b-148a11496df7)
**Steps to reproduce the issue**:
1. Configure an entity of type "Gate" in Home Assistant.
2. Sync the entity with Google Assistant.
3. Observe that Google Assistant recognizes it as a "Garage" instead of a "Gate".
The entity "Gate" should be correctly recognized by Google Assistant as a "Gate".
**Current result**:
The entity "Gate" is assigned as a "Garage".
Thank you for your assistance in correcting this issue.
### What version of Home Assistant Core has the issue?
core-2024.5.4
### What was the last working version of Home Assistant Core?
_No response_
### What type of installation are you running?
Home Assistant OS
### Integration causing the issue
Google Assistant
### Link to integration documentation on our website
_No response_
### Diagnostics information
_No response_
### Example YAML snippet
_No response_
### Anything in the logs that might be useful for us?
_No response_
### Additional information
_No response_
Thank you and see you soon.
BeGood✌️
Hello,
I finally managed to do my first PR.
Fork > Create my Branch > update/modify file > commit > pull request
home-assistant:dev
← Bygood91:google_assistante_gate_device_type
opened 09:44PM - 25 May 24 UTC
Update const.py for correctly send Gate device type to Google Assistant.
![Sc… reenshot_20240525_040155_Home](https://github.com/home-assistant/core/assets/6303352/bbd424d5-29d1-426d-8725-d82fb715eac3)
<!--
You are amazing! Thanks for contributing to our project!
Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
-->
## Breaking change
<!--
If your PR contains a breaking change for existing users, it is important
to tell them what breaks, how to make it work again and why we did this.
This piece of text is published with the release notes, so it helps if you
write it towards our users, not us.
Note: Remove this section if this PR is NOT a breaking change.
-->
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
or resolves a feature request, be sure to link to that issue in the
additional information section.
-->
## Type of change
<!--
What type of change does your PR introduce to Home Assistant?
NOTE: Please, check only 1! box!
If your PR requires multiple boxes to be checked, you'll most likely need to
split it into multiple PRs. This makes things easier and faster to code review.
-->
- [ ] Dependency upgrade
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [ ] New feature (which adds functionality to an existing integration)
- [ ] Deprecation (breaking change to happen in the future)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
## Additional information
<!--
Details are important, and help maintainers processing your PR.
Please be sure to fill out additional details, if applicable.
-->
- This PR fixes or closes issue: fixes #
- This PR is related to issue:
- Link to documentation pull request:
## Checklist
<!--
Put an `x` in the boxes that apply. You can also fill these out after
creating the PR. If you're unsure about any of them, don't hesitate to ask.
We're here to help! This is simply a reminder of what we are going to look
for before merging your code.
-->
- [ ] The code change is tested and works locally.
- [ ] Local tests pass. **Your PR cannot be merged unless tests pass**
- [ ] There is no commented out code in this PR.
- [ ] I have followed the [development checklist][dev-checklist]
- [ ] I have followed the [perfect PR recommendations][perfect-pr]
- [ ] The code has been formatted using Ruff (`ruff format homeassistant tests`)
- [ ] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated for [www.home-assistant.io][docs-repository]
If the code communicates with devices, web services, or third-party tools:
- [ ] The [manifest file][manifest-docs] has all fields filled out correctly.
Updated and included derived files by running: `python3 -m script.hassfest`.
- [ ] New or updated dependencies have been added to `requirements_all.txt`.
Updated by running `python3 -m script.gen_requirements_all`.
- [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
- [ ] Untested files have been added to `.coveragerc`.
<!--
This project is very active and we have a high turnover of pull requests.
Unfortunately, the number of incoming pull requests is higher than what our
reviewers can review and merge so there is a long backlog of pull requests
waiting for review. You can help here!
By reviewing another pull request, you will help raise the code quality of
that pull request and the final review will be faster. This way the general
pace of pull request reviews will go up and your wait time will go down.
When picking a pull request to review, try to choose one that hasn't yet
been reviewed.
Thanks for helping out!
-->
To help with the load of incoming pull requests:
- [ ] I have reviewed two other [open pull requests][prs] in this repository.
[prs]: https://github.com/home-assistant/core/pulls?q=is%3Aopen+is%3Apr+-author%3A%40me+-draft%3Atrue+-label%3Awaiting-for-upstream+sort%3Acreated-desc+review%3Anone+-status%3Afailure
<!--
Thank you for contributing <3
Below, some useful links you could explore:
-->
[dev-checklist]: https://developers.home-assistant.io/docs/development_checklist/
[manifest-docs]: https://developers.home-assistant.io/docs/creating_integration_manifest/
[quality-scale]: https://developers.home-assistant.io/docs/integration_quality_scale_index/
[docs-repository]: https://github.com/home-assistant/home-assistant.io
[perfect-pr]: https://developers.home-assistant.io/docs/review-process/#creating-the-perfect-pr