klm
(WZ)
September 30, 2022, 12:45pm
1
Every time I make a push notification with additional data included I need to look up the documentation. There are a lot of things that are nested under data and it would be great if there was a placeholder or additional text fields as checkboxes. Specifically, actionable notification data is what I always forget, but it’s not uncommon for me to also need a refresher on how to layout url, tag, and the clear_notification command.
Great request, would also lead to more users discovering features here!
HarvsG
October 1, 2022, 4:03pm
3
Probably a better and more general version of my post: WTH aren't mobile actionable notifications easier
info4hx4
(John)
October 7, 2022, 8:36pm
4
Might also wan to consider up voting documentation.
I partially disagree. In my teaching experience, lack of information is significant barrier. Adults will quickly abandon topics where all information is not readily available.
I do agree that too much in a single dump can scare some people. Not eveyone enjoys reading “manpages”. Yet, even the least technical person will end up on man pages to get the details, following a well designed introductory material.
A well structured wiki can provide introduction, basic, intermediate, and expert in…
I have implemented part of this
Below PR adds the various notification commands as device actions, meaning you don’t need to dig into the documentation to find out how to turn off DND.
home-assistant:dev
← ZephireNZ:feature/app-notifications
opened 07:58AM - 19 Nov 22 UTC
<!--
You are amazing! Thanks for contributing to our project!
Please, DO N… OT DELETE ANY TEXT from this template! (unless instructed).
-->
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
or resolves a feature request, be sure to link to that issue in the
additional information section.
-->
This change adds device actions for the [Mobile App Notification Commands](https://companion.home-assistant.io/docs/notifications/notification-commands).
This should make these features a lot more accessible to the less tech savvy user rather than using the service directly.
This PR also makes a minor change to the translations hassfest (and corresponding code in frontend) so that labels for device triggers can be provided by an integration (including 3rd party integrations) in addition to the strings in the UI.
## Type of change
<!--
What type of change does your PR introduce to Home Assistant?
NOTE: Please, check only 1! box!
If your PR requires multiple boxes to be checked, you'll most likely need to
split it into multiple PRs. This makes things easier and faster to code review.
-->
- [ ] Dependency upgrade
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [x] New feature (which adds functionality to an existing integration)
- [ ] Deprecation (breaking change to happen in the future)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
## Additional information
<!--
Details are important, and help maintainers processing your PR.
Please be sure to fill out additional details, if applicable.
-->
- This PR fixes or closes issue: fixes #
- This PR is related to issue: home-assistant/frontend#14409
- Link to documentation pull request:
Partially closes this WTF: https://community.home-assistant.io/t/it-shouldnt-be-so-hard-to-remember-set-the-notify-mobile-app-parameters/467214
## Checklist
<!--
Put an `x` in the boxes that apply. You can also fill these out after
creating the PR. If you're unsure about any of them, don't hesitate to ask.
We're here to help! This is simply a reminder of what we are going to look
for before merging your code.
-->
- [x] The code change is tested and works locally.
- [x] Local tests pass. **Your PR cannot be merged unless tests pass**
- [x] There is no commented out code in this PR.
- [x] I have followed the [development checklist][dev-checklist]
- [x] The code has been formatted using Black (`black --fast homeassistant tests`)
- [ ] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated for [www.home-assistant.io][docs-repository]
If the code communicates with devices, web services, or third-party tools:
- [ ] The [manifest file][manifest-docs] has all fields filled out correctly.
Updated and included derived files by running: `python3 -m script.hassfest`.
- [ ] New or updated dependencies have been added to `requirements_all.txt`.
Updated by running `python3 -m script.gen_requirements_all`.
- [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
- [ ] Untested files have been added to `.coveragerc`.
<!--
This project is very active and we have a high turnover of pull requests.
Unfortunately, the number of incoming pull requests is higher than what our
reviewers can review and merge so there is a long backlog of pull requests
waiting for review. You can help here!
By reviewing another pull request, you will help raise the code quality of
that pull request and the final review will be faster. This way the general
pace of pull request reviews will go up and your wait time will go down.
When picking a pull request to review, try to choose one that hasn't yet
been reviewed.
Thanks for helping out!
-->
To help with the load of incoming pull requests:
- [ ] I have reviewed two other [open pull requests][prs] in this repository.
[prs]: https://github.com/home-assistant/core/pulls?q=is%3Aopen+is%3Apr+-author%3A%40me+-draft%3Atrue+-label%3Awaiting-for-upstream+sort%3Acreated-desc+review%3Anone+-status%3Afailure
<!--
Thank you for contributing <3
Below, some useful links you could explore:
-->
[dev-checklist]: https://developers.home-assistant.io/docs/en/development_checklist.html
[manifest-docs]: https://developers.home-assistant.io/docs/en/creating_integration_manifest.html
[quality-scale]: https://developers.home-assistant.io/docs/en/next/integration_quality_scale_index.html
[docs-repository]: https://github.com/home-assistant/home-assistant.io
3 Likes