tristar500
(David Davidson)
May 13, 2021, 4:03pm
1
I’m trying to create an automation that turns on a light when the garage door opens but only after sunset and before sunrise.
Here’s the config, I think I don’t understand how the “condition” works. If the condition is TRUE then the automation won’t run? In this case, if we are before sunrise and after sunset, then condition is true and the automation will not run? I’ve tried it with before: sunset
and after: sunrise
and that doesn’t seem to work correctly either.
id: '162069225'
alias: Turn on back door light when garage door opens
description: ''
trigger:
- type: opened
platform: device
device_id: 7d2b95a331ebd37eef36f118ab0b
entity_id: binary_sensor.garage_door_sensor_garage_door
domain: binary_sensor
condition:
- condition: sun
before: sunrise
after: sunset
action:
- type: turn_on
device_id: 37445c3137b211c56d0f87f85a0
entity_id: switch.back_door_light
domain: switch
mode: single
brewston
(Tim Jones)
May 13, 2021, 4:05pm
2
I have :
condition:
- condition: state
entity_id: sun.sun
state: below_horizon
3 Likes
tristar500
(David Davidson)
May 13, 2021, 4:13pm
3
Thanks, I added this condition - now waiting for sunset.
mcarty
(Arturo)
May 13, 2021, 10:15pm
4
If the condition its true it will run. If false wont.
1 Like
tom_l
May 14, 2021, 5:17am
5
Before sunrise is from midnight to sunrise.
After sunset is from sunset to midnight.
These conditions are AND logic when used together.
It is impossible to be both before sunrise AND after sunset at the same time.
Definitely use Tim’s suggestion above as it is simpler, but just for educational purposes, if you wanted before sunrise OR after sunset you would do this:
condition:
- condition: or
conditions:
- condition: sun
before: sunrise
- condition: sun
after: sunset
1 Like
To continue the educational drift, I made the same kind of mistake as a beginner with the before/after logic and this kind of issue pops up almost monthly. It is actually documented very well.
1 Like
tristar500
(David Davidson)
May 14, 2021, 12:34pm
8
Thanks this worked great.
1 Like
janick
(Janick)
August 6, 2022, 8:45pm
9
I’ve submitted a MR to fix the ‘before sunrise or after sunset’ issue.
It needs reviewers to move it along…
home-assistant:dev
← janick:patch-1
opened 05:19PM - 03 Aug 22 UTC
<!--
You are amazing! Thanks for contributing to our project!
Please, DO N… OT DELETE ANY TEXT from this template! (unless instructed).
-->
## Breaking change
<!--
If your PR contains a breaking change for existing users, it is important
to tell them what breaks, how to make it work again and why we did this.
This piece of text is published with the release notes, so it helps if you
write it towards our users, not us.
Note: Remove this section if this PR is NOT a breaking change.
-->
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
or resolves a feature request, be sure to link to that issue in the
additional information section.
-->
## Type of change
<!--
What type of change does your PR introduce to Home Assistant?
NOTE: Please, check only 1! box!
If your PR requires multiple boxes to be checked, you'll most likely need to
split it into multiple PRs. This makes things easier and faster to code review.
-->
- [ ] Dependency upgrade
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [ ] New feature (which adds functionality to an existing integration)
- [ ] Deprecation (breaking change to happen in the future)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
## Additional information
<!--
Details are important, and help maintainers processing your PR.
Please be sure to fill out additional details, if applicable.
-->
- This PR fixes or closes issue: fixes #70781
- This PR is related to issue:
- Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/23591
## Checklist
<!--
Put an `x` in the boxes that apply. You can also fill these out after
creating the PR. If you're unsure about any of them, don't hesitate to ask.
We're here to help! This is simply a reminder of what we are going to look
for before merging your code.
-->
- [ ] The code change is tested and works locally.
- [ ] Local tests pass. **Your PR cannot be merged unless tests pass**
- [x] There is no commented out code in this PR.
- [x] I have followed the [development checklist][dev-checklist]
- [ ] The code has been formatted using Black (`black --fast homeassistant tests`)
- [x] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [x] Documentation added/updated for [www.home-assistant.io][docs-repository]
If the code communicates with devices, web services, or third-party tools:
- [ ] The [manifest file][manifest-docs] has all fields filled out correctly.
Updated and included derived files by running: `python3 -m script.hassfest`.
- [ ] New or updated dependencies have been added to `requirements_all.txt`.
Updated by running `python3 -m script.gen_requirements_all`.
- [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
- [ ] Untested files have been added to `.coveragerc`.
The integration reached or maintains the following [Integration Quality Scale][quality-scale]:
<!--
The Integration Quality Scale scores an integration on the code quality
and user experience. Each level of the quality scale consists of a list
of requirements. We highly recommend getting your integration scored!
-->
- [ ] No score or internal
- [ ] 🥈 Silver
- [ ] 🥇 Gold
- [ ] 🏆 Platinum
<!--
This project is very active and we have a high turnover of pull requests.
Unfortunately, the number of incoming pull requests is higher than what our
reviewers can review and merge so there is a long backlog of pull requests
waiting for review. You can help here!
By reviewing another pull request, you will help raise the code quality of
that pull request and the final review will be faster. This way the general
pace of pull request reviews will go up and your wait time will go down.
When picking a pull request to review, try to choose one that hasn't yet
been reviewed.
Thanks for helping out!
-->
To help with the load of incoming pull requests:
- [ ] I have reviewed two other [open pull requests][prs] in this repository.
[prs]: https://github.com/home-assistant/core/pulls?q=is%3Aopen+is%3Apr+-author%3A%40me+-draft%3Atrue+-label%3Awaiting-for-upstream+sort%3Acreated-desc+review%3Anone+-status%3Afailure
<!--
Thank you for contributing <3
Below, some useful links you could explore:
-->
[dev-checklist]: https://developers.home-assistant.io/docs/en/development_checklist.html
[manifest-docs]: https://developers.home-assistant.io/docs/en/creating_integration_manifest.html
[quality-scale]: https://developers.home-assistant.io/docs/en/next/integration_quality_scale_index.html
[docs-repository]: https://github.com/home-assistant/home-assistant.io
1 Like