zpriddy
(Zach)
December 14, 2023, 2:01am
1
I was wondering if anyone has been able to merge the trigger selectors with existing triggers in an automation blueprint?
I have the following code and I am trying to append extra_triggers
into the trigger list but have not been successful in doing so.
blueprint:
name: Flic Button MQTT Blueprint
description: Configure actions for flic button via MQTT
domain: automation
source_url: https://github.com/zpriddy/Home-Assistant-Blueprints/blob/4b107a24de70bf96e66679634ec068aa1460f754/flic_button_mqtt.yaml
author: Zachary Priddy
input:
mqtt_topic:
name: Flic Button MQTT Topic
description: Topic for flic button including /action in MQTT
selector:
text: {}
click:
name: Actions for flic clicked
default:
selector:
action: {}
double_click:
name: Actions for flic double clicked
default:
selector:
action: {}
hold:
name: Actions for flic held
default:
selector:
action: {}
extra_triggers:
name: Extra Triggers
description: Additional triggers to actions. Trigger IDs must be set to click, double_click, or hold
default: {}
selector:
trigger:
mode: parallel
max: 3
variables:
mqtt_topic: !input mqtt_topic
trigger_variables:
mqtt_topic: !input mqtt_topic
trigger:
- platform: mqtt
topic: !input mqtt_topic
payload: click
id: click
- platform: mqtt
topic: !input mqtt_topic
payload: double_click
id: double_click
- platform: mqtt
topic: !input mqtt_topic
payload: hold
id: hold
action:
- choose:
- conditions:
- condition: trigger
id:
- click
sequence: !input click
- conditions:
- condition: trigger
id:
- double_click
sequence: !input double_click
- conditions:
- condition: trigger
id:
- hold
sequence: !input hold
Sir_Goodenough
((SG) WhatAreWeFixing.Today)
December 14, 2023, 5:07am
2
Did you try my answer from this?
Help using the new Trigger Selector (2023.12) in Blueprint - #2 by Sir_Goodenough .
What you have is some hybrid mess. I believe the whole trigger has to be in the input, IDās and all, and you add the !input key in the trigger area as a list item.
What you have in your example should work with a text !input.
If this suggestion solves your problem, please consider clicking the solution button to close the thread.
zpriddy
(Zach)
December 14, 2023, 5:36am
3
The example you posted in that thread is closeā¦ but it should be:
trigger:
!input my_triggers
From that example does work only if youāre using triggers from the input. But I cant even make the default triggers use the variables from the other inputs in that caseā¦
I also tried making default triggers a trigger variable and then trying to concat that array with the extra triggersā¦ but that didnt work eitherā¦
I am hoping to find a way to add the extra triggers to the built in ones in the automationā¦ That way i can take a blueprint that does some actions, for example reading button clicks, and add another trigger to it so I dont have to create a new automation for the same action just with a different trigger sourceā¦
Sir_Goodenough
((SG) WhatAreWeFixing.Today)
December 14, 2023, 7:54am
4
Thatās for one. Itās a list, so if you do what I said you should be able to add more triggers.
zpriddy
(Zach)
December 14, 2023, 8:00am
5
I tried that, however it threw errors that it was a malformed inputā¦ it does work that way for conditions without errorā¦ so I was hopefulā¦
Sir_Goodenough
((SG) WhatAreWeFixing.Today)
December 14, 2023, 10:28am
7
Iāll play with it tomorrow. Iām curious nowā¦
1 Like
TH-Braemer
(Th Braemer)
December 14, 2023, 1:59pm
8
I havenāt had the time to test your suggestion yet - work is a pain before Christmas, but I will follow this thread too, and hopefully I will get the time during the weekends around Christmas - no holiday for me this year
Sir_Goodenough
((SG) WhatAreWeFixing.Today)
December 14, 2023, 9:24pm
9
I brought this up to some others, and we all think it canāt be done, and by that itās broken because it should be a thing that was missed in the original code as a requirement.
Working on an issue as we speak, Iāll post it here so you all can add new info and/or thumb it up.
Conditions work because of the condition structure, the structure is different here so need a structure tweak or something else that people smarter than me will have to figure out.
Here is the issueā¦
Trigger selector: cannot add one from selector if one already exists in the blueprint Ā· Issue #19050 Ā· home-assistant/frontend Ā· GitHub .
2 Likes
karwosts
(karwosts)
May 18, 2024, 4:10pm
10
Took a stab at a PR to allow for merging lists of triggers which should fix this. Lets see what the core devs think:
home-assistant:dev
ā karwosts:nestable-trigger-list
opened 04:08PM - 18 May 24 UTC
<!--
You are amazing! Thanks for contributing to our project!
Please, DO Nā¦ OT DELETE ANY TEXT from this template! (unless instructed).
-->
## Proposed change
The user of Trigger Selectors in blueprints currently has a significant limitation in that the selector returns a list of triggers, but there is no yaml syntax to merge a list of triggers from the selector with a list of triggers hardcoded in the blueprint.
So if a blueprint wants to trigger on some predefined behavior, it cannot allow user to configure additional triggers with a selector because the lists cannot be merged.
To mitigate this, I propose a syntax (under `platform: trigger`) for triggers which will allow for combining a list of triggers from an input with a hardcoded list of triggers. When the backend encounters this list, it will just be flattened into a single list of triggers.
E.g.:
```yaml
blueprint:
name: Nested Trigger Blueprint
domain: automation
input:
usertrigger:
selector:
trigger:
trigger:
- platform: time_pattern
seconds: /10
- platform: trigger
trigger: !input usertrigger
condition: []
action: []
```
This can trigger the blueprint on the predefined time pattern, in addition to any triggers specified by the user.
I'm sure there's still more work to be done here with testing, but wanted to see if this idea has merit. It worked for me as a basic proof of concept.
## Type of change
<!--
What type of change does your PR introduce to Home Assistant?
NOTE: Please, check only 1! box!
If your PR requires multiple boxes to be checked, you'll most likely need to
split it into multiple PRs. This makes things easier and faster to code review.
-->
- [ ] Dependency upgrade
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [x] New feature (which adds functionality to an existing integration)
- [ ] Deprecation (breaking change to happen in the future)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
## Additional information
<!--
Details are important, and help maintainers processing your PR.
Please be sure to fill out additional details, if applicable.
-->
- This PR fixes or closes issue: fixes #
- This PR is related to issue:
- Link to documentation pull request:
## Checklist
<!--
Put an `x` in the boxes that apply. You can also fill these out after
creating the PR. If you're unsure about any of them, don't hesitate to ask.
We're here to help! This is simply a reminder of what we are going to look
for before merging your code.
-->
- [x] The code change is tested and works locally.
- [ ] Local tests pass. **Your PR cannot be merged unless tests pass**
- [x] There is no commented out code in this PR.
- [x] I have followed the [development checklist][dev-checklist]
- [x] I have followed the [perfect PR recommendations][perfect-pr]
- [x] The code has been formatted using Ruff (`ruff format homeassistant tests`)
- [ ] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated for [www.home-assistant.io][docs-repository]
If the code communicates with devices, web services, or third-party tools:
- [ ] The [manifest file][manifest-docs] has all fields filled out correctly.
Updated and included derived files by running: `python3 -m script.hassfest`.
- [ ] New or updated dependencies have been added to `requirements_all.txt`.
Updated by running `python3 -m script.gen_requirements_all`.
- [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
- [ ] Untested files have been added to `.coveragerc`.
<!--
This project is very active and we have a high turnover of pull requests.
Unfortunately, the number of incoming pull requests is higher than what our
reviewers can review and merge so there is a long backlog of pull requests
waiting for review. You can help here!
By reviewing another pull request, you will help raise the code quality of
that pull request and the final review will be faster. This way the general
pace of pull request reviews will go up and your wait time will go down.
When picking a pull request to review, try to choose one that hasn't yet
been reviewed.
Thanks for helping out!
-->
To help with the load of incoming pull requests:
- [ ] I have reviewed two other [open pull requests][prs] in this repository.
[prs]: https://github.com/home-assistant/core/pulls?q=is%3Aopen+is%3Apr+-author%3A%40me+-draft%3Atrue+-label%3Awaiting-for-upstream+sort%3Acreated-desc+review%3Anone+-status%3Afailure
<!--
Thank you for contributing <3
Below, some useful links you could explore:
-->
[dev-checklist]: https://developers.home-assistant.io/docs/development_checklist/
[manifest-docs]: https://developers.home-assistant.io/docs/creating_integration_manifest/
[quality-scale]: https://developers.home-assistant.io/docs/integration_quality_scale_index/
[docs-repository]: https://github.com/home-assistant/home-assistant.io
[perfect-pr]: https://developers.home-assistant.io/docs/review-process/#creating-the-perfect-pr
4 Likes
Hope your fix gets approved.
Have a blueprint with timer trigger I definitely donāt want in a selector (timer entity id is selected, of course) and have no way of adding additional time triggers.
Apart from your fix, what is also missing in trigger selector is an optional trigger type.
Anyway, great work
I heard rumors of other Blueprint related things happening this Beta.
any chance that this is on the list? @karwosts
karwosts
(karwosts)
July 9, 2024, 11:38am
13
I donāt have any advance knowledge of whatās coming, beyond the comments on my PR, which are zero. So I wouldnāt count on it
I dropped an actual comment to try to wake it up. Itās been a couple of months so I donāt think itās out of line.
About BPās, I saw leaks from Frenck and Joost about something BP this time.
Discord .