Mitsubishi MELCLOUD integration with Home Assistant

kslb · January 3, 2020, 10:19pm

To add component to HA I simply install via Community plugin (HACS) or manually:

After HA restart just add this code and restart HA again:

climate:
  - platform: melcloud
    email: [email protected]
    password: PASSWORD

(mail and password need to be the same as used for Melcloud login under website or via phone app)

After restart you will get new climate ID device, then you can use it as I use in previous post.

PS.
So, is that the same repository (@vilppuvuorinen) and copy as from @o0Zz?

Didn’t know that @vilppuvuorinen you have copyright of Melcloud component for HA??

Wouldn’t be fair to make merit also to other people before you make copy/paste of the code?

vilppuvuorinen · January 4, 2020, 4:05pm

Dunno man. My integration is registering the entities etc the similar way as the Daikin integration. Maybe that deserves some sort of attribution or not. Otherwise it’s not related to o0Zz’s Melcloud integration. I didn’t like it and wrote my own. Usually writing something gets you the copyright. Is there something I’m missing here?

kslb · January 4, 2020, 6:19pm

Sorry… if you wrote code completly from the strach then OK. But if you use some code from other source then you should mention this in license… But it’s your call…

Ao how is your integration different then Daikin or o0Zz integration?

vilppuvuorinen · January 4, 2020, 6:50pm

I’m not sure if following best practices using a reference implementation warrants attribution or not. I’m trying to get this thing into a shape that could be PRd to HA so it’s not a high prio thing to sort out from that perspective either.

I used Daikin as a reference on how to do multiple platforms for domain and register things in async way. So it’s just similar async_setup, async_setup_entry, async_unload_entry and config_flow approach. Just the parts that do setup against HA. The Daikin integration interacts with Daikin products so there’s nothing else of interest for doing integration with Melcloud.

The integration in my repo tries to be more closely compliant with HA integration guidelines. Config flow, asyncio, external pypi package for melcloud client, unloading, etc. It has also multiple platforms. I didn’t see it productive to try to PR these changes to something existing.

sviudes · January 4, 2020, 7:05pm

We really appreciate your work, and I hope that your PR is accepted by HA so it can be integrated officially. Thank you!

nickrout · January 4, 2020, 8:41pm

Read the code and see. And please don’t accuse people of copyright breach without evidence. And you don’t have evidence because a brief perusal of the github repos will reveal that there is no similarity between oozz’s code and @vilppuvuorinen’s.

kslb · January 6, 2020, 6:04am

I’m not accusing anybody nothing… I just mention it that if code came from other source that they should be mentioned, nothing else.
I fully support what he is doing, and I’m thankful that he try to sort out PR etc… So if I somehow offend him than I trully apology - because this was never my intend to do…

nickrout · January 6, 2020, 6:05am

Enough said. Particularly when you could have looked at the github repos and seen for yourself.

vilppuvuorinen · January 6, 2020, 10:23am

New things available since now:

device_info has the model names from units where the data has been fed in.

Energy sensor. The counter does not necessarily start from zero for some reason and the updates are really sparse. This should be compatible with the utility meter integration.

vilppuvuorinen · January 12, 2020, 12:15pm

It looks like my setup has gone silently to read-only mode. I can observe writes going through to MELCloud but they are reset on the next poll. Only writes originating from MELCloud survive the next poll. Is anyone else experiencing this behavior?

In other news, I’ve got the integration otherwise almost PR ready with config flow tests. I’ll try submitting it once I have figured this read-only thing out. I’ll have to verify the the headers and all.

Next I’m thinking of trying to implement vane positions without using swing mode matrix like o0Zz does.

gomiunik · January 12, 2020, 3:26pm

Hello. Thank you for your effort to have this made official. Currently I’m using o0Zz’s implementation and it doesn’t go to read only mode.
When this goes PR will it be complicated to replace the community plugin with the official? I’m quite new to HA.

jorkar · January 16, 2020, 8:15am

@vilppuvuorinen I tried to install your melcloud integration, but get the following error at startup. Using 0.103.6 of Home Assistant.

Error while setting up platform melcloud
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 148, in _async_setup_platform
    task = async_create_setup_task()
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 104, in async_create_setup_task
    platform.setup_platform,
AttributeError: module 'custom_components.melcloud.climate' has no attribute 'setup_platform'

vilppuvuorinen · January 16, 2020, 8:34am

Have you configured melcloud in your configuration YAML as climate platform? I have tested this only with config_flow through UI. That has been working like a charm.

jorkar · January 16, 2020, 8:50am

climate:
  - platform: melcloud
    email: !secret melcloud_email
    password: !secret melcloud_password

vilppuvuorinen · January 16, 2020, 8:55am

Please, try removing platfrom from your config and add the integration via UI. You’ll get a devices, unloading and all that. Your password won’t be stored in the config entry.

jorkar · January 16, 2020, 8:55am

If i remove entry in configuration.yaml and use the integration instead i get the following:

2020-01-16 09:53:55 ERROR (MainThread) [custom_components.melcloud.config_flow] Unexpected error creating device
Traceback (most recent call last):
  File "/config/custom_components/melcloud/config_flow.py", line 60, in _create_client
    await client.update_confs()
AttributeError: 'coroutine' object has no attribute 'update_confs'

vilppuvuorinen · January 16, 2020, 9:01am

Could you try pulling the latest data from master. It looks like I broke the integartion with the latest pymelcloud update.

jorkar · January 16, 2020, 9:26am

Yes, works @vilppuvuorinen. Thanks.

However… it seems to think my Ecodan is a HVAC… any idea on that?

vilppuvuorinen · January 16, 2020, 9:29am

You probably can’t even control it then. I haven’t implemented anything besides the HVAC/heat pump stuff. I could try adding that in based on oOZz’s integration later on.

jorkar · January 16, 2020, 9:31am

OK, let me know when you need help with testing