Hi all
Since updating to 2024.1.3 I’m getting this error in my log:
Logger: homeassistant.components.sensor
Source: helpers/entity_platform.py:610
Integration: Sensor (documentation, issues)
First occurred: 02:04:11 (6 occurrences)
Last logged: 12:50:28
Platform systemmonitor does not generate unique IDs. ID disk_use_percent already exists - ignoring sensor.disk_use_percent
Platform systemmonitor does not generate unique IDs. ID disk_use already exists - ignoring sensor.disk_use
I don’t think I had this with 2024.1.2 and definately didn’t have it when I had this configured through yaml.
Any ideas how to resolve?
1 Like
123
(Taras)
January 13, 2024, 2:19pm
2
When you originally upgraded to 2024.1.X, it imported your existing YAML configuration for the System Monitor integration into the (hidden) registry.
I believe it then suggests you remove the System Monitor’s YAML configuration.
Did you remove it before upgrading to the latest patch release (2024.1.3)?
Perhaps if you did not remove it, 2024.1.3 attempted to re-import it but now runs into the situation where the sensors it wants to import already exist in the registry.
ID disk_use_percent already exists - ignoring sensor.disk_use_percent
However, if you did remove System Monitor’s YAML configuration, then I don’t know what’s causing 2024.1.3 to report the error message.
Hi @123
Yes, I did.
Maybe I should report an issue via GitHub.
123
(Taras)
January 13, 2024, 2:35pm
4
OK then, yes, report it; seems odd that it’s complaining about existing sensors.
123
(Taras)
January 13, 2024, 3:18pm
5
FYI
Not exactly the problem you’re experiencing but seemingly related to System Monitor’s (mis)handling of sensor discovery/creation.
opened 02:06AM - 13 Jan 24 UTC
integration: systemmonitor
### The problem
TLDR; Large collections of new SystemMonitor entities are being… generated per reboot because docker generates unique interface names on reboot too.
As I was enabling another SystemMonitor entity today, I noticed the integration had accumulated a surprisingly large number (1400+) of entities.
Upon inspection, they’ve turned out to be network info for docker container networks (veth’s from add-ons). Some are current and exist still, some don’t.
It seems obvious they’re building up because docker will autogenerate new random names upon restart and hence keep giving SystemMonitor new names each reboot.
Can the entities be mapped/named after/to the originating add-on somehow?
I’ve skipped logs because this looks like a simple logistics issue but I can supply them if necessary.
### What version of Home Assistant Core has the issue?
2024.1.3
### What was the last working version of Home Assistant Core?
2024.12.3
### What type of installation are you running?
Home Assistant Supervised
### Integration causing the issue
Systemmonitor
### Link to integration documentation on our website
https://www.home-assistant.io/integrations/systemmonitor
### Diagnostics information
n/a
### Example YAML snippet
```yaml
n/a
```
### Anything in the logs that might be useful for us?
```txt
n/a
```
### Additional information
n/a
Looks like someone beat me to it #107926
123
(Taras)
January 13, 2024, 3:35pm
7
Looks like 2024.1.4 will contain a fix for it.
home-assistant:dev
← home-assistant:systemmonitor-fix-duplicates
opened 12:03PM - 13 Jan 24 UTC
<!--
You are amazing! Thanks for contributing to our project!
Please, DO N… OT DELETE ANY TEXT from this template! (unless instructed).
-->
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
or resolves a feature request, be sure to link to that issue in the
additional information section.
-->
Fixes the duplicate unique id issue in System Monitor.
Need to slugify the combined type and argument or it might return `unknown` on argument only when the result is `""`
## Type of change
<!--
What type of change does your PR introduce to Home Assistant?
NOTE: Please, check only 1! box!
If your PR requires multiple boxes to be checked, you'll most likely need to
split it into multiple PRs. This makes things easier and faster to code review.
-->
- [ ] Dependency upgrade
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [ ] New feature (which adds functionality to an existing integration)
- [ ] Deprecation (breaking change to happen in the future)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
## Additional information
<!--
Details are important, and help maintainers processing your PR.
Please be sure to fill out additional details, if applicable.
-->
- This PR fixes or closes issue: fixes #107903
- This PR is related to issue:
- Link to documentation pull request:
## Checklist
<!--
Put an `x` in the boxes that apply. You can also fill these out after
creating the PR. If you're unsure about any of them, don't hesitate to ask.
We're here to help! This is simply a reminder of what we are going to look
for before merging your code.
-->
- [x] The code change is tested and works locally.
- [x] Local tests pass. **Your PR cannot be merged unless tests pass**
- [x] There is no commented out code in this PR.
- [x] I have followed the [development checklist][dev-checklist]
- [x] I have followed the [perfect PR recommendations][perfect-pr]
- [x] The code has been formatted using Ruff (`ruff format homeassistant tests`)
- [ ] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated for [www.home-assistant.io][docs-repository]
If the code communicates with devices, web services, or third-party tools:
- [ ] The [manifest file][manifest-docs] has all fields filled out correctly.
Updated and included derived files by running: `python3 -m script.hassfest`.
- [ ] New or updated dependencies have been added to `requirements_all.txt`.
Updated by running `python3 -m script.gen_requirements_all`.
- [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
- [ ] Untested files have been added to `.coveragerc`.
<!--
This project is very active and we have a high turnover of pull requests.
Unfortunately, the number of incoming pull requests is higher than what our
reviewers can review and merge so there is a long backlog of pull requests
waiting for review. You can help here!
By reviewing another pull request, you will help raise the code quality of
that pull request and the final review will be faster. This way the general
pace of pull request reviews will go up and your wait time will go down.
When picking a pull request to review, try to choose one that hasn't yet
been reviewed.
Thanks for helping out!
-->
To help with the load of incoming pull requests:
- [x] I have reviewed two other [open pull requests][prs] in this repository.
[prs]: https://github.com/home-assistant/core/pulls?q=is%3Aopen+is%3Apr+-author%3A%40me+-draft%3Atrue+-label%3Awaiting-for-upstream+sort%3Acreated-desc+review%3Anone+-status%3Afailure
<!--
Thank you for contributing <3
Below, some useful links you could explore:
-->
[dev-checklist]: https://developers.home-assistant.io/docs/development_checklist/
[manifest-docs]: https://developers.home-assistant.io/docs/creating_integration_manifest/
[quality-scale]: https://developers.home-assistant.io/docs/integration_quality_scale_index/
[docs-repository]: https://github.com/home-assistant/home-assistant.io
[perfect-pr]: https://developers.home-assistant.io/docs/review-process/#creating-the-perfect-pr
1 Like