Question for scripts with parameter

[lethuer]

Hi !

I’m trying to write my first script in esp home and come to a point where I need help.

Here I call my script:

- platform: dallas
  index: 0
  name: "Dallas Temperature"
  id: dallas_temperature
  on_value:
    - if:
        condition: 
          lambda: |-
            return id(External_Temp_Sensor_Lueftersteuerung).state == true;
        then:
          - script.execute: 
              id: update_pwm
              #temp: id(dallas_temperature).state
              temp: !lambda 'return id(dallas_temperature).state;'

This is my script:

script:
  - id: update_pwm
    mode: single
    parameters: 
      #key: value
      temp: float
    then:
      - if:
          condition:
            for:
              time: 10s
              condition:
                - lambda: |-
                    return temp > id(max_temperature).state;
          then:
            - light.turn_on:
                id: d4_light
                effect: flashfast
            - lambda: !lambda |-
                id(Alarm).publish_state(true);
          else:
            - lambda: !lambda |-
                id(Alarm).publish_state(false);
            - light.turn_off: d4_light
      - if:
          condition:
            - lambda: |-
                return temp >= id(start_temp).state;
          then:
            - globals.set:
                id: fan_started
                value: "true"

I get this error message:

/config/esphome/wr-lufter-dallas-sensor.yaml: In lambda function:
/config/esphome/wr-lufter-dallas-sensor.yaml:322:14: error: 'temp' was not declared in this scope
  322 |                     return temp > id(max_temperature).state;

Because I’m using the same code “return temp > id(some_sensor).state;” at two different places the issue should be in the condition “for”. But how to fix this ?

[lethuer]

As additional note: the code was running before I moved it into the script.
The goal is to set an alarm if temperature is above a limit for 10s.
This seems to make issues in a script… how else I could achieve it ?

[Mahko_Mahko]

@lethuer

how else I could achieve it ?

You could create a template binary sensor using this bit (and any other necessary checks).

id(dallas_temperature).state >id(max_temperature).state;

Template Binary Sensor

Add a delayed_on filter of 10s.

Binary Sensor Component

Then add an on_press action (move your actions there, or simply your script and call it from there)

Binary Sensor Component

Your logic and structure seems more complicated than it needs to be, unless I’m missing something.

Edit: Actually reading your script more carefully I can see it’s a bit more nuanced.
Nevertheless consider if you can and want to break it out into binary sensors. I find that easier to monitor and debug.

[Masterzz (Igors Micko)]

Looks this is not solved bug in script parametyerts handling.
Similar staff reported as

Script parameters cannot be modified by nested lambdas

Added Your case too in hope someone will fix it.

[lethuer]

@Mahko_Mahko

You could create a template binary sensor

This is what I already had:

binary_sensor:
  - platform: template
    id: Alarm
    name: $name Alarm
    icon: mdi:fire

@Mahko_Mahko

Then add an on_press action (move your actions there

@Mahko_Mahko

Add a delayed_on filter of 10s.

This were good ideas, thank you for the hint

I modified my script, so that the only thing I do inside the script now is to check the condition which should be fulfilled for the desired time. Any timing related stuff I moved to the binary_sensor outside the script with “on_press” and “on_release” options:

binary_sensor
  - platform: template
    id: Alarm
    name: $name Alarm
    icon: mdi:fire
    filters:
      delayed_on: 10s
    on_press:
      - light.turn_on:
          id: d4_light
          effect: flashfast
    on_release:
      - if:
          condition:
            - lambda: |-
                return id(External_Temp_Sensor_Lueftersteuerung).state == true;
          then:
            - light.turn_on:
                id: d4_light
                effect: slow
          else:
            - light.turn_on:
                id: d4_light
                effect: fast

script:
  - id: update_pwm
    mode: single
    parameters: 
      #key: value
      temp: float
    then:
      # ALARM If over 'Max Temp' for 10 Seconds: Turn on 'binary_sensor: Alarm' & Flash the On-Board LED. Else, turn them off
      - if:
          condition:
            - lambda: |-
                return temp > id(max_temperature).state;
          then:
            - lambda: !lambda |-
                id(Alarm).publish_state(true);
          else:
            - lambda: !lambda |-
                id(Alarm).publish_state(false);