Samba 9.6 Upgrade Killed Samba

Tamsy · April 28, 2022, 1:34am

what is:
sudo nmcli connection show --active
telling?

If wlp1s0 is not used anyway have you tried Samba when the wifi chip is deactivated at the OS level?

sudo nmcli radio wifi off

(sudo nmcli radio wifi on to activate it again)

rontaylor · April 28, 2022, 1:45am

I have the same problem. The 9.6.0 upgrade killed my samba s well. 9.5.1 was working fine.
I have added my logs to the Samba 9.6 Broke Samba · Issue #2447 · home-assistant/addons · GitHub

Tamsy · April 28, 2022, 1:50am

Looking at your posted logs at Github I see exactly the same behavior as with Mark’s Samba failure to start: Samba is trying to build-up a connection through WiFi (wlp-xxx) instead through the default NIC.

rontaylor · April 28, 2022, 2:22am

I am using a NUC i3 running Ubuntu and I just checked ( to be sure as I only ever use the RJ45 Ethernet port) the WiFi and the WiFi adapter is not enabled.

joem · April 28, 2022, 8:45am

Similar problem here.
Tried manual and auto configure in HA config.
My adapter is eth0, see image.

SAMBA does detect only Io, but the rest of the log is similar.

[fix-attrs.d] applying ownership & permissions fixes...
[fix-attrs.d] done.
[cont-init.d] executing container initialization scripts...
[cont-init.d] samba.sh: executing... 
[20:10:42] INFO: Hostname: homeassistant
[20:10:42] INFO: Interfaces: lo 
No builtin backend found, trying to load plugin
tdbsam_open: Converting version 0.0 database to version 4.0.
tdbsam_convert_backup: updated /var/lib/samba/private/passdb.tdb file.
account_policy_get: tdb_fetch_uint32_t failed for type 1 (min password length), returning 0
account_policy_get: tdb_fetch_uint32_t failed for type 2 (password history), returning 0
account_policy_get: tdb_fetch_uint32_t failed for type 3 (user must logon to change password), returning 0
account_policy_get: tdb_fetch_uint32_t failed for type 4 (maximum password age), returning 0
account_policy_get: tdb_fetch_uint32_t failed for type 5 (minimum password age), returning 0
account_policy_get: tdb_fetch_uint32_t failed for type 6 (lockout duration), returning 0
account_policy_get: tdb_fetch_uint32_t failed for type 7 (reset count minutes), returning 0
account_policy_get: tdb_fetch_uint32_t failed for type 8 (bad lockout attempt), returning 0
account_policy_get: tdb_fetch_uint32_t failed for type 9 (disconnect time), returning 0
account_policy_get: tdb_fetch_uint32_t failed for type 10 (refuse machine password change), returning 0
Added user zsolt.
[cont-init.d] samba.sh: exited 0.
[cont-init.d] done.
[services.d] starting services
[services.d] done.
nmbd version 4.13.17 started.
Copyright Andrew Tridgell and the Samba Team 1992-2020
Registered MSG_REQ_POOL_USAGE
Registered MSG_REQ_DMALLOC_MARK and LOG_CHANGED
Registered MSG_REQ_POOL_USAGE
added interface lo ip=::1 bcast= netmask=ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff
added interface lo ip=127.0.0.1 bcast=127.255.255.255 netmask=255.0.0.0
daemon_status: daemon 'nmbd' : No local IPv4 non-loopback interfaces available, waiting for interface ...
NOTE: NetBIOS name resolution is not supported for Internet Protocol Version 6 (IPv6).
smbd version 4.13.17 started.
Copyright Andrew Tridgell and the Samba Team 1992-2020
Registered MSG_REQ_POOL_USAGE
Registered MSG_REQ_DMALLOC_MARK and LOG_CHANGED
Processing section "[config]"
Processing section "[addons]"
Processing section "[ssl]"
Processing section "[share]"
Processing section "[backup]"
Processing section "[media]"
added interface lo ip=::1 bcast= netmask=ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff
added interface lo ip=127.0.0.1 bcast=127.255.255.255 netmask=255.0.0.0
INFO: Profiling support unavailable in this build.
Registered MSG_REQ_POOL_USAGE
No builtin backend found, trying to load plugin
Registered MSG_REQ_POOL_USAGE
Registered MSG_REQ_POOL_USAGE
daemon_ready: daemon 'smbd' finished starting up and ready to serve connections
waiting for connections
added interface lo ip=::1 bcast= netmask=ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff
added interface lo ip=127.0.0.1 bcast=127.255.255.255 netmask=255.0.0.0

My SAMBA config:

  - 192.168.0.0/16
  - 10.0.0.0/8
  - 172.16.0.0/12
compatibility_mode: false
username: zsolt
password: *redacted*
veto_files:
  - ._*
  - .DS_Store
  - Thumbs.db
  - icon?
  - .Trashes
workgroup: WORKGROUP

tom_l · April 28, 2022, 8:47am

One of you should open an issue:

joem · April 28, 2022, 8:55am

@Markus99 already did.

nickrout · April 28, 2022, 10:25am

Pretty sure the changelog said something about samba now listening on all interfaces.

CentralCommand · April 28, 2022, 12:40pm

On all supported interfaces. I notice in the issue the author says they are running supervised on an unsupported os (put “other”). And above in the posts is mention of Ubuntu (also not supported).

I’ll talk it over with the supervisor team but I’m not going to immediately revert this change without a report of something breaking for a user on a supported system as there was a lot of requests to support multiple interfaces in the samba addon.

EDIT: btw if anyone is seeing issues with this update on a supported system please make a new issue with those details.

Markus99 · April 28, 2022, 1:16pm

Forgive my lack of technical expertise. I’m not trying to have this ‘rolled back’, simply prefer to not adversely affect my current setup. My ip addr shows the wlp1s0 interface as down, yet this is the one post-upgrade the new code is trying to have Samba use? Again, not an expert, but can’t this simply be filtered out and the eno1 interface be used? Clearly this interface has worked for years now before this upgrade, so seems it should be able to be included and used after the upgrade?

CentralCommand · April 28, 2022, 2:56pm

Sure I get it. But HA doesn’t support your system given the installation method you’ve chosen, you do. If you switch to a supported installation method and this change still causes issues then we will make sure to fix them. If you run on an unsupported OS though then you should prepare to face unexpected breaking changes at any time with any update. There is no testing done on unsupported OS’s so its very likely there will be no warning at all. And you’ll need to be prepared to fix what broke yourself.

007DJ · April 28, 2022, 6:37pm

Thanks for the pointer… I use Samba daily and would be crippled without.
Obviously I am holding out on that upgrade and will watch this thread for updates.
As it been reported to the maker(s)

lmagyar1973 · April 28, 2022, 10:01pm

Until it is resolved somebody wants to configure interfaces: and run samba on unsupported interfaces, give this fork a try: GitHub - lmagyar/homeassistant-addon-samba-interface: Restores interfaces configuration for Samba add-on

This is identical with the official 9.6.0 but contains the optional interfaces: parameter (note the plural, interfaces, not interface).

nickrout · April 28, 2022, 10:02pm

Samba is not broken on supported supervised. Debian 11.

EDIT: mind you, I have no wireless interfaces, so I don’t get am interface starting wl

Perhaps a good idea might be to force the wireless interface to not load.

Markus99 · April 29, 2022, 1:48am

TY for posting this. A little head scratching that this wasn’t included in the ‘official’ 9.6 release. Giving users options / being backwards compatible seems like a good thing, at least to me. Hoping a 9.6.1 is released that re-includes this feature.

lmagyar1973 · April 29, 2022, 9:58am

PR is waiting for merge: add the default interface to the supported interface list. Theoretically it merges the 9.5.1 and 9.6.0 functionality. See: [Samba] Add default interface to supported interface list by lmagyar · Pull Request #2456 · home-assistant/addons · GitHub

Also added this functionality to the forked version: if somebody installs the forked v9.6.1.4 and it works without an interfaces: parameter, the next official v9.6.1 will work also.

Please test the forked v9.6.1.4, because the core team won’t test it on unsupported environments and I can’t test it also.

Markus99 · April 29, 2022, 2:10pm

Brilliant. Installed from your updated repository (GitHub - lmagyar/homeassistant-addon-samba-interface: Restores interfaces configuration for Samba add-on) and added this to configuration:

interfaces:
  - eno1

It’s back and working!

lmagyar1973 · April 29, 2022, 6:24pm

So the final, accepted official v9.6.1 bugfix:

run only on the supported interfaces, nothing more
exit with error if there are no supported interfaces

Forked samba add-on v9.6.1.6 also released with this fix and error message. And certainly the optional interfaces: configuration option remained.

So anybody who needs Samba add-on on an unsupported system, should use the forked version from now on. See: GitHub - lmagyar/homeassistant-addon-samba-interface: Restores interfaces configuration for Samba add-on

I will maintain it, because I also need the extra configuration option, even if my system is supported. I access Samba only from the SSH add-on (with port forwarding) through the lo interface.

rontaylor · April 29, 2022, 8:27pm

Thank You.
I am running Ubuntu, which is unsupported, so using your fork got mine working again.

aheath · November 10, 2022, 1:39pm

Well, I just got hit with this one after doing a repair of an issue that Home Assistant reported. I got a few warnings, and I went ahead and fixed them … not sure which one of them caused the issue, but it obviously renamed my network interface to do it! I too am running an on Intel NUC, and the interface is eno1.

Anyway, long story short, had to install @lmagyar1973’s Samba fork and it did work.

Thanks @lmagyar1973 for your work … you got me out of a pickle!