Second sonoff is intefering with the first

I have had a sonoff running for ages with the code from misperry

but when adding a second one they seem to be intefering with each other. Only one will work at a time even though there sub/pub details are different. They both appear connected but when one is responding to on/off commands the other does nothing and vica/versa. They swap over every couple of minutes.

Has anyone else had anything similar?
Code for 1st sonoff:

#include <ESP8266WiFi.h>
#include <PubSubClient.h>

// Update these with values suitable for your network.
const char* ssid = "xxx";
const char* password = "xxx";
const char* mqtt_server = "192.168.1.6";
#define mqtt_user "username" //enter your MQTT username
#define mqtt_password "password" //enter your password

WiFiClient espClient;
PubSubClient client(espClient);
int SwitchedPin = 12, LEDPin = 13, Override = 14, OverrideMem = 0;
bool HassSwitch = false;
String switch1;
String strTopic;
String strPayload;

void setup_wifi() {
 Serial.begin(115200);
  delay(2000);

  // We start by connecting to a WiFi network
 
  Serial.println();
  Serial.println();
  Serial.print("Connecting to ");
  Serial.println(ssid);
  
  WiFi.begin(ssid, password);
  
  while (WiFi.status() != WL_CONNECTED) {
    delay(500);
    Serial.print(".");
  }
 
  Serial.println("");
  Serial.println("WiFi connected");  
  Serial.println("IP address: ");
  Serial.println(WiFi.localIP());

  pinMode(LEDPin,OUTPUT);
  digitalWrite(LEDPin, HIGH);

  
}

void callback(char* topic, byte* payload, unsigned int length) {
  payload[length] = '\0';
  strTopic = String((char*)topic);
  if(strTopic == "kitchen/led1")  //xxxxxxxxxxxxxxxxxxxxxxxxxxxxx match with yaml xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
    {
    switch1 = String((char*)payload);
    if(switch1 == "ON")
      {
        Serial.println("ON");
        digitalWrite(SwitchedPin, HIGH);
        digitalWrite(LEDPin, LOW);
        HassSwitch = true;
      }
    else
      {
        Serial.println("OFF");
        digitalWrite(SwitchedPin, LOW);
        digitalWrite(LEDPin, HIGH);
        HassSwitch = false;
      }
    }
}
 
 
void reconnect() {
  // Loop until we're reconnected
  while (!client.connected()) {
    Serial.print("Attempting MQTT connection...");
    // Attempt to connect
    if (client.connect("arduinoClient", mqtt_user, mqtt_password)) {
      Serial.println("connected");
      // Once connected, publish an announcement...
      client.subscribe("kitchen/led1");   //xxxxxxxxxxxxxxxxxxxxxxxxxxxxx match with yaml xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
    } 
    else {
      Serial.print("failed, rc=");
      Serial.print(client.state());
      Serial.println(" try again in 5 seconds");
      // Wait 5 seconds before retrying
      delay(5000);
    }
  }
}
 
void setup()
{
  setup_wifi(); 
  client.setServer(mqtt_server, 1883);
  client.setCallback(callback);

  pinMode(SwitchedPin, OUTPUT);
  digitalWrite(SwitchedPin, LOW);
}
 
void loop()
{
  if (!client.connected()) {
    reconnect();
  }
  if(digitalRead(Override) != OverrideMem && !HassSwitch)
  {
    if(digitalRead(Override))
    {
      Serial.println("ON");
      digitalWrite(SwitchedPin, HIGH);
      digitalWrite(LEDPin, LOW);
      OverrideMem = 1;
    }
    else
    {
      Serial.println("OFF");
      digitalWrite(SwitchedPin, LOW);
      digitalWrite(LEDPin, HIGH);
      OverrideMem = 0;
    }
  }
  client.loop();
}

code for second sonoff:

#include <ESP8266WiFi.h>
#include <PubSubClient.h>

// Update these with values suitable for your network.
const char* ssid = "xxx";
const char* password = "xxxx";
const char* mqtt_server = "192.168.1.6";
#define mqtt_user "username" //enter your MQTT username
#define mqtt_password "password" //enter your password

WiFiClient espClient;
PubSubClient client(espClient);
int SwitchedPin = 12, LEDPin = 13, Override = 14, OverrideMem = 0;
bool HassSwitch = false;
String switch1;
String strTopic;
String strPayload;

void setup_wifi() 
{
 Serial.begin(115200);
  delay(2000);

  // We start by connecting to a WiFi network
 
  Serial.println();
  Serial.println();
  Serial.print("Connecting to ");
  Serial.println(ssid);
  
  WiFi.begin(ssid, password);
  
  while (WiFi.status() != WL_CONNECTED)
  {
    delay(500);
    Serial.print(".");
  }
 
  Serial.println("");
  Serial.println("WiFi connected");  
  Serial.println("IP address: ");
  Serial.println(WiFi.localIP());

  pinMode(LEDPin,OUTPUT);
  digitalWrite(LEDPin, HIGH);
}

void callback(char* topic, byte* payload, unsigned int length) 
{
  payload[length] = '\0';
  strTopic = String((char*)topic);
  if(strTopic == "bathroom/glass1")  //xxxxxxxxxxxxxxxxxxxxxxxxxxxxx match with yaml xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
    {
    switch1 = String((char*)payload);
    if(switch1 == "ON")
      {
        Serial.println("ON");
        digitalWrite(SwitchedPin, HIGH);
        digitalWrite(LEDPin, LOW);
        HassSwitch = true;
      }
    else
      {
        Serial.println("OFF");
        digitalWrite(SwitchedPin, LOW);
        digitalWrite(LEDPin, HIGH);
        HassSwitch = false;
      }
    }
}
 
 
void reconnect() {
  // Loop until we're reconnected
  while (!client.connected()) {
    Serial.print("Attempting MQTT connection...");
    // Attempt to connect
    if (client.connect("arduinoClient", mqtt_user, mqtt_password)) {
      Serial.println("connected");
      // Once connected, publish an announcement...
      client.subscribe("bathroom/glass1");   //xxxxxxxxxxxxxxxxxxxxxxxxxxxxx match with yaml xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
    } 
    else {
      Serial.print("failed, rc=");
      Serial.print(client.state());
      Serial.println(" try again in 5 seconds");
      // Wait 5 seconds before retrying
      delay(5000);
    }
  }
}
 
void setup()
{
  setup_wifi(); 
  client.setServer(mqtt_server, 1883);
  client.setCallback(callback);

  pinMode(SwitchedPin, OUTPUT);
  digitalWrite(SwitchedPin, LOW);
}
 
void loop()
{
  if (!client.connected()) {
    reconnect();
  }
  if(digitalRead(Override) != OverrideMem && !HassSwitch)
  {
    if(digitalRead(Override))
    {
      Serial.println("ON");
      digitalWrite(SwitchedPin, HIGH);
      digitalWrite(LEDPin, LOW);
      OverrideMem = 1;
    }
    else
    {
      Serial.println("OFF");
      digitalWrite(SwitchedPin, LOW);
      digitalWrite(LEDPin, HIGH);
      OverrideMem = 0;
    }
  }
  client.loop();
}

yaml entries:

switch 9:
platform: mqtt
name: “Kitchen”
state_topic: “kitchen/led1”
command_topic: “kitchen/led1”
qos: 0
payload_on: “ON”
payload_off: “OFF”
optimistic:
false retain: true

switch 10:
platform: mqtt
name: “Skylight”
state_topic: “bathroom/glass1”
command_topic: “bathroom/glass1”
qos: 0
payload_on: “ON”
payload_off: “OFF”
optimistic:
false retain: true

Client ids have to be unique when connecting to the broker. You need to construct a different client_id (instead of"arduinoClient") for each device.

This is normally done using a system call that gets a unique id for the chip, but you can make anything up you like, provided its different from anything else you connect to the broker.

1 Like

brilliant! I’ll give that a go.
thank you for the super fast responce. I love you guys!