Split time condition into time and weekday

While working on automation editor for Lovelace I created PR that splits time condition into two conditions:
Architecture: https://github.com/home-assistant/architecture/issues/356
Core: https://github.com/home-assistant/core/pull/32848
Frontend: https://github.com/home-assistant/frontend/pull/5324
Docs: https://github.com/home-assistant/home-assistant.io/pull/12499 :white_check_mark:

Sadly only docs PR got approved.
How does the approval flow look like? I don’t want to mention devs in comments in my PR.
Also, I’m not sure where I can ask for a review.
Should I use forum, discord?

I’d like to help with development, but without feedback on small things I can’t start with bigger :slight_smile:

on your PR’s page at the right there might be a person you can click to ask for a review.

not forum. discord might work

well, it’s an interesting world HA. devs are busy so don’t always expect a lot of feedback start with something small and then progress.

on your PR’s page at the right there might be a person you can click to ask for a review.

unfortunately, I have no options to request a review and I see no one on the right.
I’ll wait couple of days and ask on Discord.

well, it’s an interesting world HA. devs are busy so don’t always expect a lot of feedback start with something small and then progress.

I’m aware the devs are busy and I don’t expect to have feedback seconds after I create PR or ask a question.

I like the direction HA is going and I don’t want to be a user that only expects but also someone who can repay by helping others by contributing to this awesome project.

Besides that, it’s always better to start with small things :slight_smile:

1 Like

yeah, sometimes it show it and sometimes not - apparently it tries to figure out authors/contributors.
the good thing is now everyone can review. so ask politely on Discord.