Unlisted breaking change in NR 4.0 for the join node

Mikefila · June 23, 2024, 8:25pm

It seems that you can no longer use msg.parts

Join Node in manual stopped automatically sending joined message when last split message arrives. New bug or bug fix?

opened 10:33AM - 22 Jun 24 UTC

needs-triage

### Current Behavior In NR3.1.9 the manual join in the flow below sends the joi…ned string immediately after all message parts have arrived. In NR4.0 nothing is sent unless one of the options "number of parts", "timeout" or "msg.complete" is selected. ### Expected Behavior Perhaps this is a bugfix? It does seem to be a breaking change and is apparently not mentioned in the documentation. ### Steps To Reproduce _No response_ ### Example flow ![image](https://github.com/node-red/node-red/assets/11013909/c48a5cdb-a760-4b4e-8775-9cfb95076db4) ``` [{"id":"262a06c7.d1a87a","type":"inject","z":"73aa4e3ce5726647","name":"Inject array","props":[{"p":"payload"},{"p":"topic","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","payload":"[\"aaa\", \"bbb\"]","payloadType":"json","x":100,"y":120,"wires":[["d1475eb351408ccd"]]},{"id":"fb44dce01fbd722e","type":"debug","z":"73aa4e3ce5726647","name":"output","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"true","targetType":"full","statusVal":"","statusType":"auto","x":730,"y":120,"wires":[]},{"id":"d1475eb351408ccd","type":"split","z":"73aa4e3ce5726647","name":"default split settings","splt":"","spltType":"str","arraySplt":1,"arraySpltType":"len","stream":false,"addname":"","x":290,"y":120,"wires":[["8ca50b0b593537a2"]]},{"id":"8ca50b0b593537a2","type":"join","z":"73aa4e3ce5726647","name":"Manual join using hyphen","mode":"custom","build":"string","property":"payload","propertyType":"msg","key":"topic","joiner":"-","joinerType":"str","accumulate":false,"timeout":"","count":"","reduceRight":false,"reduceExp":"","reduceInit":"","reduceInitType":"","reduceFixup":"","x":530,"y":120,"wires":[["fb44dce01fbd722e"]]}] ``` ### Environment - Node-RED version: 3.1.9 / 4.0 - Node.js version: 20.13.1 - npm version: 10.5.2 - Platform/OS: Raspberry Pi / RPiOS - Browser: Firefox

Biscuit · June 23, 2024, 8:37pm

let split node specify property to split on, and join auto join correctly (#4386) @dceejay

Specifically the PR is at
https://github.com/node-red/node-red/pull/4386

and commented as

let split node specify property to split on, and join auto join correctly
or manually the specified one.

New feature (non-breaking change which adds functionality)
This PR lets the split node specify the property that it will split on… it adds the specified property to the parts property as ‘parts.property’. It defaults to payload so should be non-breaking. So far testing and extra tests all work OK.
The join node can then rejoin the specified property automatically. Or operate on the property configured - again defaults to msg.payload.

I have not yet updated my addons to v18 (think I will wait until the dust settles on this one) so I can’t test, but if the split is now by property (defaults to parts.property = msg.payload) then manual join will now have to specify the join property.

I’ll leave testing that to you!

Lordlinhey · June 23, 2024, 9:38pm

Yes I found the same issue, so i have to go through all my flows to make corrections.
The index property does work though

Mikefila · June 23, 2024, 11:33pm

I don’t use any join nodes but if I understand this correctly there was a bug that allowed the node to operate in auto mode while set to manual, which should not have worked.

This was fixed but anyone that was unwittingly exploiting this bug is now going to get the error they should have got in the first place.