Viessmann ViCare Ventilation

dusan-ivanco · January 6, 2024, 8:24pm

Please, add support for ventilation

github.com/somm15/PyViCare

add support for ventilation

somm15:master ← aaschmid:ventilation

opened 10:18PM - 11 Sep 23 UTC

aaschmid

+777 -21

Update: Just finished the PR by adding some tests. ---- Questions before I …will finish it with tests, documentation etc.: * Does anyone now what the difference between `deviceType` `"TCU"` and `"ventilation"` is? Especially you currently only support `"tcu"` but on my `"ViAir..."` there also appears a device written in upper case... -> ignored for now * Are there any coding guidelines or standards you follow? -> just used the defaults of my Intellij * You do use `mypy` but I haven't seen any type annotations in the code so far? Should I type - at least new code - or not? -> currently not done Cheers