When warning about data in schema_json, can we add the invalid data?

anotherthomas · October 23, 2022, 9:36am

I’m trying to use esphome-lights in scenes, but I only get warnings about “invalid color_mode”.
Since the warning doesn’t state which, I’m at a loss. Can we add the data causing the warning in the message?

E.g. in

github.com

home-assistant/core/blob/8aa30cce26715255d43c9a02102d9c9668f6546f/homeassistant/components/mqtt/light/schema_json.py#L291

    
      
                  pass
              except ValueError:
                  _LOGGER.warning(
                      "Invalid HS color value received for entity %s", self.entity_id
                  )
                  return
          else:
              color_mode = values["color_mode"]
              if not self._supports_color_mode(color_mode):
                  _LOGGER.warning(
                      "Invalid color mode received for entity %s", self.entity_id
                  )
                  return
              try:
                  if color_mode == ColorMode.COLOR_TEMP:
                      self._color_temp = int(values["color_temp"])
                      self._color_mode = ColorMode.COLOR_TEMP
                  elif color_mode == ColorMode.HS:
                      hue = float(values["color"]["h"])
                      saturation = float(values["color"]["s"])
                      self._color_mode = ColorMode.HS

I don’t want to start an issue and changing everything without some confidence that the MR would be merged.

anotherthomas · November 18, 2022, 11:20am

Anyone actively disinterested?
I think the improved problem reporting woud be useful and I’d even do the work