Why cant we specify a speed and a preset_mode for template fans?

petro · September 30, 2022, 4:40pm

Right now you can’t set speed and a preset mode. The template fan integration is optimistic in the background and overrules your templates with unexpected behavior. Why?

petro · October 26, 2022, 9:27pm

Fixed with

github.com/home-assistant/core

Allow setting set_percentage and set_preset_mode of template fan without turning on

home-assistant:dev ← Petro31:template-fan-changes

opened 01:32PM - 23 Jul 22 UTC

Petro31

+160 -39

## Breaking change  Template fans no longer change their state to `on` when `set_percentage` or `set_preset_mode` is called if a `value_template` has been configured. ## Proposed change  The template fan behavior is different than all other template entities. It overwrites the state (which should be determined by the value_template) when executing the set_percentage and set_present_mode. These should not be assumed states, the overall state should always be provided by value_template. Otherwise, that's the point of having a template when it's not honored. ## Type of change  - [ ] Dependency upgrade - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New integration (thank you!) - [ ] New feature (which adds functionality to an existing integration) - [ ] Deprecation (breaking change to happen in the future) - [x] Breaking change (fix/feature causing existing functionality to break) - [ ] Code quality improvements to existing code or addition of tests ## Additional information  - This PR fixes or closes issue: fixes # - This PR is related to issue: - Link to documentation pull request: ## Checklist  - [x] The code change is tested and works locally. - [x] Local tests pass. **Your PR cannot be merged unless tests pass** - [x] There is no commented out code in this PR. - [x] I have followed the [development checklist][dev-checklist] - [x] The code has been formatted using Black (`black --fast homeassistant tests`) - [x] Tests have been added to verify that the new code works. If user exposed functionality or configuration variables are added/changed: - [x] Documentation added/updated for [www.home-assistant.io][docs-repository] If the code communicates with devices, web services, or third-party tools: - [x] The [manifest file][manifest-docs] has all fields filled out correctly. Updated and included derived files by running: `python3 -m script.hassfest`. - [x] New or updated dependencies have been added to `requirements_all.txt`. Updated by running `python3 -m script.gen_requirements_all`. - [x] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description. - [x] Untested files have been added to `.coveragerc`. The integration reached or maintains the following [Integration Quality Scale][quality-scale]:  - [ ] No score or internal - [ ] 🥈 Silver - [ ] 🥇 Gold - [ ] 🏆 Platinum  To help with the load of incoming pull requests: - [ ] I have reviewed two other [open pull requests][prs] in this repository. [prs]: https://github.com/home-assistant/core/pulls?q=is%3Aopen+is%3Apr+-author%3A%40me+-draft%3Atrue+-label%3Awaiting-for-upstream+sort%3Acreated-desc+review%3Anone+-status%3Afailure  [dev-checklist]: https://developers.home-assistant.io/docs/en/development_checklist.html [manifest-docs]: https://developers.home-assistant.io/docs/en/creating_integration_manifest.html [quality-scale]: https://developers.home-assistant.io/docs/en/next/integration_quality_scale_index.html [docs-repository]: https://github.com/home-assistant/home-assistant.io

petro · October 26, 2022, 9:28pm

You can now set percentage and preset mode at the same time to gain high medium and low as well as percentages. Also there’s no assumed on state when the associated services are called.