idan37s
(Idan Slonimsky)
September 30, 2022, 12:42pm
1
“Template condition” name should include also the actual jinja2 template in the name so we don’t have to open it to see what’s inside,
And “Trigger condition” name should include the trigger_id
thomasloven
(Thomas Lovén)
September 30, 2022, 12:47pm
2
The template condition could be hundreds of lines long…
The trigger condition though… yes.
1 Like
frenck
(Franck Nijhof)
September 30, 2022, 12:52pm
3
The trigger condition could indeed be better
The template condition is really not possible. We can’t describe a template. However, you can click the three dots menu of that condition and rename it to something more descriptive.
…/Frenck
2 Likes
frenck
(Franck Nijhof)
October 1, 2022, 4:23pm
4
Voila:
PR in our codebase that adds it:
home-assistant:dev
← home-assistant:frenck-2022-1875
opened 04:23PM - 01 Oct 22 UTC
<!--
You are amazing! Thanks for contributing to our project!
Please, DO N… OT DELETE ANY TEXT from this template! (unless instructed).
-->
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
or resolves a feature request, be sure to link to that issue or discussion
in the additional information section.
-->
The trigger condition currently doesn't have a description. This PR adds that.
WTH Topic: https://community.home-assistant.io/t/wth-template-condition-and-trigger-condition-in-automations-dont-include-a-more-detailed-name/467206
![CleanShot 2022-10-01 at 18 20 41](https://user-images.githubusercontent.com/195327/193418757-ad90f803-f5d2-467f-8fa7-9bd7dce479f1.png)
Also added to the gallery:
![CleanShot 2022-10-01 at 18 14 04](https://user-images.githubusercontent.com/195327/193418767-91b86681-6a68-4e19-aeb9-f77bcadd76e4.png)
## Type of change
<!--
What type of change does your PR introduce to the Home Assistant frontend?
NOTE: Please, check only 1! box!
If your PR requires multiple boxes to be checked, you'll most likely need to
split it into multiple PRs. This makes things easier and faster to code review.
-->
- [ ] Dependency upgrade
- [ ] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (thank you!)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
## Example configuration
<!--
Supplying a configuration snippet, makes it easier for a maintainer to test
your PR.
-->
```yaml
```
## Additional information
<!--
Details are important, and help maintainers processing your PR.
Please be sure to fill out additional details, if applicable.
-->
- This PR fixes or closes issue: fixes #
- This PR is related to issue or discussion:
- Link to documentation pull request:
## Checklist
<!--
Put an `x` in the boxes that apply. You can also fill these out after
creating the PR. If you're unsure about any of them, don't hesitate to ask.
We're here to help! This is simply a reminder of what we are going to look
for before merging your code.
-->
- [x] The code change is tested and works locally.
- [x] There is no commented out code in this PR.
- [ ] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated for [www.home-assistant.io][docs-repository]
<!--
Thank you for contributing <3
-->
[docs-repository]: https://github.com/home-assistant/home-assistant.io
4 Likes
idan37s
(Idan Slonimsky)
October 1, 2022, 8:01pm
6
Might be a stretch here, so feel free to ignore,
But just thought now that with this (awesome) change it would also be great if the trigger id itself would be added to the trigger detailed name it belongs to (only if it has trigger id).
WDY @frenck ?