The fact that the brand icons are hosted on a different server has a few issues:
It breaks offline use
It breaks due to heuristics in privacy-focussed add-ons such as Privacy Badger
It’s an external dependency
It enables the collection of anonymous usage statistics with no way to opt-out
I’d propose to either include all icons in each HA install or provide another frontend: option which allows the user to specify a custom icon server base URL.
Edit: Rephrased the issue since including all icons in the main HA install isn’t feasible in the long run.
The brands repo is almost 300 MB currently, and will only get significantly larger over time. Especially now that custom_component authors are putting stuff up there too.
That is (one of) the reasons they’re not included in the install.
When an integration is installed, is its logo cached locally (for display in Configuration > Integrations) or is it always retrieved from the central repository?
@tom_l Okay, I am probably misunderstanding your proposal because I don’t see how “download” and “offline use” go along.
@SeanM It is a bit of a different WTH but I think it is quite odd that custom_component icons must go to the official repo, that kinda defeats the purpose of a custom component.
@123 It is in principle always retrieved, but with some caching (edit: the caching setup is documented).
I don’t use them currently, but in skimming the forum I came across this thread and was surprised to find that brand icons introduce a cloud dependency.
I’d say a good proportion of HA users came here to get away from proprietary systems which require users to depend on some vendor’s cloud services. Granted, this isn’t a vendor in the traditional sense, but the same principles apply.
I can’t imagine why the needed icons couldn’t be loaded once and stored locally.
I’m now using this custom dockerfile to build my home assistant container:
Disclaimer
If you decide to replicate this and experience issues, please do not complain to the devs etc etc.
This is unsupported. Your own risk. May break in the future. Whatever
FROM homeassistant/home-assistant:0.117.4
RUN apk add gzip
RUN for i in $(find /usr/local/lib/python3.8/site-packages/hass_frontend/ -iname "*.js.gz"); do zcat $i | sed 's/https:\/\/brands.home-assistant.io/\/local\/brands/g' > "$i.copy"; gzip "$i.copy"; mv "$i.copy.gz" "$i" ; done
RUN for i in $(find /usr/local/lib/python3.8/site-packages/hass_frontend/ -iname "*.js"); do cat $i | sed 's/https:\/\/brands.home-assistant.io/\/local\/brands/g' > "$i.copy"; mv "$i.copy" "$i" ; done
With this, the frontend fetches its icons from /local/brands/ which works very well.
I just added a brands folder to my config/www directory and filled it with the latest build of the brands icons repo
These can be generated by running
git clone https://github.com/home-assistant/brands
cd brands
./scripts/build.sh
and will appear in the build folder.
It would be even nicer if the dockerfile could take care of that, but since I’m mapping my config directory into the container, this may lead to issues.