ArunGupta
(Arun Gupta)
January 20, 2024, 10:10pm
1
Updated HA to 2024.1.4 this morning and now YoLink has stopped working. The HA log is full of messages like this. Any idea how to fix it?
2024-01-20 08:29:43.957 ERROR (MainThread) [yolink.mqtt_client] yolink mqtt client disconnected!
2024-01-20 08:29:59.338 ERROR (MainThread) [yolink.mqtt_client] yolink mqtt client disconnected!
2024-01-20 08:30:14.415 ERROR (MainThread) [yolink.mqtt_client] yolink mqtt client disconnected!
2024-01-20 08:30:19.553 ERROR (MainThread) [yolink.mqtt_client] unexcept exception:
Traceback (most recent call last):
File "/usr/local/lib/python3.11/site-packages/yolink/mqtt_client.py", line 59, in _listen
async with client.messages() as messages:
^^^^^^^^^^^^^^^^^
TypeError: 'async_generator' object is not callable
2024-01-20 08:30:19.687 ERROR (MainThread) [yolink.mqtt_client] unexcept exception:
Traceback (most recent call last):
File "/usr/local/lib/python3.11/site-packages/yolink/mqtt_client.py", line 59, in _listen
async with client.messages() as messages:
^^^^^^^^^^^^^^^^^
TypeError: 'async_generator' object is not callable
2024-01-20 08:30:19.823 ERROR (MainThread) [yolink.mqtt_client] unexcept exception:
Traceback (most recent call last):
File "/usr/local/lib/python3.11/site-packages/yolink/mqtt_client.py", line 59, in _listen
async with client.messages() as messages:
^^^^^^^^^^^^^^^^^
Thanksā¦
1 Like
same error here on 2024.1.5
1 Like
ArunGupta
(Arun Gupta)
January 20, 2024, 10:53pm
3
Yes, just saw the 2024.1.5 update. Did the update and same error. YoLink devices are not working at all.
richard2
(Richard)
January 20, 2024, 11:30pm
4
Same here. 2024.1.4 broke YoLink for me. 2024.1.5 did not fix it
I should of came here first, just spent an hour trying to troubleshoot my HA & YoLink issues.
1 Like
man i wish I hadnāt believe the dev that was in here saying ālocal control coming with supportā. I only use it for one thing and thatās for my mailbox notification as itās too far for zwave. For now I just use the yolink app to notify me of mailbox movement.
1 Like
Yep, more BS. What a pain in the butt
1 Like
Same here, I took a debug log before reverting.
2024-01-20 08:29:43.957 ERROR (MainThread) [yolink.mqtt_client] yolink mqtt client disconnected!
2024-01-20 08:29:59.338 ERROR (MainThread) [yolink.mqtt_client] yolink mqtt client disconnected!
2024-01-20 08:30:14.415 ERROR (MainThread) [yolink.mqtt_client] yolink mqtt client disconnected!
2024-01-20 08:30:19.553 ERROR (MainThread) [yolink.mqtt_client] unexcept exception:
Traceback (most recent call last):
File "/usr/local/lib/python3.11/site-packages/yolink/mqtt_client.py", line 59, in _listen
async with client.messages() as messages:
^^^^^^^^^^^^^^^^^
TypeError: 'async_generator' object is not callable
2024-01-20 08:30:19.687 ERROR (MainThread) [yolink.mqtt_client] unexcept exception:
Traceback (most recent call last):
File "/usr/local/lib/python3.11/site-packages/yolink/mqtt_client.py", line 59, in _listen
async with client.messages() as messages:
^^^^^^^^^^^^^^^^^
TypeError: 'async_generator' object is not callable
2024-01-20 08:30:19.823 ERROR (MainThread) [yolink.mqtt_client] unexcept exception:
Traceback (most recent call last):
File "/usr/local/lib/python3.11/site-packages/yolink/mqtt_client.py", line 59, in _listen
async with client.messages() as messages:
^^^^^^^^^^^^^^^^^
This fix is underway but as of now not yet merged in:
home-assistant:dev
ā YoSmart-Inc:fix_mqtt_connection
opened 04:06AM - 21 Jan 24 UTC
<!--
You are amazing! Thanks for contributing to our project!
Please, DO Nā¦ OT DELETE ANY TEXT from this template! (unless instructed).
-->
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
or resolves a feature request, be sure to link to that issue in the
additional information section.
-->
Fix aiomqtt breaking changes
https://github.com/YoSmart-Inc/yolink-api/compare/v0.3.4...v0.3.6
## Type of change
<!--
What type of change does your PR introduce to Home Assistant?
NOTE: Please, check only 1! box!
If your PR requires multiple boxes to be checked, you'll most likely need to
split it into multiple PRs. This makes things easier and faster to code review.
-->
- [x] Dependency upgrade
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [ ] New feature (which adds functionality to an existing integration)
- [ ] Deprecation (breaking change to happen in the future)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
## Additional information
<!--
Details are important, and help maintainers processing your PR.
Please be sure to fill out additional details, if applicable.
-->
- This PR fixes or closes issue: fixes # https://github.com/home-assistant/core/issues/108492 https://github.com/home-assistant/core/issues/108518 https://github.com/home-assistant/core/issues/108459 https://github.com/home-assistant/core/issues/108520
- This PR is related to issue:
- Link to documentation pull request:
## Checklist
<!--
Put an `x` in the boxes that apply. You can also fill these out after
creating the PR. If you're unsure about any of them, don't hesitate to ask.
We're here to help! This is simply a reminder of what we are going to look
for before merging your code.
-->
- [x] The code change is tested and works locally.
- [x] Local tests pass. **Your PR cannot be merged unless tests pass**
- [x] There is no commented out code in this PR.
- [x] I have followed the [development checklist][dev-checklist]
- [x] I have followed the [perfect PR recommendations][perfect-pr]
- [x] The code has been formatted using Ruff (`ruff format homeassistant tests`)
- [x] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated for [www.home-assistant.io][docs-repository]
If the code communicates with devices, web services, or third-party tools:
- [x] The [manifest file][manifest-docs] has all fields filled out correctly.
Updated and included derived files by running: `python3 -m script.hassfest`.
- [x] New or updated dependencies have been added to `requirements_all.txt`.
Updated by running `python3 -m script.gen_requirements_all`.
- [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
- [ ] Untested files have been added to `.coveragerc`.
<!--
This project is very active and we have a high turnover of pull requests.
Unfortunately, the number of incoming pull requests is higher than what our
reviewers can review and merge so there is a long backlog of pull requests
waiting for review. You can help here!
By reviewing another pull request, you will help raise the code quality of
that pull request and the final review will be faster. This way the general
pace of pull request reviews will go up and your wait time will go down.
When picking a pull request to review, try to choose one that hasn't yet
been reviewed.
Thanks for helping out!
-->
To help with the load of incoming pull requests:
- [ ] I have reviewed two other [open pull requests][prs] in this repository.
[prs]: https://github.com/home-assistant/core/pulls?q=is%3Aopen+is%3Apr+-author%3A%40me+-draft%3Atrue+-label%3Awaiting-for-upstream+sort%3Acreated-desc+review%3Anone+-status%3Afailure
<!--
Thank you for contributing <3
Below, some useful links you could explore:
-->
[dev-checklist]: https://developers.home-assistant.io/docs/development_checklist/
[manifest-docs]: https://developers.home-assistant.io/docs/creating_integration_manifest/
[quality-scale]: https://developers.home-assistant.io/docs/integration_quality_scale_index/
[docs-repository]: https://github.com/home-assistant/home-assistant.io
[perfect-pr]: https://developers.home-assistant.io/docs/review-process/#creating-the-perfect-pr
4 Likes
ArunGupta
(Arun Gupta)
January 26, 2024, 3:44am
10
Five days go by and no fix.
1 Like
Even worse is that the fix on GitHub is done but not yet approved and may not make the next release.
I ended up downgrading to 2023.1.3 so that YoLink will work. Not the best solution, but I use quite a few YoLink devices so my house was a little broken.
1 Like
It is approved - just wondering when 2014.1.6 will drop - (hopefully it is in there) - is there a way to find out?
Sorry, what I meant to say is that it is still marked as āOpenā. Not sure if it will be included in 2024.1.6 if it is still open. All of the other issues earmarked for 2024.1.6 are marked as Closed.
It could just be my lack of understanding on how GitHub handles this.
Yep, I had to do the same thing myself.
I have asked the developer to escalate if he had such channels
1 Like
mrechs
(Matthew Rechs)
January 29, 2024, 12:05am
17
This is such a bummer. The Yolink integration with my home security system literally saved our asses a couple weeks ago. I wonāt be able to sleep knowing weāre vulnerable.
https://www.reddit.com/r/homeassistant/comments/199ii97/attempted_burglary_thwarted_by_ha/
Well, just keep it at 2024.1.3 until 2024.1.6 drops
ArunGupta
(Arun Gupta)
January 29, 2024, 2:30am
19
Lesson learned. Never use HA for security. Any integration can break and it can take days/weeks before it is fixed. HA should only be used for non-critical things for which there is a workaround available.
1 Like
I think thatās the nature of how fast things change with open sourceā¦ also there are questions as to why there was such a delay because the Yolink developer finished with his testing and issued a PR which was approvedā¦ Also, always make a backup before any update then update and test as appropriate if you find a problem, try to resolve it (if config), otherwise roll back and issue a ticket
The delay for this version could be that there are a huge number of changs coming with the next drop and they are doing extra testingā¦
It can be annoying but it does mprove very quickly, soimetimes they issue a release the next day after the previous oneā¦ I understand how a lot of people are willing to put up with it because this is kind of a tool for tinkerersā¦ Some people test it until itās pretty bulletproof and then donāt bother upgrading less thereās really a need toā¦