Jmi
(Jean-Michel)
February 4, 2021, 10:14am
1
Hello,
I’ve migrated yesterday on ZWave JS. I have 8 cover, and following the migration, 1 of them is no more working correctly.
I have this message in the interface, while using the buggin to open/close them "Failed to call service cover/close_cover. None"
And in the logs, I have this:
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 136, in handle_call_service
await hass.services.async_call(
File "/usr/src/homeassistant/homeassistant/core.py", line 1455, in async_call
task.result()
File "/usr/src/homeassistant/homeassistant/core.py", line 1490, in _execute_service
await handler.job.target(service_call)
File "/usr/src/homeassistant/homeassistant/helpers/entity_component.py", line 204, in handle_service
await self.hass.helpers.service.entity_service_call(
File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 595, in entity_service_call
future.result() # pop exception if have
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 664, in async_request_call
await coro
File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 632, in _handle_entity_call
await result
File "/usr/src/homeassistant/homeassistant/components/zwave_js/cover.py", line 88, in async_close_cover
await self.info.node.async_set_value(target_value, PRESS_BUTTON)
File "/usr/local/lib/python3.8/site-packages/zwave_js_server/model/node.py", line 248, in async_set_value
val = self.values[val]
KeyError: None
All others covers are working fine. Do you have any idea on what could be done ?
1 Like
Ascari
(Arancio)
February 4, 2021, 12:02pm
2
I have the same issue.
Try Remove/Add Node but always the same
lelepando
(Lelepando)
February 5, 2021, 9:51am
3
I’m experiencing the same problem with a qubino flush shutter… I hope someone can shed a light on this…
Ascari
(Arancio)
February 5, 2021, 10:00am
4
lelepando:
hed a light on this…
A lot of issues open on Github for this problem.
Hope a solution fast, Zwave JS is a good integration but need more time to be really the top.
Fixed
home-assistant:dev
← natekspencer:issue-45922
opened 09:00AM - 04 Feb 21 UTC
<!--
You are amazing! Thanks for contributing to our project!
Please, DO N… OT DELETE ANY TEXT from this template! (unless instructed).
-->
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
or resolves a feature request, be sure to link to that issue in the
additional information section.
-->
Fixes bug with zwave_js integration for control of covers when the target_value of Open/Close does not exist, but Up/Down does
## Type of change
<!--
What type of change does your PR introduce to Home Assistant?
NOTE: Please, check only 1! box!
If your PR requires multiple boxes to be checked, you'll most likely need to
split it into multiple PRs. This makes things easier and faster to code review.
-->
- [ ] Dependency upgrade
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [ ] New feature (which adds functionality to an existing integration)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
## Additional information
<!--
Details are important, and help maintainers processing your PR.
Please be sure to fill out additional details, if applicable.
-->
- This PR fixes or closes issue: fixes # https://github.com/home-assistant/core/issues/45922
- This PR is related to issue: https://github.com/home-assistant/core/issues/45922
- Link to documentation pull request:
## Checklist
<!--
Put an `x` in the boxes that apply. You can also fill these out after
creating the PR. If you're unsure about any of them, don't hesitate to ask.
We're here to help! This is simply a reminder of what we are going to look
for before merging your code.
-->
- [x] The code change is tested and works locally.
- [x] Local tests pass. **Your PR cannot be merged unless tests pass**
- [x] There is no commented out code in this PR.
- [x] I have followed the [development checklist][dev-checklist]
- [x] The code has been formatted using Black (`black --fast homeassistant tests`)
- [ ] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated for [www.home-assistant.io][docs-repository]
If the code communicates with devices, web services, or third-party tools:
- [ ] The [manifest file][manifest-docs] has all fields filled out correctly.
Updated and included derived files by running: `python3 -m script.hassfest`.
- [ ] New or updated dependencies have been added to `requirements_all.txt`.
Updated by running `python3 -m script.gen_requirements_all`.
- [ ] Untested files have been added to `.coveragerc`.
The integration reached or maintains the following [Integration Quality Scale][quality-scale]:
<!--
The Integration Quality Scale scores an integration on the code quality
and user experience. Each level of the quality scale consists of a list
of requirements. We highly recommend getting your integration scored!
-->
- [ ] No score or internal
- [ ] 🥈 Silver
- [ ] 🥇 Gold
- [ ] 🏆 Platinum
<!--
This project is very active and we have a high turnover of pull requests.
Unfortunately, the number of incoming pull requests is higher than what our
reviewers can review and merge so there is a long backlog of pull requests
waiting for review. You can help here!
By reviewing another pull request, you will help raise the code quality of
that pull request and the final review will be faster. This way the general
pace of pull request reviews will go up and your wait time will go down.
When picking a pull request to review, try to choose one that hasn't yet
been reviewed.
Thanks for helping out!
-->
To help with the load of incoming pull requests:
- [ ] I have reviewed two other [open pull requests][prs] in this repository.
[prs]: https://github.com/home-assistant/core/pulls?q=is%3Aopen+is%3Apr+-author%3A%40me+-draft%3Atrue+-label%3Awaiting-for-upstream+sort%3Acreated-desc+review%3Anone
<!--
Thank you for contributing <3
Below, some useful links you could explore:
-->
[dev-checklist]: https://developers.home-assistant.io/docs/en/development_checklist.html
[manifest-docs]: https://developers.home-assistant.io/docs/en/creating_integration_manifest.html
[quality-scale]: https://developers.home-assistant.io/docs/en/next/integration_quality_scale_index.html
[docs-repository]: https://github.com/home-assistant/home-assistant.io
Jmi
(Jean-Michel)
February 5, 2021, 10:07am
5
Yes, fixed
Just a few days ? hours ? to wait to have it released
lelepando
(Lelepando)
February 5, 2021, 10:13am
6
Great! let’s wait for the roll-out!
Jmi
(Jean-Michel)
February 5, 2021, 1:35pm
7
Not in 2021.2.1. It will be in 2021.2.2
1 Like
will there be an invert option for covers (I got a Fibaro Roller Shutter 2 : FGR-222) on the ZwaveJS like following could be done in the configuration.yaml
invert_openclose_buttons: true
invert_percent: true
2 Likes
Ascari
(Arancio)
February 6, 2021, 11:28am
9
I hope I have one also, if not I change my wire cable but more easy with parameters