2022.4: Groups! Groups! Groups!

petro · April 14, 2022, 12:03pm

Yes, but we are also speaking about 2 different issues here. All of the issues i’ve read about so far aside from your event issue are related to the entire network dying. I assumed this is what you were talking about. I was wrong for assuming that, however that’s the issue I was referencing. Which, from what I can tell is 100% related to conbee II sticks.

petro · April 14, 2022, 12:07pm

Anyways, it appears as if that was a bug which is why it wasn’t listed as a breaking change. It’s already fixed

~~Not sure when it will be delivered.~~ It was delivered in 2022.4.1

EDIT: Here’s a link to the PR, not the actual change

github.com/home-assistant/core

Move new `zha_event` command parameters into a `params` key to ensure backwards compatibility

home-assistant:dev ← puddly:puddly/command-schema-compat

opened 10:13PM - 07 Apr 22 UTC

puddly

+27 -2

## Breaking change  No. ## Proposed change  A recent ZHA dependency upgrade (https://github.com/home-assistant/core/pull/68921) changed zigpy's response type to a `list`-compatible object that had attached type schemas. While the responses superficially worked, they caused problems with some types of comparisons. This change brings back the old behavior of keeping ZHA event data in a `list` object while migrating named ZHA event parameters into a new key: ```diff { "event_type": "zha_event", "data": { "device_ieee": "90:fd:9f:ff:fe:fe:d8:a1", "unique_id": "90:fd:9f:ff:fe:fe:d8:a1:1:0x0008", "device_id": "51e3449d17f2fd47abebd16b6721d470", "endpoint_id": 1, "cluster_id": 8, "command": "step_with_on_off", "args": [ 0, 43, 5 ], + "params": { + "step_mode": 0, + "step_size": 43, + "transition_time": 5 + } }, "origin": "LOCAL", "time_fired": "2022-04-07T17:55:49.966102+00:00", "context": { "id": "a92cda22a798ea82c6d0b7c7e4500dd9", "parent_id": null, "user_id": null } } ``` If you feel this new `params` key should be split off into a separate PR, let me know. ## Type of change  - [ ] Dependency upgrade - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New integration (thank you!) - [ ] New feature (which adds functionality to an existing integration) - [ ] Breaking change (fix/feature causing existing functionality to break) - [ ] Code quality improvements to existing code or addition of tests ## Additional information  - This PR fixes or closes issue: fixes #69626 - This PR is related to issue: #69498, #69375 - Link to documentation pull request: ## Checklist  - [x] The code change is tested and works locally. - [x] Local tests pass. **Your PR cannot be merged unless tests pass** - [x] There is no commented out code in this PR. - [x] I have followed the [development checklist][dev-checklist] - [x] The code has been formatted using Black (`black --fast homeassistant tests`) - [x] Tests have been added to verify that the new code works. If user exposed functionality or configuration variables are added/changed: - [ ] Documentation added/updated for [www.home-assistant.io][docs-repository] If the code communicates with devices, web services, or third-party tools: - [ ] The [manifest file][manifest-docs] has all fields filled out correctly. Updated and included derived files by running: `python3 -m script.hassfest`. - [ ] New or updated dependencies have been added to `requirements_all.txt`. Updated by running `python3 -m script.gen_requirements_all`. - [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description. - [ ] Untested files have been added to `.coveragerc`. The integration reached or maintains the following [Integration Quality Scale][quality-scale]:  - [ ] No score or internal - [ ] 🥈 Silver - [ ] 🥇 Gold - [ ] 🏆 Platinum  To help with the load of incoming pull requests: - [ ] I have reviewed two other [open pull requests][prs] in this repository. [prs]: https://github.com/home-assistant/core/pulls?q=is%3Aopen+is%3Apr+-author%3A%40me+-draft%3Atrue+-label%3Awaiting-for-upstream+sort%3Acreated-desc+review%3Anone+-status%3Afailure  [dev-checklist]: https://developers.home-assistant.io/docs/en/development_checklist.html [manifest-docs]: https://developers.home-assistant.io/docs/en/creating_integration_manifest.html [quality-scale]: https://developers.home-assistant.io/docs/en/next/integration_quality_scale_index.html [docs-repository]: https://github.com/home-assistant/home-assistant.io

Hellis81 · April 14, 2022, 12:12pm

Reading the comments, there still seems to be issues.
And just after people voice these issues the discussion is locked.
…

Move new zha_event command parameters into a params key to ensure backwards compatibility by puddly · Pull Request #69631 · home-assistant/core (github.com)

petro · April 14, 2022, 12:14pm

That’s an autobot locking the PR because it was merged. There isn’t some conspiracy. If it breaks something, then an issue should be written up.

petro · April 14, 2022, 12:15pm

Let me say this loud and clear: The devs are not out to make your life miserable. They are trying to provide fixes, enhancements, and updates. Sometimes breaking changes due to bugs squeak through.

CaptTom · April 14, 2022, 12:21pm

Part of the problem here is the definition of breaking change. It does not mean “a change which caused something to break.” It does not include what the rest of us would call a bug.

In the HA world, “breaking change” means a change which was designed in advance to require that the user make some sort of re-configuration or adjustment, or things will break.

There is definitely something going on with Zigbee and ZHA in release 2022.4. I’m watching 7 issues and 9 pull requests on Github. Granted, I can’t comprehend most of them, but it does signify a lot of activity.

At this point it might not be a bad strategy to wait for the dust to settle a bit before updating to 2022.4. It’s frustrating. I like to be up-to-date. But I have confidence our best people are on it!

petro · April 14, 2022, 12:22pm

It seems like puddly (Assuming that’s the main dev as he has the most activity everywhere) is working pretty hard at whatever changed.

Hellis81 · April 14, 2022, 12:50pm

I’m not saying anyone is doing some conspiracy.

All I’m saying there is some change in the latest version that breaks the control of ZigBee devices when used with ZHA.
If this change should be called bug, change or whatever.
I’m very grateful Puddly is working on it. Thank you! I really mean it.

I understand this could be hard to maintain, but when it’s these large integrations, perhaps a “after the release notice” should be posted in the blog saying we found this bug.
I can understand there are many that read the release notes and found nothing “harmful” and didn’t bother to read the following hundreds of posts before this was noted.

petro · April 14, 2022, 12:57pm

Every integration has a known bug list. You can access that list through home assistant on the integration itself or in the documents in the integration list.

If the bug isn’t found in that list, that means no one found it.

Also, you can get to the docs & issues via this link provided in the release notes:

bschatzow · April 14, 2022, 5:35pm

How do you get the latest beta version that you show in your card?

chemgeek · April 14, 2022, 5:57pm

This ZHA bug, unfortunately, degraded a bit of my confidence that had been building over the last year. I had gone a good year or more without a nuclear update. Oh well.

Hellis81 · April 14, 2022, 6:45pm

I haven’t even tried the latest version.
Too much that can go wrong that I don’t want to try.

Nick4 · April 14, 2022, 8:19pm

Thanks a lot, again, guys for this release and the quick fix of the memory leak!

jdggit · April 15, 2022, 1:09am

Something in 2022.4.x has changed such that the first condition of this ZHA-Zigbee blueprint (ZHA - Lutron Connected Bulb Remote) continues to work, but the second condition fails. The blueprint works fine with 2022.3 and before. I’ve read that changes have been made regarding “args” in the Zigbee, but I’m out of my depth trying to debug the blueprint. All I can see different it there’s one more parameter in the “args” for the second condition

choose:
- conditions:
  - ‘{{ command == ‘‘move_to_level_with_on_off’’ }}’
  - ‘{{ cluster_id == 8 }}’
  - ‘{{ endpoint_id == 1 }}’
  - ‘{{ args == [254, 4] }}’
    sequence:
  - type: toggle -------------------------------->> WORKS
    device_id: d5762dc844931556d70b0e7c249c2209
    entity_id: light.office_strata_lamp
    domain: light
- conditions:
  - ‘{{ command == ‘‘step_with_on_off’’ }}’
  - ‘{{ cluster_id == 8 }}’
  - ‘{{ endpoint_id == 1 }}’
  - ‘{{ args == [0, 30, 6] }}’
    sequence:
  - service: fan.increase_speed ------------------->> FAILS
    target:
    device_id: 1a3db7315e7609c488d49e79b21303a6

Looking for suggestions on how to fix this. Thanks

nickrout · April 15, 2022, 1:12am

What is that supposed to be? Please post the code properly.

Hellis81 · April 15, 2022, 3:59am

You need to look at the events tool in developer tools and listen for zha event.
What happens as you press the button?

cdrom1028 · April 15, 2022, 4:00am

@jdggit please repost working and non-working code snippets separately using the Preformatted text button </> . You can do this in one post with descriptions of each snippet and the issue you are having. This way more people can read and understand your automation.

jdggit · April 15, 2022, 4:00am

Thanks for taking a look at this. Here’s the full blueprint. The problems started with 2022.4.x on button 2 and 3. Buttons 1 and 4 work as they always have with 2022.3. and before. the new Core release doesn’t like something in here that was working before.

ZHA - Lutron Connected Bulb Remote

blueprint:
  name: ZHA - Lutron Connected Bulb Remote
  description: Control anything using Lutron Connected Bulb Remote

  domain: automation
  input:
    remote:
      name: Remote
      description: Lutron Connected Bulb Remote to use
      selector:
        device:
          integration: zha
#         manufacturer: Lutron
          model: LZL4BWHL01 Remote
    button_1:
      name: Button 1 press
      description: Action to run on press of button 1 (On)
      default: []
      selector:
        action:
    button_2:
      name: Button 2 press
      description: Action to run on press of button 2 (Dim Up)
      default: []
      selector:
        action:
    button_3:
      name: Button 3 press
      description: Action to run on press of button 3 (Dim Down)
      default: []
      selector:
        action:
    button_4:
      name: Button 4 press
      description: Action to run on press of button 4 (Off)
      default: []
      selector:
        action:

mode: restart
max_exceeded: silent

trigger:
  - platform: event
    event_type: zha_event
    event_data:
      device_id: !input remote

action:
  - variables:
      command: "{{ trigger.event.data.command }}"
      cluster_id: "{{ trigger.event.data.cluster_id }}"
      endpoint_id: "{{ trigger.event.data.endpoint_id }}"
      args: "{{ trigger.event.data.args }}"
  - choose:
      - conditions:
          - "{{ command == 'move_to_level_with_on_off' }}"
          - "{{ cluster_id == 8 }}"
          - "{{ endpoint_id == 1 }}"
          - "{{ args == [254, 4] }}"
        sequence: !input button_1

      - conditions:
          - "{{ command == 'step_with_on_off' }}"
          - "{{ cluster_id == 8 }}"
          - "{{ endpoint_id == 1 }}"
          - "{{ args == [0, 30, 6] }}"
        sequence: !input button_2

      - conditions:
          - "{{ command == 'step' }}"
          - "{{ cluster_id == 8 }}"
          - "{{ endpoint_id == 1 }}"
          - "{{ args == [1, 30, 6] }}"
        sequence: !input button_3

      - conditions:
          - "{{ command == 'move_to_level_with_on_off' }}"
          - "{{ cluster_id == 8 }}"
          - "{{ endpoint_id == 1 }}"
          - "{{ args == [0, 4] }}"
        sequence: !input button_4

wklink · April 15, 2022, 4:32am

Just updated to 2022.4.4 and now my climacell (tomorrow.io) forecast is in metric. I’m in the US and everything else is set to imperial units.

bjorn.sivertsen · April 15, 2022, 5:20am

2022.4 changed the messages that are sent by a lot of controllers through ZHA, breaking previously working blueprints. The blueprint exchange is full of issues like yours. I had the same issue with the Hue dimmer.

Bit of a shame it wasn’t listed as a breaking change.

My suggestion is to find a blueprint that has been updated to account for the changed messages, or write the Blueprint creator and let them know it’s due for an update.