petro
(Petro)
April 6, 2023, 12:35am
61
That never existed in core. Custom only.
nickrout
(Nick Rout)
April 6, 2023, 12:49am
62
Yes it is frustrating that custom card developers do not keep up and fix their cards. It happens release after release. Goddamn slackers.
3 Likes
diplix
(felix schwenzel)
April 6, 2023, 12:50am
63
there is a regression in command line sensors and also a quick fix suggested:
home-assistant:dev
← gadgetchnnel:command-line-value-template
opened 06:37PM - 31 Mar 23 UTC
<!--
You are amazing! Thanks for contributing to our project!
Please, DO N… OT DELETE ANY TEXT from this template! (unless instructed).
-->
## Breaking change
<!--
If your PR contains a breaking change for existing users, it is important
to tell them what breaks, how to make it work again and why we did this.
This piece of text is published with the release notes, so it helps if you
write it towards our users, not us.
Note: Remove this section if this PR is NOT a breaking change.
-->
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
or resolves a feature request, be sure to link to that issue in the
additional information section.
-->
PR #90268 introduced a regression in the command_line sensor, where value_template was only being considered if json_attributes is not configured. This resolves this.
## Type of change
<!--
What type of change does your PR introduce to Home Assistant?
NOTE: Please, check only 1! box!
If your PR requires multiple boxes to be checked, you'll most likely need to
split it into multiple PRs. This makes things easier and faster to code review.
-->
- [ ] Dependency upgrade
- [X] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [ ] New feature (which adds functionality to an existing integration)
- [ ] Deprecation (breaking change to happen in the future)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
## Additional information
<!--
Details are important, and help maintainers processing your PR.
Please be sure to fill out additional details, if applicable.
-->
- This PR fixes or closes issue: fixes #90596
- This PR is related to issue:
- Link to documentation pull request:
## Checklist
<!--
Put an `x` in the boxes that apply. You can also fill these out after
creating the PR. If you're unsure about any of them, don't hesitate to ask.
We're here to help! This is simply a reminder of what we are going to look
for before merging your code.
-->
- [X] The code change is tested and works locally.
- [X] Local tests pass. **Your PR cannot be merged unless tests pass**
- [X] There is no commented out code in this PR.
- [X] I have followed the [development checklist][dev-checklist]
- [X] I have followed the [perfect PR recommendations][perfect-pr]
- [X] The code has been formatted using Black (`black --fast homeassistant tests`)
- [ ] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated for [www.home-assistant.io][docs-repository]
If the code communicates with devices, web services, or third-party tools:
- [ ] The [manifest file][manifest-docs] has all fields filled out correctly.
Updated and included derived files by running: `python3 -m script.hassfest`.
- [ ] New or updated dependencies have been added to `requirements_all.txt`.
Updated by running `python3 -m script.gen_requirements_all`.
- [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
- [ ] Untested files have been added to `.coveragerc`.
<!--
This project is very active and we have a high turnover of pull requests.
Unfortunately, the number of incoming pull requests is higher than what our
reviewers can review and merge so there is a long backlog of pull requests
waiting for review. You can help here!
By reviewing another pull request, you will help raise the code quality of
that pull request and the final review will be faster. This way the general
pace of pull request reviews will go up and your wait time will go down.
When picking a pull request to review, try to choose one that hasn't yet
been reviewed.
Thanks for helping out!
-->
To help with the load of incoming pull requests:
- [ ] I have reviewed two other [open pull requests][prs] in this repository.
[prs]: https://github.com/home-assistant/core/pulls?q=is%3Aopen+is%3Apr+-author%3A%40me+-draft%3Atrue+-label%3Awaiting-for-upstream+sort%3Acreated-desc+review%3Anone+-status%3Afailure
<!--
Thank you for contributing <3
Below, some useful links you could explore:
-->
[dev-checklist]: https://developers.home-assistant.io/docs/en/development_checklist.html
[manifest-docs]: https://developers.home-assistant.io/docs/en/creating_integration_manifest.html
[quality-scale]: https://developers.home-assistant.io/docs/en/next/integration_quality_scale_index.html
[docs-repository]: https://github.com/home-assistant/home-assistant.io
[perfect-pr]: https://developers.home-assistant.io/docs/review-process/#creating-the-perfect-pr
the fix works for me (command line sensor states are generated again and not unknown
) but the PR was rejected (or rather a completly different implementation was suggested).
i worked around this by copying homeassistant/components/command_line
to custom_components
and changing line 141 in sensor.py
as suggested until there is a fix.
njs75
(Nathan)
April 6, 2023, 1:00am
64
Thanks for the reply-- but in what context? I am running HA in docker-compose… Wouldn’t this just be included in the image?
bdraco
(J. Nick Koston)
April 6, 2023, 1:04am
65
Yes it should be, but you might have a custom component that is pinning it to an older version
petro
(Petro)
Split this topic
April 6, 2023, 1:45am
66
15 posts were split to a new topic: Yaml Custom UI tangent
njs75
(Nathan)
April 6, 2023, 1:08am
70
Ah ok. Any idea what I might look for to identify the offending custom component? I’m a Java developer-- my python-foo is weak
SteveDinn
(Steve Dinn)
April 6, 2023, 1:29am
74
It seems like it’s consistently “migrating states context_ids” and “migrating entity_ids”
Is this behaviour to be expected in a normal database upgrade?
app_1 | 2023-04-05 22:24:14.475 DEBUG (Recorder) [homeassistant.components.recorder.core] Processing task: StatesContextIDMigrationTask()
app_1 | 2023-04-05 22:24:14.475 DEBUG (Recorder) [homeassistant.components.recorder.migration] Migrating states context_ids to binary format
app_1 | 2023-04-05 22:24:14.922 DEBUG (Recorder) [homeassistant.components.recorder.migration] Migrating states context_ids to binary format: done=False
app_1 | 2023-04-05 22:24:14.922 DEBUG (Recorder) [homeassistant.components.recorder.core] Processing task: EntityIDMigrationTask()
app_1 | 2023-04-05 22:24:14.923 DEBUG (Recorder) [homeassistant.components.recorder.migration] Migrating entity_ids
app_1 | 2023-04-05 22:24:15.383 DEBUG (Recorder) [homeassistant.components.recorder.migration] Migrating entity_ids done=False
app_1 | 2023-04-05 22:24:15.383 DEBUG (Recorder) [homeassistant.components.recorder.core] Processing task: StatesContextIDMigrationTask()
app_1 | 2023-04-05 22:24:15.383 DEBUG (Recorder) [homeassistant.components.recorder.migration] Migrating states context_ids to binary format
app_1 | 2023-04-05 22:24:15.800 DEBUG (Recorder) [homeassistant.components.recorder.migration] Migrating states context_ids to binary format: done=False
app_1 | 2023-04-05 22:24:15.801 DEBUG (Recorder) [homeassistant.components.recorder.core] Processing task: EntityIDMigrationTask()
app_1 | 2023-04-05 22:24:15.801 DEBUG (Recorder) [homeassistant.components.recorder.migration] Migrating entity_ids
bdraco
(J. Nick Koston)
April 6, 2023, 1:50am
79
Yes its doing them in batches to avoid overloading the system. Its slower but it allows for online migration. I expect you have a very large database (or slow disk). I’d let it run overnight and check it in the morning.
1 Like
Tile card feature development is agonizingly slow. The front end needs to mature way faster in general. The fact that I need custom button card and card mod for most UI tweaks is crazy. Why can’t I have a tile card that slides vertically? The popup UI has it, so wth? Why can’t I just not have an icon in tile card? Why can’t I change the width of sliders with a simple parameter change vs card mod? Why can’t I just…use the slider UI without all the extras, for that matter?
2 Likes
So all in all, how to hide top bar on both web and Android companion app? I used to use minimalist-mobile theme, but today it broke, which is even worse for my LG clock 2 devices, where top bar eats 20% of space.
Looks like no one of HA devs uses any mods at all.
SteveDinn
(Steve Dinn)
April 6, 2023, 2:15am
83
Yeah, my database is about 11Gb. Since the migration notification went away, I thought I could have expected that it would be completely finished. I guess I’ll just wait and see.
The update appears to have broken the mobile left-edge swipe-in gesture for expanding collapsed sidebar nav menu. Super hoping this is a temporary feature loss with the complete removal of polymer?
The HA header is hidden on all of our mobile phones (along with sidebar expand menu button in the header). Since there is no happy medium between the mutually exclusive choice of a dashboard view title or icon button, and anyway the hass-swipe-navigation is so much better for phones.
francisp
(Francis)
April 6, 2023, 3:00am
86
Nice release. Upgrading from the beta now.
Proche72
(Jiri Pragr)
April 6, 2023, 3:11am
87
Same here. Mine is also now covering rest of the cards
2 Likes
What do you use to hide top bar?
I use mushroom menu chip to open menu BTW.
Eoin
(eoin)
April 6, 2023, 3:18am
89
Thank you team for another great update! I was affected by the Kiosk Mode custom component but luckily that was a 1min fix, other than that flawless!
I have around 20% memory usage drop on RPI3 with this release, thank you!
3 Likes