MorrisB
March 29, 2022, 12:25pm
213
Any way i can enable debug so i can search through the logs ?
formatBCE
(Andrii)
March 29, 2022, 1:06pm
214
You cannot do it via Home Assistant. If it’s not supported by integration, you won’t see any logs.
To check working with pyvesync, please refer to pyvesync library Git README.
baz123
(Brian)
March 30, 2022, 1:52pm
215
There is a PR running that will hopefully mean that the HA integration will support any device defined in the pyvesync
library. Title of the PR is a little misleading…
home-assistant:dev
← jspayd:vesync-humidifier
opened 03:01AM - 28 Dec 21 UTC
<!--
You are amazing! Thanks for contributing to our project!
Please, DO N… OT DELETE ANY TEXT from this template! (unless instructed).
-->
## Breaking change
<!--
If your PR contains a breaking change for existing users, it is important
to tell them what breaks, how to make it work again and why we did this.
This piece of text is published with the release notes, so it helps if you
write it towards our users, not us.
Note: Remove this section if this PR is NOT a breaking change.
-->
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
or resolves a feature request, be sure to link to that issue in the
additional information section.
-->
- Integrates VeSync Classic300S humidifiers
- Most of this should work for the Classic200S as well, but due to a bug in pyvesync, the Classic200S are undiscoverable at the moment (see https://github.com/webdjoe/pyvesync/issues/102). Once that is fixed, adding "Classic200S" in all the same places as the "Classic300S" string should be sufficient. I can test and put up an additional PR when that happens. The bug is fixed in the master branch of pyvesync, so hopefully it won't be too long before there's a new release.
- Upgrades pyvesync to version 1.4.2. Changelog:
> Adding support for the Core300S air purifier and fix Azure Pipelines (https://github.com/webdjoe/pyvesync/releases/tag/1.4.2)
- The changelog message is not very descriptive, but the reason I upgrade to pyvesync 1.4.2 is to access the `night_light` attribute of the humidifier class, which indicates whether the humidifier has a night light. My use of this attribute makes my above statement about the Classic200S humidifiers true.
## Type of change
<!--
What type of change does your PR introduce to Home Assistant?
NOTE: Please, check only 1! box!
If your PR requires multiple boxes to be checked, you'll most likely need to
split it into multiple PRs. This makes things easier and faster to code review.
-->
- [x] Dependency upgrade
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [x] New feature (which adds functionality to an existing integration)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
## Additional information
<!--
Details are important, and help maintainers processing your PR.
Please be sure to fill out additional details, if applicable.
-->
- This PR fixes or closes issue: fixes #
- This PR is related to issue: https://github.com/home-assistant/core/issues/44865 (closed, but only due to inactivity)
- Link to documentation pull request:
## Checklist
<!--
Put an `x` in the boxes that apply. You can also fill these out after
creating the PR. If you're unsure about any of them, don't hesitate to ask.
We're here to help! This is simply a reminder of what we are going to look
for before merging your code.
-->
- [x] The code change is tested and works locally.
- [x] Local tests pass. **Your PR cannot be merged unless tests pass**
- [x] There is no commented out code in this PR.
- [x] I have followed the [development checklist][dev-checklist]
- [x] The code has been formatted using Black (`black --fast homeassistant tests`)
- [ ] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [x] Documentation added/updated for [www.home-assistant.io][docs-repository]: https://github.com/home-assistant/home-assistant.io/pull/20901
If the code communicates with devices, web services, or third-party tools:
- [x] The [manifest file][manifest-docs] has all fields filled out correctly.
Updated and included derived files by running: `python3 -m script.hassfest`.
- [x] New or updated dependencies have been added to `requirements_all.txt`.
Updated by running `python3 -m script.gen_requirements_all`.
- [x] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
> Adding support for the Core300S air purifier and fix Azure Pipelines (https://github.com/webdjoe/pyvesync/releases/tag/1.4.2)
- [x] Untested files have been added to `.coveragerc`.
The integration reached or maintains the following [Integration Quality Scale][quality-scale]:
<!--
The Integration Quality Scale scores an integration on the code quality
and user experience. Each level of the quality scale consists of a list
of requirements. We highly recommend getting your integration scored!
-->
- [ ] No score or internal
- [ ] 🥈 Silver
- [ ] 🥇 Gold
- [ ] 🏆 Platinum
<!--
This project is very active and we have a high turnover of pull requests.
Unfortunately, the number of incoming pull requests is higher than what our
reviewers can review and merge so there is a long backlog of pull requests
waiting for review. You can help here!
By reviewing another pull request, you will help raise the code quality of
that pull request and the final review will be faster. This way the general
pace of pull request reviews will go up and your wait time will go down.
When picking a pull request to review, try to choose one that hasn't yet
been reviewed.
Thanks for helping out!
-->
To help with the load of incoming pull requests:
- [x] I have reviewed two other [open pull requests][prs] in this repository.
- https://github.com/home-assistant/core/pull/62904#pullrequestreview-840623656
- https://github.com/home-assistant/core/pull/62900#pullrequestreview-840624010
[prs]: https://github.com/home-assistant/core/pulls?q=is%3Aopen+is%3Apr+-author%3A%40me+-draft%3Atrue+-label%3Awaiting-for-upstream+sort%3Acreated-desc+review%3Anone
<!--
Thank you for contributing <3
Below, some useful links you could explore:
-->
[dev-checklist]: https://developers.home-assistant.io/docs/en/development_checklist.html
[manifest-docs]: https://developers.home-assistant.io/docs/en/creating_integration_manifest.html
[quality-scale]: https://developers.home-assistant.io/docs/en/next/integration_quality_scale_index.html
[docs-repository]: https://github.com/home-assistant/home-assistant.io
Doesn’t quite do it yet and there are a few other wrinkles to fix.
1 Like
formatBCE
(Andrii)
March 30, 2022, 2:43pm
216
Hopefully. VeSync integration is way outdated.
1 Like
baz123
(Brian)
March 31, 2022, 7:55pm
217
I have created a new topic for a test repo I have created. VeSync development particularly for Levoit Humdifiers
vlebourl
(Vincent)
April 1, 2022, 3:01pm
218
Hey,
I’ll bring my own contribution to the subject. I made a HACS installable version of @baz123 ’s repo. I also started a bit of refactoring and cleaning up. Don’t hesitate to try it out and report problems. I only own the Dual 200S humidifier, so I can’t really do much on my own for other devices.
Cheers
NB: This has the same domain as the core integration for vesync on purpose to override it. Don’t install it if you rely on core capabilities that aren’t present in the custom one. Open an issue, I’ll try to add it.
2 Likes
baz123
(Brian)
April 1, 2022, 3:25pm
219
There shouldn’t be anything in this that isn’t in core as it started from core.
Again, learn something new - you can override the core component .
vlebourl
(Vincent)
April 1, 2022, 6:32pm
220
yes, just expose the same domain and custom component takes precedence.
1 Like
LCMilstein
(LCMilstein)
April 22, 2022, 12:35am
221
@formatBCE for the past few days, my humidifiers are becoming unavailable every few hours. I am able to get them back only by manually reinstalling the integration and restarting HA. That works for a few hours, and then repeat… Are you seeing this elsewhere? Any ideas?
formatBCE
(Andrii)
April 22, 2022, 12:55am
222
Hi!
Nope, stable for me…
Any logs in HA?
I am new to the home assistant, so my question is quite a newbie.
How do I update the config_flow file? Just replace ‘CONF_USERNAME’ and ‘CONF_PASSWORD’ with the actual info throughout the text’?
vlebourl
(Vincent)
July 5, 2022, 8:57am
224
The config flow is the popup that opens up when you do Add Integration
→ VeSync
. It will show the following dialog box
You’re not supposed to update it inside the code.
Hi, is this custom integration safe to run alongside the official one, or should I uninstall that first, before installing this one?
vlebourl
(Vincent)
August 12, 2022, 2:47pm
226
This custom integration is supposed to override the official one. But to be on the safe side, I would do it in this order:
Uninstall official integration
Restart HA to cleanup entities
Install the custom one through HACS
Restart HA to make it available
Configure through the Integration UI.
1 Like
That worked perfectly, thanks.
Anyone else having issues lately with the custom integration + the 300S? I think the API is acting up or something, it used to respond right away. Now it either doesn’t at all, or does after a LONG delay.
2022-09-30 13:54:12.341 DEBUG (SyncWorker_7) [pyvesync.helpers] [post] calling '/cloud/v2/deviceManaged/bypassV2' api
2022-09-30 13:54:14.084 DEBUG (SyncWorker_11) [pyvesync.helpers] HTTPSConnectionPool(host='smartapi.vesync.com', port=443): Read timed out. (read timeout=5)
2022-09-30 13:54:14.084 DEBUG (SyncWorker_11) [pyvesync.vesyncfan] Error getting status of Humidifier
It does seem reachable, maybe something changed on their end:
/config # host smartapi.vesync.com
smartapi.vesync.com is an alias for vesyncappapi-1834200178.us-east-1.elb.amazonaws.com.
vesyncappapi-1834200178.us-east-1.elb.amazonaws.com has address 34.197.50.0
vesyncappapi-1834200178.us-east-1.elb.amazonaws.com has address 34.206.253.195
vesyncappapi-1834200178.us-east-1.elb.amazonaws.com has address 174.129.159.121
vesyncappapi-1834200178.us-east-1.elb.amazonaws.com has address 52.207.121.218
/config # ping smartapi.vesync.com
PING smartapi.vesync.com (174.129.159.121): 56 data bytes
64 bytes from 174.129.159.121: seq=0 ttl=229 time=15.241 ms
64 bytes from 174.129.159.121: seq=1 ttl=229 time=14.738 ms
formatBCE
(Andrii)
September 30, 2022, 6:19pm
230
Just checked my devices - everything is working…
Do you have a 300S humidifier?
formatBCE
(Andrii)
September 30, 2022, 7:46pm
232
Yes, and I’m that person who wrote HA part of it’s integration
It works good.
1 Like