ahh, I see. Thanks for the infomation. Do you will integrate it before december?
Robban
October 24, 2023, 8:03pm
13
PR is up to support this, I hope it will be part of 2023.11 release.
home-assistant:dev
← Kane610:deconz-fix_lidl_christmas_light_effects
opened 07:58PM - 24 Oct 23 UTC
<!--
You are amazing! Thanks for contributing to our project!
Please, DO N… OT DELETE ANY TEXT from this template! (unless instructed).
-->
## Breaking change
<!--
If your PR contains a breaking change for existing users, it is important
to tell them what breaks, how to make it work again and why we did this.
This piece of text is published with the release notes, so it helps if you
write it towards our users, not us.
Note: Remove this section if this PR is NOT a breaking change.
-->
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
or resolves a feature request, be sure to link to that issue in the
additional information section.
-->
Support more light effects for the Lidl Christmas light.
Requested https://community.home-assistant.io/t/lidl-melinera-christmas-string-hg06467-lidl-livarno-lux/367639
## Type of change
<!--
What type of change does your PR introduce to Home Assistant?
NOTE: Please, check only 1! box!
If your PR requires multiple boxes to be checked, you'll most likely need to
split it into multiple PRs. This makes things easier and faster to code review.
-->
- [ ] Dependency upgrade
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [ ] New feature (which adds functionality to an existing integration)
- [ ] Deprecation (breaking change to happen in the future)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [x] Code quality improvements to existing code or addition of tests
## Additional information
<!--
Details are important, and help maintainers processing your PR.
Please be sure to fill out additional details, if applicable.
-->
- This PR fixes or closes issue: fixes #
- This PR is related to issue:
- Link to documentation pull request:
## Checklist
<!--
Put an `x` in the boxes that apply. You can also fill these out after
creating the PR. If you're unsure about any of them, don't hesitate to ask.
We're here to help! This is simply a reminder of what we are going to look
for before merging your code.
-->
- [ ] The code change is tested and works locally.
- [x] Local tests pass. **Your PR cannot be merged unless tests pass**
- [x] There is no commented out code in this PR.
- [x] I have followed the [development checklist][dev-checklist]
- [x] I have followed the [perfect PR recommendations][perfect-pr]
- [x] The code has been formatted using Black (`black --fast homeassistant tests`)
- [ ] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated for [www.home-assistant.io][docs-repository]
If the code communicates with devices, web services, or third-party tools:
- [x] The [manifest file][manifest-docs] has all fields filled out correctly.
Updated and included derived files by running: `python3 -m script.hassfest`.
- [x] New or updated dependencies have been added to `requirements_all.txt`.
Updated by running `python3 -m script.gen_requirements_all`.
- [x] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
- [x] Untested files have been added to `.coveragerc`.
<!--
This project is very active and we have a high turnover of pull requests.
Unfortunately, the number of incoming pull requests is higher than what our
reviewers can review and merge so there is a long backlog of pull requests
waiting for review. You can help here!
By reviewing another pull request, you will help raise the code quality of
that pull request and the final review will be faster. This way the general
pace of pull request reviews will go up and your wait time will go down.
When picking a pull request to review, try to choose one that hasn't yet
been reviewed.
Thanks for helping out!
-->
To help with the load of incoming pull requests:
- [ ] I have reviewed two other [open pull requests][prs] in this repository.
[prs]: https://github.com/home-assistant/core/pulls?q=is%3Aopen+is%3Apr+-author%3A%40me+-draft%3Atrue+-label%3Awaiting-for-upstream+sort%3Acreated-desc+review%3Anone+-status%3Afailure
<!--
Thank you for contributing <3
Below, some useful links you could explore:
-->
[dev-checklist]: https://developers.home-assistant.io/docs/development_checklist/
[manifest-docs]: https://developers.home-assistant.io/docs/creating_integration_manifest/
[quality-scale]: https://developers.home-assistant.io/docs/integration_quality_scale_index/
[docs-repository]: https://github.com/home-assistant/home-assistant.io
[perfect-pr]: https://developers.home-assistant.io/docs/review-process/#creating-the-perfect-pr
1 Like
@Robban Thanks for the good news
1 Like
@Robban Was this tested with actual hardware?
I have the HA deconz addon 6.22.0 and HA 2023.12.0b1 but colorloop
is still the only effect the selector presents me.
Robban
December 2, 2023, 11:13pm
16
No. I go on data I scrape together. There are way too many devices supported by deconz.
I expand thw effects list on the device model “TS0601”
OK understandable. Can I help debugging it?
Robban
December 2, 2023, 11:52pm
18
Yes can you start by validating the device model?
It will help with creating an issue on home assistant github
Ok - mfg id is _TZE200_s8gkrkxk
and model id is TS0601
The Phoscon webinterface lists it as LIDL Livarno Lux HG06467
The issue should be opened at the core
repo right?
edit: I verified that the effects are triggerarble by REST
Robban
December 3, 2023, 7:16am
20
Yes that’s correct
Do you see the other effects populated for the light?
You mean the effect selector dropdown in HA? No as said before it only lists colorloop
and that one is not supported by the device itself.
Robban
December 3, 2023, 4:02pm
22
At least that means the check for supporting effects work. But not the model id check.
I just verified the expected outcome by modifying the code so all devices reported support for all those LIDL Christmas light effects. A complete list of supported effects was provided as expected.
Can you enable debug logging per integration documentation instructions and share those?
So maybe I should exclude the colorloop from the TS0601?
If I search TS0601
at blakadders db I get a lot of devices… _TZE200_s8gkrkxk
lists only the Xmas strip.
I will try my best tomorrow (its nearly midnight here)
Which debugger components namespaces do I need to enable?
Its my production HA so it will be a bunch of data.
Should I do a REST PUT to deconz too?
Robban
December 4, 2023, 4:13pm
24
If you set the default logging to warning and then the deconz parts to debug there will not be much noise from other integrations. Set the logging config and reload the integration and you will have all relevant data in the logs.
Robban
December 6, 2023, 8:37pm
25
DWizzy
(Joris)
December 15, 2024, 7:52pm
28
Would it be possible to get this working in ZHA?
I noticed a thread on getting it to work in Zigbee2MQTT fail to see how I could get the effects into my ZHA setup without z2m or deCONZ.
Forgive me resurrecting yet another Christmas later.
Robban
December 16, 2024, 8:27am
29
This thread is about the support between deCONZ software and integration. Supporting this with ZHA is a separate request which involves other developers. So I suggest you create a new post in Feature Requests - Home Assistant Community
1 Like
DWizzy
(Joris)
December 17, 2024, 1:52pm
30
Thanks for your reply. That link led me eventually to an existing ZHA-device-handler issue #1933 , so here’s to hoping people there can replicate your work
1 Like