Same here. Mine seems to log out the Yale integration. I don’t need to reboot, but just sign back in again through the integration. However, I’ve got an automation setup to disarm the alarm in the morning and even though it’s sign out the automation I’m HA still runs and disarms the alarm at the scheduled time in the morning, but HA still thinks it’s armed and shows this in dashboard.
GTunney
(G Tunney)
January 18, 2022, 8:00am
83
Mine is exactly the same but requires a restart as when I click submit after entering credentials it just pops up again.
phairplay
(Phairplay)
January 18, 2022, 8:01am
84
I’m having the same issue, yet I believe it has been noticed and a fix will be seen in the next version of HA
home-assistant:dev
← gjohansson-ST:yale_alarm_fix
opened 11:52AM - 08 Jan 22 UTC
<!--
You are amazing! Thanks for contributing to our project!
Please, DO N… OT DELETE ANY TEXT from this template! (unless instructed).
-->
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
or resolves a feature request, be sure to link to that issue in the
additional information section.
-->
Improve code quality in alarm_panel for yale_smart_alarm
Bugfix to handle non-responding api call (request exceptions)
## Type of change
<!--
What type of change does your PR introduce to Home Assistant?
NOTE: Please, check only 1! box!
If your PR requires multiple boxes to be checked, you'll most likely need to
split it into multiple PRs. This makes things easier and faster to code review.
-->
- [ ] Dependency upgrade
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [ ] New feature (which adds functionality to an existing integration)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [x] Code quality improvements to existing code or addition of tests
## Additional information
<!--
Details are important, and help maintainers processing your PR.
Please be sure to fill out additional details, if applicable.
-->
- This PR fixes or closes issue: fixes #
- This PR is related to issue:
- Link to documentation pull request:
## Checklist
<!--
Put an `x` in the boxes that apply. You can also fill these out after
creating the PR. If you're unsure about any of them, don't hesitate to ask.
We're here to help! This is simply a reminder of what we are going to look
for before merging your code.
-->
- [x] The code change is tested and works locally.
- [x] Local tests pass. **Your PR cannot be merged unless tests pass**
- [x] There is no commented out code in this PR.
- [x] I have followed the [development checklist][dev-checklist]
- [x] The code has been formatted using Black (`black --fast homeassistant tests`)
- [ ] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated for [www.home-assistant.io][docs-repository]
If the code communicates with devices, web services, or third-party tools:
- [ ] The [manifest file][manifest-docs] has all fields filled out correctly.
Updated and included derived files by running: `python3 -m script.hassfest`.
- [ ] New or updated dependencies have been added to `requirements_all.txt`.
Updated by running `python3 -m script.gen_requirements_all`.
- [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
- [ ] Untested files have been added to `.coveragerc`.
The integration reached or maintains the following [Integration Quality Scale][quality-scale]:
<!--
The Integration Quality Scale scores an integration on the code quality
and user experience. Each level of the quality scale consists of a list
of requirements. We highly recommend getting your integration scored!
-->
- [ ] No score or internal
- [ ] 🥈 Silver
- [ ] 🥇 Gold
- [ ] 🏆 Platinum
<!--
This project is very active and we have a high turnover of pull requests.
Unfortunately, the number of incoming pull requests is higher than what our
reviewers can review and merge so there is a long backlog of pull requests
waiting for review. You can help here!
By reviewing another pull request, you will help raise the code quality of
that pull request and the final review will be faster. This way the general
pace of pull request reviews will go up and your wait time will go down.
When picking a pull request to review, try to choose one that hasn't yet
been reviewed.
Thanks for helping out!
-->
To help with the load of incoming pull requests:
- [x] I have reviewed two other [open pull requests][prs] in this repository.
[prs]: https://github.com/home-assistant/core/pulls?q=is%3Aopen+is%3Apr+-author%3A%40me+-draft%3Atrue+-label%3Awaiting-for-upstream+sort%3Acreated-desc+review%3Anone+-status%3Afailure
<!--
Thank you for contributing <3
Below, some useful links you could explore:
-->
[dev-checklist]: https://developers.home-assistant.io/docs/en/development_checklist.html
[manifest-docs]: https://developers.home-assistant.io/docs/en/creating_integration_manifest.html
[quality-scale]: https://developers.home-assistant.io/docs/en/next/integration_quality_scale_index.html
[docs-repository]: https://github.com/home-assistant/home-assistant.io
GTunney
(G Tunney)
January 18, 2022, 8:07am
85
Ah perfect, I did have a look but couldn’t find anything.
Looks like we’re also getting some new features soon, lock support and binary sensors.
Not trying to change the topic, but do we know if it’s been figured out yet how to trigger the alarm panel? I’ve been trying all sorts in my dev environment with no luck.
I’ve been reading through this and can see it’s been going on a while. Is there still no way for the status to change to ‘triggered’ if the alarm is set off?
I’ve not found a way of doing it. I’ve seen there are some posts out there, but I don’t think any work.
1 Like
gjohansson
(G Johansson)
January 25, 2022, 10:27am
89
It’s triggering events but the events are not self-explaining so the only way is really to trigger the alarm and see which code you get and so on for all kind of events.
I was planning to do that with also implementing a button for the panic alarm but haven’t come around yet to testing e.g. get the codes for triggered, if triggered by different events etc. etc. And personally I also don’t have contacts so can’t even test those cases.
If someone is voluntary and can run some python code for me I can invite you to the discord channel where it’s being discussed e.g. make it more concrete to get all the stuff in.
2 Likes
@gjohansson thanks for all the work on this integration and adding support for locks and contacts ! I been waiting for the lock support
Thanks again
1 Like
Hi @gjohansson ,
I’m happy to test, be great to get this rolled out. Also PM’d you.
Thanks
2 Likes
Thanks for the reply. I understand what you’re trying to accomplish but I’m new to python so don’t understand how to add the code, or know what code I need to add to my HA instance to see if it does work.
If anyone can explain this, I can test it too.
I’ve got the same issue with it logging me out daily, let’s hope it gets sorted as it is the easiest way to determine if everyone has left the house and drives a lot of my automations…
GTunney
(G Tunney)
February 1, 2022, 8:50pm
95
I realised mine goes offline at 04:20 every night so I set home assistant to reboot at 04:25. Now I don’t need to reauthenticate every morning.
Not ideal but a workaround for now.
jkk
February 2, 2022, 10:36am
96
Mine doing it too at 6:20 with 2021/12/10 core component.
I just updated to the dev version via HACS… lets see if it need reauthenticate tomorrow.
2021/11/5 notified also at 6:20 but I never needed to reauthenticate
jkk
February 2, 2022, 10:41am
97
I think this reauthenticating started after yale service brakes… maybe they did something that kicks us out every night…
jkk
February 2, 2022, 11:28am
98
Voluntary tester also here.
Thank you for all your efforts!
1 Like
Yep, mine’s the same. It’s strange, as the other work Yale must had been doing some maintenance as my hub completely lost connection to their network and I wasn’t able to connect to it from the app and also HA couldn’t see it. I know this is not related because the issue of the reauthentication has been going on for longer. But I also agree the issue could be them at the Yale end and they are kicking everyone out everyday.
I’m also available to test.
dezmod
(Dezmod)
February 4, 2022, 7:57am
101
Also happy to test as this have been driving me mad!! as a lot of my automation is based of alarm being deactivated.