Lovelace: Button card

kirpat · July 30, 2019, 2:55am

Dear, I found a problem
Don’t know if anybody else is facing,
I have an entity as button card which on hold_action was working well.
But after upgrading button-card few days back, it was toggling on single tap.

iantrich · July 30, 2019, 3:09am

It’s not clear what your actual problem is. You refer to a hold action working well but then start talking about toggling with a tap…what’s the actual problem?

kirpat · July 30, 2019, 3:28am

Dear
Hold_action was not working on holding the button.
It was toggling even on single tap.
I had to add tap_action: none before hold_action to get it working.

RomRider · July 30, 2019, 5:48am

Toggle is by default for tap, unless you define tap_action’s action as none. That’s not new at all.

RomRider · July 30, 2019, 5:52am

Okay, thanks for all the testing, appreciate it!
This bug was probably introduced by those 2 lines which where added to fix another bug:

github.com

custom-cards/button-card/blob/2d1cab4b1d1f57724a11ae821704219d7996cbfd/src/long-press.ts#L109


      
            }
            if (e.stopPropagation) {
              e.stopPropagation();
            }
            e.cancelBubble = true;
            e.returnValue = false;
            return false;
          });
          
          const clickStart = (ev: Event) => {
            ev.stopPropagation();
            if (this.cooldownStart) {
              return;
            }
            this.held = false;
            let x;
            let y;
            if ((ev as TouchEvent).touches) {
              x = (ev as TouchEvent).touches[0].pageX;
              y = (ev as TouchEvent).touches[0].pageY;
            } else {

github.com

custom-cards/button-card/blob/2d1cab4b1d1f57724a11ae821704219d7996cbfd/src/long-press.ts#L139


      
                  element.dispatchEvent(new Event('ha-hold'));
                }, element.repeat);
              }
            }, this.holdTime);
          
            this.cooldownStart = true;
            window.setTimeout(() => (this.cooldownStart = false), 100);
          };
          
          const clickEnd = (ev: Event) => {
            ev.stopPropagation();
            if (
              this.cooldownEnd
              || (['touchend', 'touchcancel'].includes(ev.type)
                && this.timer === undefined)
            ) {
              if (element.isRepeating && this.repeatTimeout) {
                clearInterval(this.repeatTimeout);
                element.isRepeating = false;
              }
              return;

Would you mind deleting them from 2.0.4 and test the result on your device please?

shauder · July 30, 2019, 5:57am

I actually tried that already and didn’t have any luck. It is also in the button-card.ts so I just tried removing it there also and I still have it happen unfortunately.

RomRider · July 30, 2019, 6:22am

That is really strange… It’s the only thing which was changed regarding touch/mouse events…

Also for this to work, you’d have had to remove the node_module folder and run npm install

RomRider · July 30, 2019, 7:07am

Could you try that file please? https://www.pastiebin.com/5d3fec8d63daf

EDIT: I’ve managed to reproduce the “second clic on the target tab” when moving from one tab to another tab on my phone (android) and it’s fixed with the above version for me.

shauder · July 30, 2019, 12:31pm

I think this fixed it!

krovachek · July 30, 2019, 2:35pm

It looks like the button card doesn’t like the swiping. I can swipe the views on the “empty” area (button card color type: blank) only my Lovelace dashboard:

RomRider · July 30, 2019, 2:38pm

Thanks, that’s going to be fixed soon. I’ll release something tomorrow.
It’s all related to this and this

shauder · July 30, 2019, 3:02pm

I appreciate all the work with resolving this and the great card itself.

pollinolas · July 30, 2019, 9:33pm

I have the same problem but in android, the lock option does not work, the entity is activated with a single click, I was going to communicate it here the other day but in the end I deleted the post thinking that the problem would be mine for any reason, I deleted cache and It does not work, however on the PC everything is correct. Thank you for the support of the creator.

pollinolas · July 30, 2019, 9:46pm

hello, in my case if I change the tab and return to the first one, at the first click the lock option works well but the next time it activates the entity again with a single click, I am with android I guess the problem will be the same as that of the companions with ios and you can sloucionar it in the next update, greetings and thanks

klogg · July 30, 2019, 9:58pm

I must admit to having lost track a bit with state of play with this, I kinda switched off when it looked like an IoS problem but I also get this on Android.

As I said I’ve lost track so if it is in the process of being fixed ignore me, and if it isn’t, I’m not complaining, just adding some info.

RomRider · July 31, 2019, 6:06am

Feel free to open github issues/look at the github issues when you encounter problems.

It’s also easier for me to track them over there than over here

MrEd · July 31, 2019, 6:38am

Hello.
I have button with tap action to switch sonoff relay on/off
But is any method to add on hold button more-info from other entity?
Tap change relay but i need more-info from tradfri bulb. Color and brightness sliders.

RomRider · July 31, 2019, 6:58am

hold_action:
  action: more-info
  entity: your_other.entity

klogg · July 31, 2019, 7:58am

Done, but it’s not a big problem for me.

pollinolas · July 31, 2019, 8:10am

thanks for open it,for me lock option its essential.