PSA: Alexa Media Player v4.13.3 breaks all versions of Home Assistant

Gav_in · October 4, 2024, 2:43pm

as FYI…looks like the plan to block AMP in HA has been reverted according to this PR now that AMP v4.13.3 has been pulled

github.com/home-assistant/core

Revert Alexa Media Player block

home-assistant:dev ← home-assistant:frenck-2024-0528

opened 10:47AM - 04 Oct 24 UTC

frenck

+0 -5

## Proposed change  Reverts #127412 Original issue: https://github.com/alandtse/alexa_media_player/issues/2579 I'm unblocking this one, as Alexa Media Player v4.13.3 has been pulled and is no longer available. Integrations should never crash the system. That said, the previous versions are not great either, but blocking it will make us look like bad guys in this case (even though, IMHO, it is the right thing to do right now). I would rather have the community look at the state of the custom integration and report upstream instead. Additionally, instead of pulling the version, it would have been better to have shipped a new version (as it allows people to upgrade themselves out of the issue they are having). It allows us to block older versions at that point (preventing people from getting into a crashing issue at all). Let's see how this develops from here on. We can always reinstate this block if it continues to be problematic. /CC @alandtse ## Type of change  - [ ] Dependency upgrade - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New integration (thank you!) - [ ] New feature (which adds functionality to an existing integration) - [ ] Deprecation (breaking change to happen in the future) - [ ] Breaking change (fix/feature causing existing functionality to break) - [ ] Code quality improvements to existing code or addition of tests ## Additional information  - This PR fixes or closes issue: fixes # - This PR is related to issue: - Link to documentation pull request: ## Checklist  - [x] The code change is tested and works locally. - [x] Local tests pass. **Your PR cannot be merged unless tests pass** - [x] There is no commented out code in this PR. - [x] I have followed the [development checklist][dev-checklist] - [x] I have followed the [perfect PR recommendations][perfect-pr] - [x] The code has been formatted using Ruff (`ruff format homeassistant tests`) - [ ] Tests have been added to verify that the new code works. If user exposed functionality or configuration variables are added/changed: - [ ] Documentation added/updated for [www.home-assistant.io][docs-repository] If the code communicates with devices, web services, or third-party tools: - [ ] The [manifest file][manifest-docs] has all fields filled out correctly. Updated and included derived files by running: `python3 -m script.hassfest`. - [ ] New or updated dependencies have been added to `requirements_all.txt`. Updated by running `python3 -m script.gen_requirements_all`. - [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.  To help with the load of incoming pull requests: - [x] I have reviewed two other [open pull requests][prs] in this repository. [prs]: https://github.com/home-assistant/core/pulls?q=is%3Aopen+is%3Apr+-author%3A%40me+-draft%3Atrue+-label%3Awaiting-for-upstream+sort%3Acreated-desc+review%3Anone+-status%3Afailure  [dev-checklist]: https://developers.home-assistant.io/docs/development_checklist/ [manifest-docs]: https://developers.home-assistant.io/docs/creating_integration_manifest/ [quality-scale]: https://developers.home-assistant.io/docs/integration_quality_scale_index/ [docs-repository]: https://github.com/home-assistant/home-assistant.io [perfect-pr]: https://developers.home-assistant.io/docs/review-process/#creating-the-perfect-pr

@poudenes you asked about the block too so just FYI